mirror of
https://github.com/vacp2p/boringssl.git
synced 2026-08-27 11:41:09 +00:00
Lily Chen
f0e21a5334
This reverts commit96a007fb32, thus relanding commitf89068d303. The build failure in Chromium's component build was because accessing impl->tbs_sig_alg.get() instantiates the StackAllocated<X509_ALGOR, ...> template, which emits relocations for internal symbols (x509_algor_init and x509_algor_cleanup), and these are not pruned in unoptimized mode. The fix (diff from patchset 1) is to avoid reaching into X509Impl internals to construct the test cert. Instead, all the desired (intentionally invalid) test certs were generated by the MTC demo tool, and checked in as testdata and parsed directly. Original change's description: > Revert "crypto/x509: Verify standalone Merkle Tree Certs (MTCs)" > > This reverts commitf89068d303. > > Reason for revert: build failure crbug.com/549361069 > > Failure Link: https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer/79105/overview > > Original change's description: > > crypto/x509: Verify standalone Merkle Tree Certs (MTCs) > > > > This implements verification of "standalone" Merkle Tree Certs (see > > draft-ietf-plants-merkle-tree-certs-05, section 6.3) as part of the > > X509_STORE_CTX API, if the flag X509_V_FLAG_USE_MTC_DRAFT_PLANTS_05 > > is specified. > > > > Bug: 503746594 > > Change-Id: Ie5abd17eb34c37139d3be1261e1914976a6a6964 > > Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/100707 > > Reviewed-by: David Benjamin <davidben@google.com> > > Commit-Queue: Lily Chen <chlily@google.com> > > Presubmit-BoringSSL-Verified: boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> > > TBR=davidben@google.com,boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com,chlily@google.com > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 503746594, 549361069 > Change-Id: If43293ba7c2199a463a98dcf848fcc60bdd1e9bb > Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/101307 > Presubmit-BoringSSL-Verified: boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> > Auto-Submit: Lily Chen <chlily@google.com> > Reviewed-by: David Benjamin <davidben@google.com> > Commit-Queue: David Benjamin <davidben@google.com> # Not skipping CQ checks because this is a reland. Bug: 503746594 Cq-Include-Trybots: luci.boringssl.try:linux_clang_shared_compile,linux_clang_shared_rel_compile Change-Id: I2376b492ecc0e6bfcfc0acb36cc0f1511dd29db7 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/101467 Commit-Queue: Lily Chen <chlily@google.com> Reviewed-by: David Benjamin <davidben@google.com>