This reverts commit a044ef2d5fa838f6ecb73947c74a11fa717f66b1.
Would rather provide back-compatibility Nippy side to prevent all
the dep conflicts that this'll lead to
This is a bit of a pita (and still doesn't solve issues when user
adds logging calls w/in her own macros); but it's better than nothing
while we wait on some kind of resolution to CLJ-865.
This lets folks more easily use Chrome blackboxing but it'd still be
nice to get a proper general-case line number solution.
Seems like our options are:
1. Waiting on CLJ-865 (which'd still leave us w/o accurate source
map links?).
2. Something like https://gist.github.com/bgrins/5108712 (doesn't
seem possible if we want a more elaborate wrapper?)
3. Other ideas??
This is useful since it allows one to dynamically set the log level
prior to ClojureScript compilation. Specifically, I would like to
use this inside of a Boot task.
Hashing is still done on a data level as before (with arb data-hash-fn);
difference is that {:timbre/hash _} arg0 support is now baked in to core
logging impl. rather than just the default data hash fn.
Effect: a new `:?hash-arg` is now provided as part of core data and will
be available to any data-hash-fns.
New implementation is also cleaner + faster.
- This simplifies the requirements for appender authors.
- Note that middleware authors still need to be careful since
it'd be infeasible to offer similar protection between each
individual layer of middleware.
Having difficulty reproducing the error described by the GitHub issue.
Figure the cause might have something to do with attaching the type info
to the (fn []) form? The approach as of this commit seems like it'd be
less likely to trip up the compiler.