[#22206 ] fix: swap proposal keep sending update either after clean up

e2e: fix for collectibles tests
2025-03-04 11:34:24 +03:00 · 2025-03-04 00:09:00 +02:00
4 changed files with 11 additions and 13 deletions
@@ -249,15 +249,13 @@

 (rf/reg-event-fx :wallet/stop-get-swap-proposal
 (fn [{:keys [db]}]
-   (let [route-request-ongoing? (some? (get-in db [:wallet :ui :swap :last-request-uuid]))]
-     (when route-request-ongoing?
-       {:db            (update-in db [:wallet :ui :swap] dissoc :last-request-uuid)
-        :json-rpc/call [{:method   "wallet_stopSuggestedRoutesAsyncCalculation"
-                         :params   []
-                         :on-error (fn [error]
-                                     (log/error "failed to stop fetching swap proposals"
-                                                {:event :wallet/stop-get-swap-proposal
-                                                 :error error}))}]}))))
+   {:db            (update-in db [:wallet :ui :swap] dissoc :last-request-uuid)
+    :json-rpc/call [{:method   "wallet_stopSuggestedRoutesAsyncCalculation"
+                     :params   []
+                     :on-error (fn [error]
+                                 (log/error "failed to stop fetching swap proposals"
+                                            {:event :wallet/stop-get-swap-proposal
+                                             :error error}))}]}))

 (rf/reg-event-fx
 :wallet/clean-swap-proposal
@@ -43,7 +43,7 @@ class TestWalletCollectibles(MultipleSharedDeviceTestCase):
        self.wallet_view.collectibles_tab.click()
        self.wallet_view.set_network_in_wallet(self.network_name)
        collectibles = {
-            "BVL": {"quantity": 2,
+            "BVL": {"quantity": 1,
                    "info": {"Account": "Account 1",
                             "Network": "Base",
                             "category": "Football Player",
@@ -102,8 +102,8 @@ class TestWalletCollectibles(MultipleSharedDeviceTestCase):
        self.wallet_view.collectibles_tab_on_select_token_view.click()
        time.sleep(5)
        self.wallet_view.get_collectible_element('BVL').click()
-        self.wallet_view.amount_input_increase_button.click()
-        self.wallet_view.confirm_button.click()
+        # self.wallet_view.amount_input_increase_button.click()
+        # self.wallet_view.confirm_button.click()
        for text in [self.account_name, self.sender_short_address]:
            if not self.wallet_view.from_data_container.get_child_element_by_text(text).is_element_displayed():
                self.errors.append(self.wallet_view,
@@ -118,7 +118,7 @@ class TestWalletCollectibles(MultipleSharedDeviceTestCase):
        data_to_check = {
            'Est. time': ' min',
            'Max fees': r"[$]\d+.\d+",
-            'Recipient gets': '2 '
+            'Recipient gets': '1 '
        }
        for key, expected_value in data_to_check.items():
            try:
Author	SHA1	Message	Date
Mohsen	8d5189398e	[#22206 ] fix: swap proposal keep sending update either after clean up	2025-03-04 11:34:24 +03:00
Yevheniia Berdnyk	767be39673	e2e: fix for collectibles tests	2025-03-04 00:09:00 +02:00