status-im
/
status-react
mirror of https://github.com/status-im/status-react.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fastlane: disable default_keychain to avoid race condition 

If we run parallel job and a job sets a temporary keychain into a
default than another job can assume that is the user default.

The result is that one of the jobs will attempt to set a non-existent
temporary keychain into the default keychain.

This happens when we call `Fastlane::Actions::DeleteKeychainAction`:
https://github.com/fastlane/fastlane/blob/2.164.0/fastlane/lib/fastlane/actions/delete_keychain.rb#L21

Signed-off-by: Jakub Sokołowski <jakub@status.im>
This commit is contained in:
Jakub Sokołowski 2020-11-05 15:24:00 +01:00
parent 0d82dab5c5
commit 34c6292af4
No known key found for this signature in database
GPG Key ID: 4EF064D0E6D63020
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fastlane/Fastfile
View File

@ -91,8 +91,8 @@ class Keychain
unlock: true, unlock: true,
# Lock it up after 25 minutes just in case we don't delete it. # Lock it up after 25 minutes just in case we don't delete it.
timeout: 1500, timeout: 1500,
# To make Fastlane import WWDR certificate into it. # Setting a default can cause a race condition with parallel jobs.
default_keychain: true, default_keychain: false,
) )
end end