From 34c6292af4421c3b611d3b5aac5f2242ba95c2c7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Soko=C5=82owski?= Date: Thu, 5 Nov 2020 15:24:00 +0100 Subject: [PATCH] fastlane: disable default_keychain to avoid race condition MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If we run parallel job and a job sets a temporary keychain into a default than another job can assume that is the user default. The result is that one of the jobs will attempt to set a non-existent temporary keychain into the default keychain. This happens when we call `Fastlane::Actions::DeleteKeychainAction`: https://github.com/fastlane/fastlane/blob/2.164.0/fastlane/lib/fastlane/actions/delete_keychain.rb#L21 Signed-off-by: Jakub SokoĊ‚owski --- fastlane/Fastfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fastlane/Fastfile b/fastlane/Fastfile index f34e25d443..a4249ac815 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -91,8 +91,8 @@ class Keychain unlock: true, # Lock it up after 25 minutes just in case we don't delete it. timeout: 1500, - # To make Fastlane import WWDR certificate into it. - default_keychain: true, + # Setting a default can cause a race condition with parallel jobs. + default_keychain: false, ) end