status-im
/
status-qml
mirror of
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
status-qml/.github/pull_request_template.md

992 B
Raw Blame History

Checklist

  • follow conventional commits
    • the scope should be the component's name e.g: feat(StatusListItem): ...
    • when adding new components, the scope is the module e.g: feat(StatusQ.Controls): ...
  • add documentation if necessary (new component, new feature)
  • update sandbox app
    • in case of new component, add new component page
    • in case of new features, add variation to existing component page
    • nice to have: add it to the demo application as well
  • test changes in both light and dark theme?
  • is this a breaking change?
    • use the dedicated BREAKING CHANGE commit message section
    • resolve breaking changes in status-desktop
      • (pre-merge) adapt code to breaking changes
      • (post-merge) update StatusQ submodule pointer
  • test changes in status-desktop