We wanted to move towards having multiple functions
manipulating the data rather than relying on a chain of
dispatched events.
I have refactored ui.screens.contacts.events so that now the
functions mainly manipulate fx, passed as a first parameter.
Their responsability is to make sure their fx are merged in, so
that they can be composed more easily.
Signed-off-by: Eric Dvorsak <eric@dvorsak.fr>
When a contact is removed it is set to pending?.
If the same contact is added again we now dispatch a :start-chat event
which initiate a 1-1 chat with them.
- Combine merge-pr.sh and merge-external-pr.sh using merge-external-pr.sh as a base
- Modify script interface to ./scripts/merge-pr.sh <PR-ID> and remove options to run with REPO_URL BRANCH arguments
- Works regardless of where PR is hosted and whether or not it is signed by external contributor.
Signed-off-by: Sebastian Delgado <sdalcega@gmail.com>
Signed-off-by: Eric Dvorsak <eric@dvorsak.fr>
If current locale is xx-YY, looks up xx_YY first, xx then and finally
falls back to us.
goog.i18n.DateTimeSymbols database is used for localization.
Signed-off-by: Eric Dvorsak <eric@dvorsak.fr>
Fixes#2971
Because I don't think it is worth a bounty - all the code required was already in the `merge-external-pr.sh` so I have just copied the relevant parts across and added the few necessary lines to ensure that PRs from core contributors cannot be merged unless they have been squashed down to a single commit.
Changed fatal to confirm for merge-pr
use re-frame idiomatic register-handler-fx, reg-fx and coeffect.
the events are still not free of side-effects as there is some
db calls involved which will be taken care of in a future PR
it also reduces the events fired at app init from 3 to 1
discover-related event
I have uncommented the two namespaces:
contacts.events was mainly an issue with schema validation
and a few features not covered by tests.
the tests in pre-receiver were actually passing, the issue was a
test suite in wallet.events which was run asychronously by re-frame
which meant the http request in the fx was actually being fired.
Signed-off-by: Oskar Thoren <ot@oskarthoren.com>
alwxndr
Andrea Maria Piana
Eric Dvorsak
Sebastian Delgado
Julien Eluard
Dmitry Novotochinov
Pedro Pombeiro
yevh-berdnyk
Goran Jovic
Roman Volosovskyi
janherich
Oskar Thoren
Mikhail Gusarov
Audrius Molis
Andy Tudhope
Foo Pang
nrakochy
Adam Babik
Ivan Borovkov
Ivan Borovkov
Igor Mandrigin
Eugene Zadyra
dumiz