status-im
/
status-mobile
mirror of https://github.com/status-im/status-mobile.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add changes to PR checklist discussed in Istanbul 

Signed-off-by: Pedro Pombeiro <pombeirp@users.noreply.github.com>
This commit is contained in:
Pedro Pombeiro 2019-09-20 10:57:27 +03:00
parent a1735e4577
commit 4a95b88e36
No known key found for this signature in database
GPG Key ID: C4A24185B2AA48A1
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
.github/github-bot.yml vendored
View File

@ -19,4 +19,11 @@ github-team:
prchecklist: prchecklist:
title: Pull Request Checklist title: Pull Request Checklist
checklist: checklist:
- 'Have you updated the documentation, if impacted (e.g. [docs.status.im](https://docs.status.im/docs/build_status.html))?' - '**Docs**: Updated the [documentation](https://status.im/build_status/), if affected'
- '**Docs**: Added or updated inline comments explaining intention of the code'
- '**Tests**: Ensured that all new UI elements have been assigned accessibility IDs'
- '**Tests**: Signaled need for E2E tests with label, if applicable'
- '**Tests**: Briefly described what was tested and what platforms were used'
- '**UI**: In case of UI changes, ensured that UI matches [Figma](https://www.figma.com/)'
- '**UI**: In case of UI changes, requested review from a Core UI designer'
- '**UI**: In case of UI changes, included screenshots of implementation'