From 4a95b88e36584b389926f1c413fc307de6502bc6 Mon Sep 17 00:00:00 2001 From: Pedro Pombeiro Date: Fri, 20 Sep 2019 10:57:27 +0300 Subject: [PATCH] Add changes to PR checklist discussed in Istanbul Signed-off-by: Pedro Pombeiro --- .github/github-bot.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/github-bot.yml b/.github/github-bot.yml index 808c780632..2f85fac2a7 100644 --- a/.github/github-bot.yml +++ b/.github/github-bot.yml @@ -19,4 +19,11 @@ github-team: prchecklist: title: Pull Request Checklist checklist: - - 'Have you updated the documentation, if impacted (e.g. [docs.status.im](https://docs.status.im/docs/build_status.html))?' + - '**Docs**: Updated the [documentation](https://status.im/build_status/), if affected' + - '**Docs**: Added or updated inline comments explaining intention of the code' + - '**Tests**: Ensured that all new UI elements have been assigned accessibility IDs' + - '**Tests**: Signaled need for E2E tests with label, if applicable' + - '**Tests**: Briefly described what was tested and what platforms were used' + - '**UI**: In case of UI changes, ensured that UI matches [Figma](https://www.figma.com/)' + - '**UI**: In case of UI changes, requested review from a Core UI designer' + - '**UI**: In case of UI changes, included screenshots of implementation'