Changes done in this commit solve the " The process cannot access the file because it is being used by another process." error
which was noticeable on Windows while migrating a profile keypair to a Keycard.
* in all cases update the original urls in case they changed with a new
api key
* Update current urls only if the current one is the same as the
previous original one and the original one did change
Replace usage of `eth_getTransactionByHash` with `eth_getTransactionReceipt`
when polling for changes. `eth_getTransactionReceipt` delivers also the
status of the transaction.
Update tests to account for the new changes
Propagate status with the update event
Refactoring of the `pendingtxtracker.go` file to emit notifications with
a new payload structure that includes transaction identity and deletion status.
Closes status-desktop [#12120](https://github.com/status-im/status-desktop/issues/13124)
ghstack-source-id: 936bff5a417cb7a4aa42c93fc9dacb03fc35943b
Pull Request resolved: https://github.com/status-im/status-go/pull/4523
Refactor the test helpers for pending transactions by extracting the mock
implementations and helper functions into a new file `transactions/testhelpers.go`.
Update event names for clarity and consistency in `pendingtxtracker.go`.
Updates status-desktop: [#13124](https://github.com/status-im/status-desktop/issues/13124)
ghstack-source-id: d85756b80fefd3bf7590637cb7f4dc1af615cecd
Pull Request resolved: https://github.com/status-im/status-go/pull/4492
- favourite column removed from the saved_addresses table
- favourite property removed from the SavedAddress struct
- ens name removed from the primary key, the primary key now is composed of address and is_test columns
- ens parameter removed from wakuext_deleteSavedAddress
- wallet_getSavedAddresses moved to wakuext_getSavedAddresses (to keep them all in a single place)
- saved addresses related endpoints removed from the wallet service, even they logically belong there, a reason for that
is avoiding emitting sync message if one uses calls from the wallet service, while that's not the case in ext service. Once
we refactor this and introduce devices syncing mechanism in the wallet service, we should not only these but other wallet
related endpoints move there (removed: wallet_getSavedAddresses, wallet_addSavedAddress and wallet_deleteSavedAddress).
Affected area:
Saved addresses
Reading the Nonce from the local cache may be incorrect if the tx is made out of the Status app or
if Status app sends a tx prepared by the dapp (via WalletConnect). A submitted tx with a wrong Nonce
results in a failing tx, that's why we need to read the Nonce from the network.
