Commit Graph

682 Commits

Author SHA1 Message Date
Stefan 16ed8739e8 fix(wallet) fix Add Account Modal and wallet tests
- fix add-account-modal custom derivation checkbox blocking all workflows
- fix, improve and enable wallet tests
- wait_for_text_matching alternative, to is_text_matching, to check also for content as squish driver API
- add objectName based lookup for in some places where user-text was used
- add workaround to retry for 10 seconds add watch due to flakiness
- rename SquishDriver.type to type.text not to conflict with python's type
- add optional timeout to some APIs
- ignore error for extra step in reaching onboarding seedphrase in linux

Updates: #9576
2023-03-01 15:36:06 +04:00
Noelia 83bdc7f104 feat(Wallet/NetworkFilter): Extended component API
Extends API to allow single UI selection network into `NetworkFilter` and `NetworkSelectPopup` updated.
2023-02-28 14:17:47 +01:00
Dario Gabriel Lipicar ed1a0d04a0 fix(@desktop/wallet): avoid storing CurrencyAmount objects in QML 2023-02-27 08:22:41 -03:00
Khushboo Mehta 2dbf2d4635 fix(@desktop/wallet): Remove the 'Load More' button from the Activity view and replace with automatic loading when the user scrolls down using a skeleton loading state
fixes #8987
2023-02-23 18:04:08 +01:00
Anthony Laibe d9ed23b2d6 fix(@wallet): trim tx data 2023-02-23 14:53:45 +01:00
Lukáš Tinkl b8f6cbcfa1 fix(i18n): properly format floating point numbers
- the percentage/changes were left untreated
2023-02-20 12:44:36 +01:00
MishkaRogachev b70e1f0fb4 feat(ActivityCenter): Add indication for visited/unvisited AC state
Close #347
2023-02-17 16:13:43 +04:00
Stefan 3bb667bb7a feat(Wallet) cache fetched balance history to DB for efficiency
- Bump status-go head that include the required specific changes
  - fetch token balance (native or ERC20) and cache historical token quantity data
  - fetch FIAT currency
- Extend presentation layer (NIM and QML) to account for API changes
- Remove timed request and other optimizations from the time of fetching
  balance history every time instead of querying cache
- Add C++ integration debugging tests and update network chain configuration (outdated)

Closes: #8175
2023-02-15 18:52:37 +04:00
Sale Djenic a12e599be2 feat(@desktop/wallet): adding wallet derivation path updates
Check box added to warn user if they want to add a path out of the
default Status' wallet derivation path. In case they do that, they are
not able to migrate such keypair to a Keycard.

Closes: #9118
2023-02-13 10:41:53 +01:00
Lukáš Tinkl 4dc97dde1a chore: unbreak bad merge
utils is imported twice
2023-02-09 12:02:35 +01:00
Stefan 9b7c2b15c0 fix(wallet): add wallet account - enable advanced section all the time
Closes: #9357
2023-02-08 19:53:09 +01:00
Alexandra Betouni aa2e6386a2 fix(statusApp): resolving qml errors/warnings pt2.1
Relates to #8864
2023-02-08 18:43:51 +02:00
Alexandra Betouni d553934b45 fix(popups): set scrollview sizing 2023-02-08 18:43:51 +02:00
Anthony Laibe 8ba10ce6b0 fix(@wallet): display network short name for collectible
fixes #8850
2023-02-08 09:26:59 +01:00
Khushboo Mehta 9e23f78180 feat(@desktop/wallet): Implement loading state for collectibles
fixes #9106
2023-02-08 09:25:04 +01:00
Sale Djenic 3f52df4f87 fix(@desktop/wallet): opening add account popup causes the app to crash
Fixes: #9412
2023-02-03 12:57:39 +01:00
Sale Djenic c0d761aa78 fix(@desktop/wallet): unable to add account
Fixes adding account modal, which was broken due to incomplete
`SelectGeneratedAccount` enum change.
2023-02-01 14:12:55 +01:00
Alex Jbanca 81a4d70932 chore(Qt5.15): Fix qml warnings after qt 5.15 migration
Fixing QML Connections warnings due to deprecated onFoo handlers. Now we're using function onFoo(params).
Fixing QML compilation error due to js filename format.
Fixing cyclic dependencies between qml components.
2023-01-31 20:39:19 +02:00
Khushboo Mehta dfcba80df2 fix(@desktop/wallet): Added missing LoadingGraphComponent in qmldir 2023-01-31 11:20:28 +01:00
Khushboo Mehta 169de5b5e1 feat(@desktop/wallet): Add loading State for Assets view and Wallet main navigation page 2023-01-31 07:57:37 +01:00
Dario Gabriel Lipicar 20733272f2 feat(@desktop/wallet): implement new collectibles view
Fixes #8810
2023-01-30 15:30:11 +01:00
Ivan Belyakov e3086fd52c chore: Removed duplicated AddEditSavedAddressPopup.qml, fixed dependencies
fixes #8229
2023-01-27 05:57:55 +03:00
Anthony Laibe 55d39aa7c7 fix(@wallet): preview button instead of enter password/pin
fixes #9119
2023-01-26 16:58:23 +01:00
Ivan Belyakov f2549fc1ff feat(@desktop/wallet): update wallet navigation
Fixed StatusBaseButton to expose a property to load either normal
icon or a round one.
Implemented new wallet navigation according to design in Figma.
Fixed regression: small accounts icons in accounts list view.
Updated wallet test.

Fixes #8598
2023-01-26 09:49:29 +01:00
Sale Djenic b44fc7a842 fix(@desktop/keycard): keycard may be factory reseted during unlock flow in some scenarios (onboarding part)
- Unexpected wiping out the data during the unlock flow handled (onboarding part)
- Back button actions fixed part 2/2 (onboarding part)

Fixes: #9183
2023-01-26 09:05:57 +01:00
Dario Gabriel Lipicar a6afdb5266 fix(@desktop): use system locale across the application 2023-01-17 16:39:56 -03:00
Dario Gabriel Lipicar d11017f7b3 feat(@desktop/wallet): implement unified currency formatting in send/bridge modal
Fixes #8934
2023-01-17 16:39:56 -03:00
Sale Djenic cae2a5bea3 feature(@desktop/keycard): sync a Keycard state on every usage
Closes: #8759
2023-01-13 21:02:36 +01:00
Dario Gabriel Lipicar 7c4022e4ac feat(@desktop/wallet): implement unified currency formatting
Fixes #8640
2023-01-12 15:21:27 -03:00
Alexandra Betouni ba811acc27 fix(improvements): remove console warnings pt1
Closes #7959
2023-01-04 17:28:59 +02:00
Noelia 579075d6cc fix(StatusQ/StatusListItemTag): Changed API and added test elide property when a specific width is forced
- Changed `StatusListItemTag` API. Now it is based on `Control` component.
- Updated needed qml files to fit with the new `StatusListItemTag` API.
- Added `elide` property in `Text` component to better visualise the content when a specific width is forced.
2022-12-21 18:42:16 +01:00
Dario Gabriel Lipicar 9feb6c29cf feat(@desktop/wallet): reworked collectibles backend
Fixes #8407
2022-12-19 08:07:04 -03:00
Dario Gabriel Lipicar bd986a5b6b fix(@desktop/wallet): adjust collectible details screen to design 2022-12-15 11:18:29 -03:00
Anthony Laibe 9b0d9cf478 feat(@wallet): Display ens name in account view
fixes #8607
2022-12-14 16:04:58 +01:00
Anthony Laibe a7884cf04f feat(@wallet): re-org wallet footer
fixes #8600
2022-12-14 09:56:08 +01:00
Anthony Laibe 9aaea49e2c fix(@wallet): remove dead code 2022-12-05 15:26:44 +01:00
Anthony Laibe 0d217c0db0 feat: add wallet token integration 2022-12-02 10:17:47 +01:00
Igor Sirotin e3bfdc0f09 fix(StatusPopupMenu): Refactoring 2022-12-02 10:30:50 +03:00
Khushboo Mehta 9ded9d4ffa feat(@deaktop/wallet): Add bridge view
fixes #8236
2022-12-01 17:15:55 +01:00
Dario Gabriel Lipicar ecd799c209 fix(@desktop/wallet): fix switch accounts after opening collectible details
Moved logic for CollectibleDetailView to Nim module.
2022-11-23 15:29:19 -03:00
alexjba 98d3073a61 Update min text length in password 2022-11-23 15:21:21 +02:00
Khushboo Mehta 6c0806c2e1 (@desktop/wallet): Fix for pending tx not shown in history view
fixes #7530
2022-11-22 13:57:50 +01:00
Khushboo Mehta 8084b90b5c test: Renabled test case for Simple transaction
fixes #7983
2022-11-20 14:44:37 +01:00
Stefan 7d9f13e4bd fix() don't change global network selection in receive modal
Adds a networks proxy model to be used with the original source model
for visualization and independent selection of isEnabled (as isActive) for a custom
purpose.

Use the proxy in the receive modal dialog for selection of networks
to be included in the address. This way the view follows the original
model but allows independent selection of networks.

Closes: #8180
2022-11-16 15:40:03 +01:00
Stefan 7bd9808476 fix(receive) fix header alignment for ReceiveModal
Add a reusable header shared between Send and Receive modals

Updates #8180
2022-11-16 15:40:03 +01:00
Stefan d0389a6305 feat(Wallet) show balance cache for chain native token
Quick integration of fetching balance in the current chart view.

The proper implementation requires refactoring the QML views to separate
price chart, that depends only on the token and chain, from balance that
depends on token, chain and address.

Closes: #7662
2022-11-16 13:07:46 +01:00
Dario Gabriel Lipicar 47f7373838 fix(@desktop/wallet): correct error message when adding own ENS name to saved addresses
#8114
2022-11-15 07:26:45 -03:00
Dario Gabriel Lipicar 9dd004b690 fix(@desktop/wallet): fix add new saved address popup close button
#8214
2022-11-14 09:49:40 -03:00
Noelia e9f84b2973 test(suite_wallet): Created `bdd_hook` for each `suite_wallet` test case
- Created `bdd_hooks` that contain the sing up steps just only once in the feature start and the needed start steps depending on the test case.

- Updated feature files removing sign up steps and given/when/then reorganization.

Closes #8026
2022-11-10 15:43:02 +01:00
Sale Djenic 105e1c156b fix(@desktop/keycard): `ExportPublic` instead of `Sign` flow should be used for user authentication
Fixes: #8176
2022-11-10 11:03:44 +03:00
Sale Djenic 3da62c9092 fix(@desktop/wallet): adding derived wallet account fixed
An issue with adding wallet account was happening only for a new user,
the reason for that was incorrectly set keystore path and keystore file couldn't
be found on the statusgo side because of that.
2022-11-10 11:03:44 +03:00
Sale Djenic 2c03146309 fix(@desktop/keycard): can't create accounts if the main account was restored in using an existing keycard account
`I already use Status` -> `Login with Keycard` flow is enabled.

Fixes: #7867
2022-10-28 20:43:09 +02:00
MishkaRogachev 6a72773ab6 feat(ActivityCenter): Refactor AC Store and fix notifications counting
Close #7654
2022-10-28 12:29:40 +03:00
Khushboo Mehta aec7a30d03 feat(@desktop/wallet): Updated UI for bridge and multi routing support
fixes #7334
2022-10-26 18:48:30 +02:00
Anthony Laibe 76aedc3615 feat(@wallet): display ens name with saved addressess 2022-10-24 12:39:34 +02:00
Lukáš Tinkl 7a407662e2 feat: New Profile Modal
Fixes: #7360
2022-10-17 12:05:54 +02:00
Stefan 057d0c565e fix(Wallet): fix import seed in account creation
Remove the workaround, to the approach of using the complete last word event,
for three letters seed-words. The three letters condition introduced
another side effect when completing the "sentence" and made the
_internal.mnemonicInput contain an extra duplicate word.

Unify the event `doneInsertingWord` generation for the internal purpose
with the external. This will trigger a secondary for some usage but
I see no problem with even in other usages.

Fix corner case when user enters a correct seed word that is not singular
and uses the mouse to jump. In that case the doneInsertingWord is not triggered

Fixes: #7715
2022-10-14 14:20:35 +02:00
Khushboo Mehta 7e82b36509 feat(@desktop/wallet): Create API to retrieve historical price for a token
fixes #7260
2022-10-14 10:29:29 +02:00
Stefan de2c421b5e fix(Wallet): allow to edit name and color for a new account before authentication
There is no good reason to keep user entering information before authenticating

Also fix typo

Fixes: #7714
2022-10-10 16:54:46 +02:00
MishkaRogachev 9d103e5b07 feat(ActivityCenter): Fix unreadNotificationsCount availability on every section
Close #7674
2022-10-04 17:05:47 +04:00
Stefan 39527a5739 fix(wallet): fix never fetching transactions
The RootStore was calling checkRecentHistory on the wallet section View
instead of the transaction View.

Still the workflow is broken due to the 20 minutes timer that calls
the checkRecentHistory and hangs the the main thread (UI) for a long time

Fixes: #7266
2022-09-29 10:45:27 +02:00
Alexandra Betouni fc3daa1451 (StatusSectionLayout): removed big space between header and content
Closes 7312
2022-09-28 15:37:52 +03:00
Sale Djenic 4e257539b8 chore(@desktop/keycard): `usingBiometricLogin` prop added to the user profile global instance 2022-09-27 20:15:34 +02:00
Sale Djenic 3687df2a2f chore(@desktop/keycard): `isKeycardUser` prop added to the user profile global instance 2022-09-27 20:15:34 +02:00
Sale Djenic 861c585d2b feat(@desktop/keycard): adding wallet account using `Authenticate` flow
Fixes: #7509
2022-09-27 20:15:34 +02:00
Sale Djenic db1bbef0e1 fix(@desktop/wallet): validation of a seed phrase if it contains a word of length 3 fixed 2022-09-27 20:15:34 +02:00
Sale Djenic 64f167a32d fix(@desktop/wallet): pasting seed phrase fixed 2022-09-27 20:15:34 +02:00
Sale Djenic 4bff0b14ed fix(@desktop/wallet): crash adding an account via seed phrase fixed 2022-09-27 20:15:34 +02:00
Alexandra Betouni dd08cb60c2 fix(AssetsDetailView): fixed warning 2022-09-20 14:31:17 +03:00
Michał Cieślak f900e7c00e fix(general): buttons font fixed, font loading refactored
Fixes: #7389
2022-09-19 22:10:25 +02:00
Alexandra Betouni b47b3e8be6 feat(AssetDetailView): Adding price history chart
Closes #6490
2022-09-15 18:13:38 +03:00
Lukáš Tinkl f4a78a1f10 fix: port to StatusButton changes in master
and pull in changes from StatusQ master
2022-09-14 09:16:58 +02:00
Jonathan Rainville aba2a42c6f test(@wallet): allow to use ganache with goerli 2022-09-13 11:56:42 +02:00
Stefan 6e78281d99 test(FavouriteSavedAddresses/Wallet): test toggle favourite for saved addresses
Also
- fix the other saved addresses that were relying on the order of
buttons and fail after adding the favourite button
- improve the rest of the tests
- improve debug buttons
- extend driver with helper functions

Closes: #6898
2022-09-12 16:00:31 +02:00
Stefan 7af95eaada feat(wallet): add favorites for saved addresses
Depends on statug-go favourite flag extension and merging of `favourites`
with `saved_address` tables and API

Additional changes:

- Remove duplicate name instead of ESN

Closes: #6546
2022-09-12 15:58:52 +02:00
Khushboo Mehta 928e1999d9 feat(@desktop/wallet): Implement Transaction details as per new design
fixes #7214
2022-09-09 21:36:58 +02:00
Lukáš Tinkl 5897615cc1 hotfix(AddAccountModal): fix setting account emoji
probably a leftover from the StatusAssetSettings porting
(plus remove some non-existing functions)
2022-09-08 12:23:43 +02:00
Alexandra Betouni 262a6c3160 fix(AddAccountModal): Updated password error message
Closes #5719
2022-09-06 18:48:17 +03:00
Sale Djenic 07a0cdc680 fix(@desktop/keycard): additional updates
- `Setup a new Keycard with an existing account` flow improved
- code review comments applied
- Qml part updated due to the latest `StatusListItem` changes in `StatusQ`
2022-09-06 15:06:13 +02:00
Anthony Laibe eb357ff6e2 fix(@wallet): Add account not working 2022-09-05 14:28:42 +02:00
Alexandra Betouni e1c548696f feat(Desktop)!: Updating desktop app due to IconSettings refactor
As part of https://github.com/status-im/StatusQ/issues/781
2022-09-02 18:41:21 +03:00
Alexandra Betouni b6ff7b9ded feat(desktop): Made activity button be visible everywhere
Closes #6635
2022-09-02 10:29:23 +03:00
Stefan b499942eea fix(Wallet/AddAccountModal): fix status-go error messages
Remove the unneeded native error dialog showing internal status-go
error strings. Instead redirect the error message for wrong private key
as specific error message.

Fixes: #6984
2022-08-30 19:05:06 +02:00
Anthony Laibe e020466362 fix(@wallet): paste seed phrase 2022-08-30 14:17:33 +02:00
Khushboo Mehta 0515152bd7 feat(@desktop/wallet): Add Token Detail View
fixes #6491
2022-08-23 10:52:26 +02:00
PavelS 9f2833b994 fix(@desktop/wallet): adjust receive modal adress
Fixes #6966
2022-08-22 16:01:05 +03:00
Anthony Laibe ade9086b81 test(@wallet): add test for ens name 2022-08-18 13:11:36 +02:00
Michał Cieślak 21aeeb8906 fix(@desktop/wallet): add account - password checking adjusted 2022-08-16 18:27:16 +02:00
Khushboo Mehta 210d5ca2eb fix(@desktop/wallet): Can see collectibles for an account
fixes #6896
2022-08-15 11:53:17 +02:00
Anthony Laibe 2f7e6998bf test(@wallet): Add test for toggling network & balance 2022-08-11 14:09:07 +02:00
Igor Sirotin 3b40649b7b fix(RecipientSelector): Fixed validation 2022-08-11 00:32:09 +03:00
PavelS 1613605296 fix(@desktop/wallet) adjust network dropdown
Fixes #6486
2022-08-09 17:52:43 +03:00
Stefan 2398b67bc1 fix(wallet): bring back copy wallet address
Depends on StatusQ's StatusAddressPanel generic control

Fixes: #6659
2022-08-05 17:05:02 +02:00
Anthony Laibe c3e345445c test(@wallet): edit/delete saved addresses 2022-08-05 09:43:05 +02:00
Anthony Laibe a51c25e90e test(@wallet): test add saved address
fixes #6761
2022-08-05 09:43:05 +02:00
Jonathan Rainville 8b4ceec773 test: cleanup names.py and structure it + some fixes to onboarding tests
Fixes #6539
2022-08-03 13:08:32 -04:00
Khushboo Mehta e5358bf29a fix(@desktop/wallet): Implements basic collectible view
fixes #6492
2022-08-03 10:11:09 +02:00
Anthony Laibe 03b3b0c6f5 test(@wallet): send transaction 2022-08-03 09:45:55 +02:00
Khushboo Mehta 39cf2f3fac fix(@desktop/wallet): Token selector in the send modal doesn't look like design and overflows window
fixes #6499
2022-08-03 09:26:18 +02:00
Patryk Osmaczko 5b51a7ce81 chore(settings): fix naming: locale->language 2022-07-27 14:22:50 +02:00
Alexandra Betouni c11ee2d3e8 fix(Wallet): Saved address add/edit modal layout issues
- Also replaced StatusModal with StatusDialog

Closes #6495
2022-07-26 13:53:34 +03:00
Khushboo Mehta 7ba6e06bc5 fix(@desktop/wallet): QR network picker style is a bit off
fixes #6386
2022-07-25 21:12:10 +02:00
Alexandra Betouni 84522bd7fe fix(CommunitiesPortal): fixed status input as per design
Closes #https://github.com/status-im/status-desktop/issues/6358
2022-07-25 15:07:27 +03:00
Alexandra Betouni 3b0dbd6052 fix(Wallet/AssetList): Updated as per designs
Closes #6481
2022-07-25 13:30:50 +03:00
Anthony Laibe 46f82f2c5e feat(@test): Add test for delete account 2022-07-22 09:20:55 +02:00
Anthony Laibe 499b9bd09e feat(@test): Add test for watch only account 2022-07-22 09:20:55 +02:00
MishkaRogachev 9aa1a1073e fix(@desktop): Fix scrolling in chat components, wallet fixes 2022-07-21 18:44:30 +03:00
MishkaRogachev 667db7038a fix(@desktop): StatusScrollView fixes for wallet 2022-07-21 18:44:30 +03:00
MishkaRogachev 58e0fce819 feat(@desktop): Fix twitchy scrolling issues
Close #6187
2022-07-21 18:44:30 +03:00
MishkaRogachev 0d3aed0611 fix(@desktop): Fix scrolling twitches using ScrollView amd Flickable items
Close #5781
2022-07-21 18:44:30 +03:00
Khushboo Mehta 189d793b87 fix(@desktop/wallet): Multinetwork QR code sometimes doesn't update when there is only 1 network left
fixes #6496
2022-07-21 15:32:13 +02:00
Khushboo Mehta b6f16c8a47 fix(@desktop/wallet): Wallet account generation popup doesn't support tab navigation
Please not tab access for advanced view is not implemented

fixes #6388
2022-07-21 15:25:02 +02:00
Pascal Precht 95a1945bff fix: handle sync currency settings
This updates the desktop client with a newly emitted currency settings
that might originate from synchronization

Partially addresses #5201
2022-07-20 13:49:18 -04:00
Alexandra Betouni 7df5ddc1e7 fix(Wallet/SavedAddresses): updated addresses list delegate
based on new designs

Closes #6494
2022-07-20 16:54:42 +03:00
Lukáš Tinkl 81cda65b20 chore(i18n): add some missing i18n()
+ remove one last qsTrId()
2022-07-20 11:31:15 +02:00
Lukáš Tinkl 7e243da180 fix(WalletHeader): align wallet section header with design
Closes #6484: Account header is different from design

Closes #6485: Account layout needs margins adjusted to match design
2022-07-20 10:22:51 +02:00
Lukáš Tinkl 8bddc64671 fix(SavedAddressesView): saved addresses header should look like designs
Closes: #6493
2022-07-20 10:22:51 +02:00
Lukáš Tinkl 5be18c2b1d fix(NetworkFilter): network filter UI fixes
Closes #6483: all networks button should match design

Closes #6487: networks button should display number of selected networks

Closes #6488: network tags should display icons and look like designs
2022-07-19 14:07:40 +02:00
Lukáš Tinkl 3bfbe104a4 fix(Wallet/LeftTabView): style fixes
Fixes #6489

- fixup list items background according to design
- fix Add account button (add icon, fix font size)
2022-07-18 14:28:01 +02:00
Lukáš Tinkl 024843b8b8 fix(Wallet/LeftTabView): style fixes
Align the Wallet left section navigation bar to the design

Fixes #6479
Fixes #6480

- simplify using layouts
- fix margins/spacing
- fix font sizes and weights
2022-07-18 14:28:01 +02:00
Khushboo Mehta 864bdd63fa fix(@desktop/wallet): Fix for Wallet icon background color seems off in wallet settings under dark mode
fixes #6059
2022-07-13 13:20:29 +02:00
Khushboo Mehta 5d6f2df145 fix(@desktop/wallet): Fix visual issues in add account modal
1. Alignment of the Inputs
2. Background color of the derived address panel

There is another issue pening which is already reported separately as https://github.com/status-im/status-desktop/issues/6315

fixes #6257
2022-07-12 15:14:35 +02:00
Alexandra Betouni 353110d4ae fix(AddAccountPopup): layout issues
Closes #6315
2022-07-08 14:41:28 +03:00
Lukáš Tinkl 4e71f813a2 fix(settings): flags are blurred in the Languages list
Fixes #6306

- update the StatusQ components to the latest commit which includes
the StatusIcon fixes
- switch the LanguageStore and CurrenciesStore to use SVG icons for flags
and money icons instead of PNGs
2022-07-06 20:52:48 +02:00
Patryk Osmaczko e0a5afebee chore(translations): transform `qsTrId` to `qsTr`
issue: #4544
2022-07-06 19:09:50 +02:00
Anthony Laibe ce7340b9a5 feat(@wallet): multi network history 2022-07-04 09:58:39 +02:00
Alexandra Betouni b550a23dfc fix(Wallet): Fixed padding in add account popup
Closes #6245
2022-06-28 16:24:09 -04:00
Khushboo Mehta 8d3fad8342 feat(@desktop/wallet): Multichain QR Code
Implements the new Recieve Modal with multichain functionality

closes #5735, #6057
2022-06-17 01:27:35 +05:30
Igor Sirotin 1870e9a0ce fix: Moved `StatusTabButton` to StatusQ 2022-06-15 12:23:19 -04:00
Sale Djenic 4403fde4ca fix(@desktop/wallet): 18 words seed option is missing when adding an account in wallet
Fixes #5445
2022-06-03 20:00:30 +02:00
Michal Iskierko eb12d9f7cd fix(@desktop/wallet): not remove seed phrases when changing number of words in wallet section
Fix #5613
2022-05-25 17:42:36 -04:00
Boris Melnik aa1dae9e20 fix(@desktop/warnings): Fix bunc of qml/nim warnings
Closes: #5162
2022-05-25 14:27:25 -04:00
Khushboo Mehta 86cfbec8f9 feat(@desktop/wallet): Add support for custom derivations path
Make getDerivedAddresses call async
Show pending and error states when gettting the derived addresses

fixes #5700, #5699
2022-05-18 14:16:57 +02:00
Khushboo Mehta 0ee0c8ddd4 feat(@desktop/wallet): Add has activity to the derived addresses in wallet
fix #5655
2022-05-18 13:42:00 +02:00
Sale Djenic c47f3f2692 feat(@desktop/wallet): redesigned wallet addresses are missing checksum
Fixes #5473
2022-05-17 16:04:59 +02:00
Khushboo Mehta 1cf701a758 feat(@desktop/wallet): greying out already imported/derived addresses in address list and also choosing next available as default one
fixes #5539
2022-05-13 09:23:47 +02:00
Jonathan Rainville 4db64841eb fix(wallet): improve wallet seed phrase import form
Fixes #5652
2022-05-12 15:29:30 -04:00
Jonathan Rainville 9586ff9dc5 fix: fix emoji icon picker and create channel inputs
Fixes #5673
2022-05-10 16:10:38 -04:00
Noelia 59631cad8f feat(Language & Currency): Currency settings screen
Added currency picker into `LanguageView.qml`.

Added `category` and `imageSource` property to existing `CurrenciesStore.qml`. Renamed `code` to `shortName`.

Added `currenciesModel` property to `WalletStore.qml`.

Added wallet store into `LanguageView.qml` in order to link to the currencies model.

Added some tokens in the currencies store.

Made wallet and any currency related UI code that uses current currency use the new Display Currency value.

Removed no longer used wallet/settings related files.

Closes #5385
2022-05-04 16:16:59 +02:00
Anthony Laibe 6145b4b620 fix(@wallet): loading collectibles 2022-04-13 14:51:38 -04:00
Anthony Laibe 4b54751b4f fix(@wallet): hide password from add watch only 2022-04-13 16:23:49 +02:00
Anthony Laibe 5ba3e541d7 fix(@wallet): Update add account modal close policy
fixes #5446
2022-04-13 16:10:19 +02:00
Khushboo Mehta 29db292472 fix(@desktop/wallet): Can't add an address to saved addresses
fixes #5534
2022-04-13 13:54:36 +02:00
Khushboo Mehta feaa91d062 feat(@desktop/wallet): Add derivation path to wallet account generation
fixes #5074
2022-04-13 11:17:53 +02:00
Jonathan Rainville 684a1ce913 fix(wallet-emoji): fix wallet emoji save by only saving the utf char
Fixes #5161
2022-04-12 18:22:12 -04:00
Khushboo Mehta d9d7a54f84 feat(@desktop/wallet): re-add adding watch only address to wallet
fixes #5471
2022-04-11 16:49:52 -04:00
Anthony Laibe 3bf4d65a74 fix(@wallet): hide use 24 word button 2022-04-08 19:11:01 +02:00
Khushboo Mehta 87640aafb1 fix(@desktop/wallet): Allow entering private keys with and without 0x prefix
fix #5406
2022-04-08 15:01:12 +02:00
Khushboo Mehta d054ea58f2 fix(@desktop/wallet): In the dark mode, the menu of networks in wallet looks incorrect
fixes #5123
2022-03-30 15:32:09 -04:00
Khushboo Mehta 2852d70731 feat(@desktop/Wallet): Add acccounts Modal as per new design
fixes #5073
2022-03-29 17:20:15 -04:00
Anthony Laibe 696e8aba29 fix(@browser): shared assets/history view
fixes #5129
2022-03-29 12:48:04 +01:00
Stefan D 51e31f3d42 fix(Wallet): Don't allow HTML tag special characters in Saved Addresses 2022-03-28 23:05:32 +03:00
Stefan D 74e2305ec8 fix(Wallet): Don't allow HTML tag special characters in Account Name
Also
- Add maximum character filter (40) not to allow unlimited characters that break
the visualization

updates: #4961
2022-03-28 23:05:32 +03:00
Anthony Laibe 63cec38916 feat(@wallet): account settings in now in settings section 2022-03-28 15:05:31 -04:00
Khushboo Mehta 0903fa6ce2 feat(@desktop/wallet): Adapt to new SendModal Design
fixes #5040
2022-03-28 13:08:56 -04:00
Khushboo Mehta 33e3d2377e fix(@desktop/wallet): User stays on removed account view in wallet after account removal from settings
fixes #5037
2022-03-25 08:30:52 -04:00
Khushboo Mehta 7d58ac9983 feat(@desktop/wallet): Move action buttons to bottom as per new design
fixes #5075
2022-03-23 17:12:33 -04:00
Khushboo Mehta f5e67fc658 feat(@desktop/wallet): adapt receive modal design
closes  #5039
2022-03-16 15:27:00 -04:00
Khushboo Mehta 4c677d55e8 feat(@desktop/wallet): Add emoji to Wallet accounts.
Support added to:
1. Wallet list
2. Adding a new account
3. Editing an account

fixes #4926
2022-03-15 11:41:29 +01:00
Khushboo Mehta 6e0471c943 bash: py: command not found
feat(@desktop/wallet): Add emoji to Wallet accounts.
Support added to:
1. Wallet list
2. Adding a new account
3. Editing an account

fixes #4926
2022-03-13 08:54:28 -04:00
Anthony Laibe 7754822bc8 clean(@wallet): remove old manage assets
this has been moved to the wallet settings
2022-03-11 10:46:38 +01:00
Alexandra Betouni c2977e468f feat(onboarding): Added SplashScreen
- Added SplashScreen as initial screen before
onboard as per new designs.
- Also moved all onboarding related code from
main to onboarding section and switched to
import this and all other sections as
qml modules, exposing this way only
necessary files.
- Cleaned up unecessary qmldir files and
imports.

Closes #4954
2022-03-08 14:02:24 -05:00
Khushboo Mehta cc55f811b1 fix(@desktop/wallet): Re-add saved addresses view from Wallet V2
fixes #4747
2022-03-03 15:47:42 +01:00
Khushboo Mehta 44a8b6df0a fix(@desktop/wallet): add/re-add buy crypto feature
fixes #4925
2022-03-02 18:45:22 +01:00
Khushboo Mehta d47ac2d5f7 feat(@desktop/wallet): cpp: Added apis for
1. Generate new API
2. Import accounts by PK
3. Import account by seed phrase
4. Add watch only address
5. delete account
6. current account
2022-02-24 10:53:18 +01:00
Anthony Laibe 92bc1fdab1 feat(@wallet): toggle network 2022-02-18 15:25:55 +01:00
Anthony Laibe 0acfd9b50c feat(@wallet): bring back filter network from wallet2 2022-02-16 11:20:13 +01:00
Anthony Laibe 7268ec3773 feat: prepare token service for multichain 2022-02-14 14:37:42 +01:00
Patryk Osmaczko ba7a6d5d34 style: remove trailing whitespaces 2022-02-09 11:16:23 +01:00
Jonathan Rainville 485d6a370d fix(@wallet): [re-add] tx history view
Fixes #4684

Correctly display the date and if the node is an archival node
2022-02-08 08:47:29 -05:00
Sale Djenic e7f1106f79 fix(@desktop/wallet): delete account
Fixes #4683
2022-02-07 16:23:03 +01:00
Noelia 9673c399e5 fix(@desktop/wallet): [base_bc] can't copy wallet address
Store propagation in order to use the global copyToClipboard method.

It is also applied in WalletV2.

Fixes #4636
2022-02-01 11:51:31 +01:00
Anthony Laibe 1a255f5bcc fix(@wallet): Show token modal
fixes #4621

the crash seemed to be caused by signal of signal. Simplifying the flow
remove the need for this signal of signal
2022-02-01 11:51:15 +01:00
Anthony Laibe 234af3283e fix(@wallet): receive modal
fixes #4534
2022-02-01 11:50:17 +01:00
Anthony Laibe c9e049e6d8 fix(@wallet): Fix text area for importing private key
fixes #4535
2022-02-01 11:50:17 +01:00
Anthony Laibe c505564522 fix(@wallet): hide signing phrase accept
fixes #4517
2022-02-01 11:50:17 +01:00
Sale Djenic f0ca1a4cc3 refactor(@desktop/general): many errors from the log are fixed
- various issues on app start in console
- various issues when logging out in console
- `node_section` module delete method error
- SyntaxError: JSON.parse: Parse error from the MessageStore
2022-02-01 11:49:04 +01:00
Sale Djenic 9b1e794e8f refactor(@desktop/settings-pivacy-security): privacy and security section updated 2022-02-01 11:47:43 +01:00
Sale Djenic 6e1438d241 refactor(@desktop/general): `globalUtils` instance added (changed old `utilsModel`) 2022-02-01 11:44:56 +01:00
Anthony Laibe fdca0da77d feat: saved address view
Connect list and change
Provide view API
Create events
2022-02-01 11:43:44 +01:00
Sale Djenic b3f8af8e06 refactor(@desktop/general): qml code referring to the old code base commented out
Qml code referring to the old code base commented out, but not deleted,
due to easier refactoring the rest of the app.
2022-02-01 11:42:42 +01:00
Alexandra Betouni f0b39ce4f6 Refactor: Moved openPopup function to Global
The openPopup function was declared in AppMain
and used via dynamic scoping in many places in the
application. Moved function to Global component
and updated all places to call it via Global instead.

Closes #4267
2022-02-01 11:38:46 +01:00
Alexandra Betouni 336f90a60f feat(desktop/wallet) Removed dynamic scoping from wallet
Removed all dynamic scoping parts in wallet section plus

- Renamed Config to Global and added more functions there
- Moved changeAppSectionBySectionType function to Global
  and updated all places where is used to call it from
  Global instead
- Moved openLink function to Global and updated all places
  where is used to call it from Global instead
- Moved errorSound to Global, introduced playErrorSound
  function  and updated all places where is used to call
  this function from Global instead

Closes #4245
2022-02-01 11:38:27 +01:00
Anthony Laibe 6c4fab1a20 fix(@wallet): delete account
fixes #4384
2022-01-10 15:58:57 +01:00
Anthony Laibe 8889bbdb08 fix(@wallet): tx history view
fixes #4385

Correctly display the date and if the node is an archival node
2022-01-10 15:58:36 +01:00
Anthony Laibe 5eb582b18c fix(@wallet): Collection without assets
fixes #3808

In some cases, the opensea API return collection for an owner without
assets, we handle this case in the UI
2022-01-06 15:16:32 +01:00
Alexandra Betouni a57fb330bd fix(dekstop/wallet) wrong account color displayed
In receive modal the account color was not corresponding to
the actual account color

* Updated StatusAccountSelector to use accounts from
  new backend
* Updated WalletHeader to use currentAccount from new
  backend

Closes #4071
2021-11-17 16:24:12 +02:00
Anthony Laibe df670bfcbb fix(desktop/wallet): new account with error 2021-11-16 10:07:15 +01:00
Jonathan Rainville 2d0c95feb3 fix: fix adding custom tokens
Fixes #4040 for real this time
2021-11-11 09:58:05 -05:00
Pascal Precht 7fcd280fe0 fix(@desktop/wallet): ensure NFT background colors are rendered correctly
Also adjust margins of collectible items to adhere to designs.

Fixes: #3981
2021-11-05 11:02:45 -04:00
Alexandra Betouni 6d944dfb69 fix (desktop/wallet) fix menu button add button
Closes #3980
2021-11-05 11:02:45 -04:00
Pascal Precht ca4c1904d8 fix(AddAccountWithSeedModal): ensure AccountSelector is working 2021-11-05 11:02:45 -04:00
Anthony Laibe 63963039eb fix(@desktop/wallet): make the receive modal use the old wallet
as it is not yet migrated
2021-11-05 11:02:45 -04:00
Sale Djenic 05cf431339 fixed issues after rebase 2021-11-05 11:02:45 -04:00
Anthony Laibe 59f604349c refactor(@wallet/desktop): refactor wallet with new architecture
refactor: wallet: connect current account

refactor(@wallet): load collection and connect to store

refactor(@wallet): add boilerplate for accounts creation/generation

refactor(@wallet): watch account

refactor(@wallet): Add account generation

refactor(@wallet): display all accounts

refactor(@wallet): switch account

refactor(@desktop): update current currency

refactor(@desktop/wallet): token action

refactor(@desktop/wallet): Add update account

refactor(@desktop/wallet): filter chat account from wallet

refactor(@desktop/wallet): Update currency attribute

refactor(@desktop/wallet): Fix display of various balances

refactor(@dekstop/wallet): handle current account changed

refactor(@wallet/desktop): add notify event on main section

refactor(@desktop/wallet): Push events from service

refactor(@desktop/wallet): handle all tokens event

refactor(@desktop/wallet): refresh accounts on event

refactor(@wallet/desktop): formatting of currency balances

refactor(@desktop/wallet): load collectible

refactor: refactor wallet transaction history to the new architecture

update status-lib

refactor: add back events for the transaction history

refactor: support multiple accounts in the transaction history
2021-11-05 11:02:45 -04:00
Iuri Matias 7c8f3f5923 add mnemonic module 2021-11-05 11:02:45 -04:00
Sale Djenic 3f6bb66536 refactor(@desktop/general): `globalSettings` moved to Nim 2021-11-05 11:02:45 -04:00
Sale Djenic f0b2ed6cca refactor(@desktop/general): `appSettings` moved to Nim 2021-11-05 11:02:45 -04:00
Anthony Laibe a7a56cf471 refactor(@desktop/wallet): connect ui and account token 2021-11-05 11:02:45 -04:00
Anthony Laibe 4bc61134c4 refactor(@desktop/wallet): Connect list account and qml 2021-11-05 11:02:45 -04:00
Anthony Laibe 4bbf19c470 refactor(@wallet/desktop): bind new token list to qml 2021-11-05 11:02:45 -04:00
Sale Djenic 37e9150021 Cleaning up the code, and removing leftovers 2021-11-05 11:02:45 -04:00
Sale Djenic 30f11c06d4 onboarding process updated, import account feature handled 2021-11-05 11:02:45 -04:00
Pascal Precht b91a423801 refactor: replace StatusWalletColor components with StatusQ components 2021-10-28 11:31:21 +02:00
Alexandra Betouni 426c116bac refactor(desktop) Made shared a QML module
Use it as import shared 1.0, import shared.controls 1.0
etc instead of import "../../../shared"

Closes #3934
2021-10-27 18:05:45 -04:00
Pascal Precht 8617c70742 refactor: remove AccountSelector and replace with StatusAccountSelector 2021-10-27 11:48:43 -04:00
Khushboo Mehta 7114240e72 refactor: Replace and remove StatusRoundButton under ui/shared/status
closes #3898
2021-10-26 18:58:16 +02:00
Pascal Precht 2db77fa31c refactor: replace StatusIcon and StatusLoadingIndicator with StatusQ components 2021-10-26 10:47:47 -04:00
Pascal Precht cbbbedcc79 cleanup: remove legacy `StatusCheckbox` 2021-10-26 10:47:16 -04:00
Khushboo Mehta ef4934cee4 refactor: Replace usage of StatusRadioButton under ui/shared to its corresponding StatusQ component
closes #3897
2021-10-26 14:37:15 +02:00
Pascal Precht 6db7b5be44 refactor(@desktop/wallet): replace legacy StatusButton with StatusQ StatusButton 2021-10-21 09:22:35 -04:00
Pascal Precht 87ea584b62 refactor: move `Timer` to ui/shared/controls 2021-10-14 12:51:27 -04:00
Pascal Precht e598df1d1e refactor: move `TextWithLabel` to ui/shared/panels 2021-10-14 12:51:27 -04:00
Pascal Precht e6df5c8b12 refactor: move `StyledTextEdit` to ui/shared/controls 2021-10-14 12:51:27 -04:00
Pascal Precht 61ccf9c757 refactor: move `StyledText` to ui/shared/panels 2021-10-14 12:51:27 -04:00
Pascal Precht ed73651db8 refactor: move `SplitViewHandle` and `StatusTabButton` to ui/shared/panels|controls respectively 2021-10-14 12:51:27 -04:00
Pascal Precht 4bb4708528 refactor: move `SearchBox` to ui/shared/controls 2021-10-14 12:51:27 -04:00
Pascal Precht 322a071aa3 refactor: move `SVGImage` to ui/shared/panels 2021-10-14 12:51:27 -04:00
Pascal Precht 4003f30d68 refactor: move `RoundedImage to ui/shared/panels 2021-10-14 12:51:27 -04:00
Pascal Precht fa3adb30e4 refactor: move `PopupMenu` to ui/shared/popups 2021-10-14 12:51:27 -04:00
Pascal Precht cbfe90947e refactor: move `ModalPopup` to ui/shared/popups 2021-10-14 12:51:27 -04:00
Pascal Precht bdc7c799d2 refactor: move `Input` to ui/shared/controls 2021-10-14 12:51:27 -04:00
Pascal Precht 5d05b415ba refactor: move view and panels components into controls if they belong there 2021-10-14 12:51:27 -04:00
Pascal Precht 00a61daabd refactor: move `Address` into ui/shared/panels 2021-10-14 12:51:27 -04:00
Pascal Precht 2d47223e1c refactor: move `AccountSelector` into ui/shared/panels 2021-10-14 12:51:27 -04:00
Pascal Precht 4e8f2303e6 refactor(@desktop/profile): introduce new QML and store structure in profile section
Closes #3712
2021-10-14 09:29:05 -04:00
Khushboo Mehta 80de3f75eb fix(@desktop/wallet): move QML Wallet section to new architecture
fixes #3714
2021-10-13 13:53:01 -04:00
¨Anthony e0c5e9b9b0 fix(@desktop/wallet): gas error position 2021-09-28 15:36:11 -04:00
Alexandra Betouni 4ee21ada05 feat(desktop) Added image function in Style
Introduced Style.svg() Style.png() Style.emoji() and
Style.icon() in Style.qml. Those should be used to
set the source in Images instead of using relative
paths. Usage:
Image {
   source: Style.svg("check)
   ....

Also moved all Singletons inside a new "utils"
folder and made it a QML module, to use
import utils 1.0 instead of relative paths

Closes #3678
2021-09-28 15:28:00 -04:00
Anthony Laibe 712c75f051 fix(@desktop/wallet): Fix backup warning
Also prevent backup warning to be double when we switch wallet 2 to 1
2021-09-20 12:18:16 -04:00
Richard Ramos 285f54dab6 EIP1559 2021-09-10 13:42:19 -04:00
Richard Ramos db3b7ecfd9 feat: Version Updating
Fixes #1290
2021-08-24 16:56:55 -04:00
Anthony Laibe c5d841f68d fix(@desktop/wallet): view in 'collectible' close modal
fixes #2644
2021-08-16 14:33:09 -04:00
Khushboo Mehta 09fb1a173c fix(@desktop/wallet) Truncate long wallet amount
Added logic to convert large amounts to Millions and Billions

fixes #2667
2021-08-13 15:03:24 +02:00
Anthony Laibe 08e3b330e5 fix(@desktop/wallet): correct position of not enough gas error
fixes #2714

Increase height of the modal and position the validator to below the previous
item
2021-07-28 16:03:10 -04:00
Andrei Smirnov a3979511e2 fix(@desktop/wallet): modal is not being closed when clicking Add Account 2021-07-20 10:05:52 -04:00
Anthony Laibe 4269b51ea6 feat(@desktop/wallet): display confirmation block count
fixes #2715
2021-07-19 13:33:32 -04:00
Sale Djenic 1acbc76cc9 chore(@desktop/general): run translation script
All untranslated properties are translated now using translation scripts.
2021-07-19 12:27:45 -04:00
Richard Ramos 065bd26786 fix: code review 2021-07-06 11:58:47 -04:00
Richard Ramos 5f7f899c3b refactor: separate slots for sending eth and tokens 2021-07-06 11:58:47 -04:00
Eric Mastro 77e501c478 fix(wallet): QML error when loading history
Fixes: #2725.

When clicking on the History tab for a wallet account, there was a QML error for `qrc:/app/AppLayouts/Wallet/WalletLayout.qml:113: TypeError: Property 'checkIfHistoryIsBeingFetched' of object HistoryTab_QMLTYPE_503(0x7fed35da2710) is not a function`. This must have been reintroduced when StatusQ objects were introduced. It has now been removed.

chore: change log level to warn for non-archival node
Previously, there was an error being logged for non-archival infura nodes being used (typically in dev). This log level has been reduced to a warning as the application still functions with non-archival nodes.
2021-07-06 11:28:00 -04:00
Pascal Precht 88ca3b9bbf refactor(WalletLayout): use StatusQ two panel layout 2021-06-30 15:08:26 +02:00
Jonathan Rainville b720a611c4 fix(wallet): fix loading of initial balances 2021-06-29 07:55:26 -04:00
Jonathan Rainville eb726a315c fix(hisotry): fix load more history button
Fixes #2754
2021-06-29 07:55:26 -04:00
Iuri Matias 6bcdb9ca54 refactor wallet views
add getSettings methods to src/status

fix issue with calling getSettings; document issue

remove most direct references to libstatus; document some common issues

remove most references to libstatus wallet

add mailserver layer to status lib; remove references to libstatus mailservers

remove libstatus accounts references

move types out of libstatus; remove libstatus types references

remove libstatus browser references

refactor libstatus utils references

remove more references to libstatus stickers

remove references to libstatus constants from src/app

remove more libstatus references from src/app

refactor token_list usage of libstatus

refactor stickers usage of libstatus

refactor chat usage of libstatus

remove libstatus references from the wallet view

remove logic from ens manager view

fix issue with import & namespace conflict

remove unnecessary imports

refactor provider view to not depend on libstatus

refactor provider view

refactor: move accounts specific code to its own section

fix account selection

move collectibles to their own module

update references to wallet transactions

refactor: move gas methods to their own file

refactor: extract tokens into their own file

refactor: extract ens to its own file

refactor: extract dappbrowser code to its own file

refactor: extract history related code to its own file

refactor: extract balance to its own file

refactor: extract utils to its own file

clean up wallet imports

fix: identicon for transaction commands
Fixes #2533
2021-06-17 16:11:01 -04:00
Eric Mastro 0b0a542828 fix: loading of wallet history, display of tx datetime
Fixes: #2539.

Transaction history is now correctly being fetched from status-go as per mobile. Firstly, when accounts are added (ie as watch accounts), `wallet_checkRecentHistory` must be called first so that the status-go db is populated. After that, `wallet_getTransfersByAddress` can be called. On app load, when we run the `initBalance` logic, we are calling `wallet_getTransfersByAddress`, asking for the last 20 transactions with the `loadMore` parameter set to false. When the user navigates to the Wallet > History tab, they can then click “Load More” to fetch more transactions from status-go. Once the number of transactions returns false below the expected amount, the remaining transactions to fetch have been exhausted and the “Load More” button is disabled.

feat: add non-archival node warning to the UI to indicate to the user that they may not have complete results

feat: set active account to the added account
Once an account is added to the wallet, that newly added account is selected as the active account.

1. The “load more” button is active when new transactions that aren’t already displayed are returned from `wallet_getTransfersByAddress`. This is the only way to enable or disable the “Load more” button as status-go is not able to return information regarding whether or not there are more transactions to be fetched. The downside to this is that lets say the last page of transactions is returned, but there are no more pages left. These returned txs are not currently displayed, so the “load more” button will still be enabled. However, the next click of the button will return 0 results, thus disabling it. It’s effectively an extra click to get to the disabled state.
2. For more information on how the `toBlock` parameter operates for the `wallet_getTransfersForAddress` RPC call, see https://notes.status.im/XmENTrVRRaqhwE4gK0m8Mg?view.
2021-06-10 10:47:03 +10:00
Jonathan Rainville bee54e628f feat(Activity center): add placeholder activity center
Fixes #2608
2021-05-31 15:54:18 -04:00
Richard Ramos 19d4279237 use new wallet api to receive wallet signals 2021-05-18 15:24:05 -04:00
Eric Mastro ee1287b71d fix: prevent crash on generate account wrong password
Fixes #2448.

Currently, if a wrong password is entered when generating a wallet account, the app will crash due to attempting to decode a `GeneratedAccount ` from an rpc response containing only an error.

With this PR, we are detecting if an error is returned in the response, and if so, raising a StatusGoException. This exception is caught in the call chain, and translated in to a `StatusGoError` which is serialised and sent to the QML view, where it is parsed and displayed as an invalid password error in the input box.

refactor: remove string return values as error messages in wallet model
In the wallet model, we were passing back empty strings for no error, or an error as a string. This is not only confusing, but does not benefit from leaning on the compiler and strong types. One has to read the entire code to understand if a string result is returned when there is no error instead of implicitly being able to understand there is no return type.

To alleviate this, account creation fundtions that do not need to return a value have been changed to a void return type, and raise `StatusGoException` if there is an error encountered. This can be caught in the call chain and used as necessary (ie to pass to QML).

refactor: move invalid password string detection to Utils
Currently, we are reading returned view model values and checking to see if they include a known string from Status Go that means there was an invalid password used. This string was placed in the codebased in mulitple locations.

This PR moves the string check to a Utils function and updates all the references to use the function in Utils.
2021-05-14 10:27:37 -04:00
Eric Mastro daabef3a3c fix: do not show watch-only accounts as “from address”
Fixes: #2257.

If a user had selected a watch-only address in the wallet, the backend `walletModel.currentAccount` property would also change. When loading a transaction modal, this property was used to set the `selectedAccount` value for the “from” `AccountSelector`, regardless if the account was a watch-only address.

This PR updates the logic for `selectedAccount` such that it will only allow the account to be selected if it is not a watch-only account.
2021-04-29 12:36:39 -04:00