status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(@desktop/warnings): Fix bunc of qml/nim warnings 

Closes: #5162
This commit is contained in:
Boris Melnik 2022-05-16 18:02:03 +03:00 committed by Iuri Matias
parent 595bca0294
commit aa1dae9e20
14 changed files with 30 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/app/core/notifications/notifications_manager.nim
View File

@ -74,7 +74,7 @@ QtObject:
self, "onNewCommunityMembershipRequestNotification(QString, QString, QString)", 2)
signalConnect(singletonInstance.globalEvents, "myRequestToJoinCommunityAcccepted(QString, QString, QString)",
self, "onMyRequestToJoinCommunityAcccepted(QString, QString, QString)", 2)
signalConnect(singletonInstance.globalEvents, "myRequestToJoinCommunityHasBeenRejected(QString, QString, QString)",
signalConnect(singletonInstance.globalEvents, "myRequestToJoinCommunityRejected(QString, QString, QString)",
self, "onMyRequestToJoinCommunityRejected(QString, QString, QString)", 2)
self.notificationSetUp = true

5
src/app/modules/main/node_section/view.nim
View File

@ -49,12 +49,15 @@ QtObject:
proc receivedMessage*(self: View, lastMessage: string) {.signal.}
proc getLastMessage*(self: View): string {.slot.} =
return self.lastMessage
proc setLastMessage*(self: View, lastMessage: string) =
self.lastMessage = lastMessage
self.receivedMessage(lastMessage)
QtProperty[string] lastMessage:
read = lastMessage
read = getLastMessage
notify = receivedMessage
proc getWakuBloomFilterMode*(self: View): bool {.slot.} =

2
ui/app/AppLayouts/Chat/stores/RootStore.qml
View File

@ -130,7 +130,7 @@ QtObject {
property string currentCurrency: walletSection.currentCurrency
property string signingPhrase: walletSection.signingPhrase
property string channelEmoji: chatCommunitySectionModule && chatCommunitySectionModule.emoji
property string channelEmoji: chatCommunitySectionModule && chatCommunitySectionModule.emoji ? chatCommunitySectionModule.emoji : ""
property string gasPrice: profileSectionModule.ensUsernamesModule.gasPrice

1
ui/app/AppLayouts/Chat/views/ChatView.qml
View File

@ -46,6 +46,7 @@ StatusAppThreePanelLayout {
Connections {
target: root.rootStore.chatCommunitySectionModule
ignoreUnknownSignals: true
onActiveItemChanged: {
root.rootStore.openCreateChat = false;
}

2
ui/app/AppLayouts/Profile/controls/NetworkRadioSelector.qml
View File

@ -20,7 +20,7 @@ RadioButtonSelector {
onCheckedChanged: {
if (checked) {
if (root.advancedStore.currentNetworkName === root.network)
if (root.advancedStore.currentNetworkName === root.title)
return
root.newNetwork = root.network;

6
ui/app/AppLayouts/Profile/views/AppearanceView.qml
View File

@ -125,8 +125,10 @@ SettingsContentBase {
model: [ qsTr("XS"), qsTr("S"), qsTr("M"), qsTr("L"), qsTr("XL"), qsTr("XXL") ]
value: localAccountSensitiveSettings.fontSize
onValueChanged: {
localAccountSensitiveSettings.fontSize = value
appearanceView.updateFontSize(value)
if (localAccountSensitiveSettings.fontSize !== value) {
localAccountSensitiveSettings.fontSize = value
appearanceView.updateFontSize(value)
}
}
}

4
ui/app/AppLayouts/Profile/views/BrowserView.qml
View File

@ -80,7 +80,9 @@ SettingsContentBase {
StatusSwitch {
checked: localAccountSensitiveSettings.shouldShowFavoritesBar
onCheckedChanged: {
localAccountSensitiveSettings.shouldShowFavoritesBar = checked
if (localAccountSensitiveSettings.shouldShowFavoritesBar !== checked) {
localAccountSensitiveSettings.shouldShowFavoritesBar = checked
}
}
}
]

2
ui/app/AppLayouts/Profile/views/ContactsView.qml
View File

@ -72,7 +72,7 @@ SettingsContentBase {
enabled: root.contactsStore.receivedContactRequestsModel.count > 0 ||
root.contactsStore.sentContactRequestsModel.count > 0
btnText: qsTr("Pending Requests")
badge.value: contactList.count
badge.value: root.contactsStore.receivedContactRequestsModel.count
}
// Temporary commented until we provide appropriate flags on the `status-go` side to cover all sections.
// StatusTabButton {

2
ui/app/AppLayouts/Profile/views/browser/DefaultDAppExplorerView.qml
View File

@ -49,7 +49,7 @@ ColumnLayout {
checked: localAccountSensitiveSettings.useBrowserEthereumExplorer === Constants.browserEthereumExplorerEtherscan
text: "etherscan.io"
onCheckedChanged: {
if (checked) {
if (checked && localAccountSensitiveSettings.useBrowserEthereumExplorer !== Constants.browserEthereumExplorerEtherscan) {
localAccountSensitiveSettings.useBrowserEthereumExplorer = Constants.browserEthereumExplorerEtherscan
}
}

10
ui/app/AppLayouts/Wallet/panels/SelectGeneratedAccount.qml
View File

@ -54,10 +54,12 @@ StatusSelect {
if(generatedAccountsModel) {
generatedAccountsModel.clear()
for (var row = 0; row < _internal.delegateModel.model.count; row++) {
var item = _internal.delegateModel.items.get(row).model;
generatedAccountsModel.append({"name": item.name, "iconName": item.iconName, "generatedModel": item.generatedModel, "derivedfrom": item.derivedfrom, "isHeader": false})
if(row === 0 && _internal.delegateModel.model.count > 1) {
generatedAccountsModel.append({"name": qsTr("Imported"), "iconName": "", "derivedfrom": "", "isHeader": true})
if (_internal.delegateModel.items.count > 0) {
var item = _internal.delegateModel.items.get(row).model;
generatedAccountsModel.append({"name": item.name, "iconName": item.iconName, "generatedModel": item.generatedModel, "derivedfrom": item.derivedfrom, "isHeader": false})
if (row === 0 && _internal.delegateModel.model.count > 1) {
generatedAccountsModel.append({"name": qsTr("Imported"), "iconName": "", "derivedfrom": "", "isHeader": true})
}
}
}
generatedAccountsModel.append({"name": qsTr("Add new"), "iconName": "", "derivedfrom": "", "isHeader": true})

2
ui/app/AppLayouts/Wallet/stores/RootStore.qml
View File

@ -143,7 +143,7 @@ QtObject {
}
function checkRecentHistory() {
history.checkRecentHistory()
walletSection.checkRecentHistory()
}
function fetchCollectionCollectiblesList(slug) {

2
ui/app/mainui/AppMain.qml
View File

@ -28,6 +28,8 @@ import StatusQ.Layout 0.1
import StatusQ.Popups 0.1
import StatusQ.Core 0.1
import AppLayouts.Browser.stores 1.0 as BrowserStores
import AppLayouts.stores 1.0
Item {

5
ui/imports/shared/status/StatusChatInput.qml
View File

@ -404,7 +404,7 @@ Rectangle {
property string copiedTextFormatted: ""
ListView {
id: dummyContactList
model: control.usersStore.usersModel
model: control.usersStore ? control.usersStore.usersModel : []
delegate: Item {
property string contactName: model.name
}
@ -631,6 +631,7 @@ Rectangle {
Connections {
enabled: control.isActiveChannel
target: Global.appMain.dragAndDrop
ignoreUnknownSignals: true
onDroppedOnValidScreen: (drop) => {
let validImages = validateImages(drop.urls)
if (validImages.length > 0) {
@ -690,7 +691,7 @@ Rectangle {
SuggestionBoxPanel {
id: suggestionsBox
model: control.usersStore.usersModel
model: control.usersStore ? control.usersStore.usersModel : []
x : messageInput.x
y: -height - Style.current.smallPadding
width: messageInput.width

2
ui/imports/shared/views/chat/CompactMessageView.qml
View File

@ -87,7 +87,7 @@ Item {
+ (dateGroupLbl.visible ? dateGroupLbl.height + dateGroupLbl.anchors.topMargin : 0)
Connections {
target: root.messageStore.messageModule? root.messageStore.messageModule : null
target: !!root.messageStore && root.messageStore.messageModule? root.messageStore.messageModule : null
enabled: responseTo !== ""
onRefreshAMessageUserRespondedTo: {
if(msgId === messageId)