Commit Graph

6632 Commits

Author SHA1 Message Date
Lukáš Tinkl ea40a6b11f feat(SharedAddresses): display the eligibility bubble in edit mode too
- previously, we'd display the bubble only when joining the community
- now we display it also when editing the shared addresses, with a
slightly different wording (eg. "You're an admin" -> "You'll be a
member"), hinting the user about the future change
- remove the usage of `ModuleWarning` as we don't want its delay or
transitions here, replace it with a regular red `Rectangle` + text

Fixes #13397
2024-04-15 20:24:34 +02:00
Stefan 8be1453fd0 fix(token-order): global has settings check that introduced side effects
The "settings exist" done via ManageTokensController::hasSettings() was
using the global store, hence not working user based. Therefore, after
an onboarding the previous user's settings presence was taken into account.
The fix now uses the order data that is loaded externally per user.

Closes #14383
2024-04-15 09:16:34 +02:00
Stefan 228622359d fix: warning while switching between accounts
The is image flag and source was not in sync due to sequential change
of source and isImage. This was causing the following warning:
`Warning: qrc:/StatusQ/Components/StatusRoundedImage.qml:27:5: QML StatusImage: Cannot open: qrc:/StatusQ/Components/help
2024-04-15 09:16:34 +02:00
Cuteivist 7cb59576a1
fix(wallet): Update amount to send decimal handling (#14399) 2024-04-15 07:28:29 +02:00
Stefan d3f037f93b fix(wallet): hidden groups are still loading from user local settings
Removed loading hidden groups from local settings and instead reload
them from the externally loaded settings.
Also move the local saving code from the controller to external,
therefore now it is implemented in storybook

Updates #14365
2024-04-14 10:59:08 +02:00
Mykhailo Prakhov 55dd8e3065
feat(@desktop/activityCenter): show notification about invite to group chat from non our mutual contact (#14415) 2024-04-12 18:28:28 +02:00
Ivan Belyakov 3843b53cc0 feat(wallet): toggling `include/exclude from total balance` menu action
filters out assets/collectibles/activities entries.
Fixed direction of transfers for `All accounts` selection on activity
tab.

Closes #14162 #14216
2024-04-12 15:18:19 +02:00
Ivan Belyakov 6ba0cdfafa feat(wallet): removed allAddresses flag as redundant 2024-04-12 15:18:19 +02:00
Stefan b9271005cd fix(wallet): update wallet assets and collectibles order on user action
Add a specific state to the saveSettings action to update the model
by reloading the data.

The previous implementation was using the same save address which
doesn't update. Either in the past there was a side effect that made it
work or it was never working.

Closes #14365
2024-04-12 11:30:15 +02:00
Michał Cieślak 180932b799 chore(SharedAddressesAccountSelector): Remove workaround related to issue #14244
Additionally flow is simplified slightly by setting `type` role in
ConcatModel
2024-04-12 11:05:08 +02:00
Michał Cieślak 5d4380e4d9 feat(StatusQ/ConcatModel): Proper handling of source models layout change
Whenever source model emits layoutAboutToBeChanged/layoutChanged,
persisten model are updated appropriately, also scenario when items are
removed is covered.

Closes: #14244
Closes: #14245
2024-04-12 11:05:08 +02:00
Michał Cieślak 598a389c3e feat(StatusQ/TestHelpers): Add method to test model removing items and emiting layoutChanged 2024-04-12 11:05:08 +02:00
Sale Djenic 42a60642e8 fix(wallet): user is unable to authenticate using biometrics
Fixes #14404
2024-04-12 07:46:00 +02:00
Lukáš Tinkl 6171a2d900 fix(NetworkFilter): position the popup along the right edge
spotted by Ben
2024-04-11 21:48:16 +02:00
Lukáš Tinkl 9024a4c324 fix(RightTabView): fix filter button vertical alignment
spotted by Ben
2024-04-11 21:48:16 +02:00
Lukáš Tinkl 5d064368cf chore(ui): visually align different combo box instances
- extract common background and indicator subcomponents into
StatusQ.Components.private, and reuse it

Fixes #14121
2024-04-11 21:48:16 +02:00
Lukáš Tinkl e363dd1109 fix(SortOrderComboBox): do not display icons or bold(er) font in delegates
- cleanup indentation (older QtC versions don't like the nullish
coalescing operator `??`)
- fixup SB pages
2024-04-11 21:48:16 +02:00
Lukáš Tinkl 14138d5ff5 fix(NetworkFilter): display correct cursor
- since we override the `control.background` from `StatusComboBox`, need
to specify the `cursorShape` again
2024-04-11 21:48:16 +02:00
Lukáš Tinkl fb2d1ad0f0 fix(NetworkFilter): fixup allSelected/noneSelected
- there's no `len` property in `SFPM`; fixes correctly displaying "All
networks" when all are selected
2024-04-11 21:48:16 +02:00
Lukáš Tinkl 3e051fd79c chore(ModelUtils): small optimization for `get`
- do not call `roleByName` twice
2024-04-11 21:48:16 +02:00
Anthony Laibe da7f419f57 fix: repeat tx open the send modal
fixes #14357
2024-04-10 10:31:58 +02:00
Igor Sirotin 795b999ad8
chore: extract move gifs module (#14315) 2024-04-09 19:01:24 +01:00
Cuteivist 277dda7533
feat(wallet): Disable send for soulbound collectibles (#14327) 2024-04-09 16:16:03 +02:00
Lukáš Tinkl b84c1f20df fix[Shared Addresses] Can't edit shared address while the join request is pending
- disallow changing the Shared addresses while our request to join
community is still pending

Fixes #14292
2024-04-09 13:11:39 +02:00
Lukáš Tinkl 50c2d33f64 chore(CommunityColumnView): fix typo 2024-04-09 13:11:39 +02:00
Sale Djenic d4fa715c7e fix(wallet): changes in account order in settings are not applied in wallet
Fixed an issue with dropping a draggable item outside the bounds of the DropArea.

Fixes #13836
2024-04-09 11:27:15 +02:00
Stefan 473e2e273f feat(wallet) connect assets ordering with saving to DB backend
Also refactor the existing code based on the latest understanding.

Closes #13312
2024-04-09 09:34:52 +02:00
Anastasiya Semenkevich 25906ffa34 chore(@ui/app/AppLayouts/Communities/popups/InDropdown): add object name 2024-04-09 09:50:44 +03:00
Michal Iskierko 62c48a0072 chore(desktop): upgrade status-go
Issue #14044
2024-04-08 11:22:51 +03:00
Anastasiya Semenkevich a8a943bec9 chore: add object name for TokenBalancePerChainDelegate 2024-04-05 16:39:49 +03:00
Michał Cieślak a83f1114e2 chore(Communities/InDropdown): performance improved
- removed multiple filtering separately for each category
- no instantiation of all delegates up front (regular ListView approach
  used)
- fixed category selection when filtering - selecting/deselecting only
  items fulfilling search criteria
- significant simplification of the code

Closes: #14275
2024-04-05 14:58:06 +02:00
Michał Cieślak 0b47e6ff8a feat(StatusQ/LeftJoinModel): Add init check on componentComplete
Earier attempts to initialize proxy may fail bc left/right models
may be not ready when they are set. It may lead to a situation where
the model remains uninitialized and reporint 0 row count.
2024-04-05 14:58:06 +02:00
Michał Cieślak 0c34325841 feat(StatusQ/LeftJoinModel): Add possibility to explicitly define roles to be joined
The new property is added to allow indicating which roles from the right
model should be used. It prevents from unnecessary renamings.

Closes: #14298
2024-04-05 14:58:06 +02:00
Alexandra Betouni 53db09412a feat(ProfileShowcasePopup): Adding interactions in delegates
Closes #13702
2024-04-05 12:31:11 +03:00
Jonathan Rainville 5c75c265af fix(permissions): fix hang when all channel perm check return (#14259)
* fix(permissions): fix hang when all channel perm check return

Fixes #14234

The problem was that we updated **all** the models from **all** the channels of a community each time the channel requirement checks returned.

The fix is to first of all, make sure we don't call that check too often. It sometimes got called twice in a row by accident.

The other better fix is to check if anything actually changed before updating. This solves the issue almost entirely.  Since the permissions almost never change, the updates now take only a second.

* fix(permisisons): never run permission checks for privileged users

Also fixes #14234 but for admins, TMs and Owners.

Admins+ were still getting the hang, because the permission checks always returned something different than the models, because the models knew that admins have access to everything, but the permission check was running as if it were a normal user (I think, un-tested).

Anyway, the solution is more simple, we never need  to run the permission checks on admins+, because they always have access to everything!

* fix(Communities): prevent channels model from emitting unnecessary signals

Closes: #14274

* chore(Communities): improve channels metadata lookup performance

ChannelsSelectionModel is removed, replaced with plain LeftJoinModel.
Transformations of left-side model are done in a single place, not in
every delegate making the join.

* only call update functions when there is something to update + move permission model creation when needed

---------

Co-authored-by: Michał Cieślak <michalcieslak@status.im>
2024-04-04 12:14:39 -04:00
Mykhailo Prakhov 1e155046e7
fix(@desktop/communities): request to join fixes (#14287) 2024-04-04 18:03:10 +02:00
Stefan 6762630e51 fix(SendModal): fix not showing tokens in the holding selector
The previous attempt to control the order of delegate intantiation
and avoid qml warnings didn't work for this case (Loader with injected
properties). Therefore, I reverted to the last working version.
2024-04-04 17:25:30 +02:00
Lukáš Tinkl 375de59cfa chore(SharedAddressesPermissionsPanel): optimize the speed
- don't use the expensive `ExpressionFoo` in SFPM, just use
`AnyOf/AllOf` combinations where possible
- in HoldingsSelectionModel, don't call the `getTokenByKey` twice to
construct the `text`, once is enough
- lastly, rewrite the JS helper `PermissionsHelpers.getTokenByKey` to
C++; this method gets called recursively way too often from many places

In the longterm, we should provide a specific C++ transformation model
for SharedAddressesPermissionsPanel to follow the UI requirements more
closely; that way we'd be able to fix the issues here for good

Fixes #14276
2024-04-04 16:59:26 +02:00
Lukáš Tinkl 795718b39f chore: fix double permissionsModel preparation
we already build it anyway in the Popups.qml when opening the community
intro dialog in all the flows
2024-04-04 16:59:26 +02:00
Igor Sirotin 8d6454367a
fix: permissions with value>1000 (#14249) 2024-04-04 09:45:25 +01:00
Khushboo Mehta 2d20a2e1b7 feat(@desktop/wallet): Collectible Details balance tag
fixes #13809
2024-04-03 20:37:45 +02:00
Stefan ee23cce575 fix(SendModal): fix various issues with SendModal
- Fix errors when switching between assets and collectibles tabs
  - Fix by controlling the order of instantiation between model and
    delegates not to mix models and delegates from different sources
- Fix size errors
- Various improvements

Updates: #14212
2024-04-03 16:23:32 +02:00
Stefan f9782d6863 fix(SendModal) missing icons for assets
In case of assets the symbol doesn't have an icon representation
in resources, hence we use the image of the asset itself.
Same fix used for header and delegate

Closes: #14218
2024-04-03 10:07:47 +02:00
Dario Gabriel Lipicar cd3a1180b0 fix(@desktop/wallet): properly handle collectible groups in send modal
Fixes #14080
2024-04-02 12:55:08 -03:00
Lukáš Tinkl cb6c633e69 feat(SharedAddressesAccountSelector): update account sorting
- implement sorting of the wallet accounts by the number of tokens (aka tags) and
then by alphabet
- due to the delegate complexity here and usage of nested models, keep
track of the tags count separately and outside of the model
- this will be improved later on as part of the complete sort/order
design described in https://github.com/status-im/status-desktop/issues/14192

Fixes #14101
2024-04-02 16:03:09 +02:00
Lukáš Tinkl 8704cb19a4 chore(SharedAddressesPermissionsPanel): use FastExpressionFilter
- speed up the construction of the permissions overview panels
2024-04-02 16:03:09 +02:00
Alex Jbanca 79d4bb20cb fix(ProfileShowcase): Filter out communities the user hasn't joined from 2024-04-02 16:44:16 +03:00
Andrey Bocharnikov accd4da214
fix(Permissions): tokenOwner is present in the list of collectibles when adding a permission (#14236)
fixes #13561
2024-04-02 14:38:08 +04:00
Michał Cieślak b91cf08066 feat(SharedAddressesAccountSelector): Support for collectibles in account's delegate tags
Closes: #14102
2024-04-02 12:18:36 +02:00
Alex Jbanca 684fb787a6 fix(PRofileShowcase): Fixing conflict merge error 2024-04-02 12:07:22 +03:00
Cuteivist 7fa3771e4e
feat(wallet): Handle collectibles details unknown community (#14206) 2024-04-02 10:23:20 +02:00
Alexandra Betouni 4af2a97358 [ProfileShowcase] Updated delegates as per design + added web tab
Closes #13421
Closes #13606
2024-04-02 10:21:13 +03:00
Alex Jbanca 1d45243bc1 feat(ProfileShowcase): Integrate profile perspective selector 2024-04-02 10:16:17 +03:00
Alex Jbanca 77933cc732 feat(ProfileShowcase): Add profile perspective selector component 2024-04-02 10:16:17 +03:00
Cuteivist 6dec612f5c
feat(wallet): Handled failed to load collectible image state (#14229) 2024-03-30 06:00:00 +01:00
Lukáš Tinkl b191caaec6 feat: Add missing eligible to join tag in CommunityMembershipSetupDialog
- implement the eligibility check in C++, returning the highest possible
role the user would be allowed to join under
- enable/disable the "Share" button based on the above permissions check
- remove all the locally placed components, access teh popup only via
Global/Popups
- calculate the `accessType` internally based on the permissions present
- update the eligibility as the async check for permissions is finished
- fix the permissions panel background color
- partially revert the share/finish/cancel buttons behavior; it must be
one button due to StatusStackModal limitations
- fix some other minor UI issues or differences to current Figma designs
- adjust SB, add the possibility to play around with different
permission models

Fixes #14100
2024-03-29 16:11:59 +01:00
Lukáš Tinkl 5af2f28aa2 fix[Onboarding] Password screen is not correct
- hide the "Current password" label when creating a new password
- fix margins inside the keycard popup
- some minor UI fixups according to Figma

Fixes: #14214
Fixes: #14177
2024-03-29 16:10:50 +01:00
Mikhail Rogachev 839f2c6b21
Feat: New showcase models for a contact (#13998)
* Feat: New showcase models for a contact

* feat(ProfileShowcase): Integrate the new profile showcase backend

* fix(Storybook): Fix ProfileShowcaseModelsPage

* fix: fetch only requested profile showcase data

Support PR for https://github.com/status-im/status-go/pull/4982

* feat: Load and validate profile showcase for a contact in two steps

* fix: fetching criteria for profile showcase collectibles

* fix: review fixes

---------

Co-authored-by: Alex Jbanca <alexjb@status.im>
2024-03-29 12:43:49 +01:00
Khushboo Mehta c710f0e809 fix(@desktop/wallet): Remove profile section's networks submodule and udpate logic for combined networks 2024-03-28 17:08:49 +01:00
Noelia d568ceb444 fix(JoinCommunity): Merge issues solved and channel hidden logic fixed
- Removed function in merge while it's still needed.
- Modified logic when channels hidden to take into account also `viewOnly` permission cases.
2024-03-28 10:59:40 -04:00
Noelia 4144e374a6 fix(JoinCommunity): Add missing state ONLY private permissions and NOT MET (#14164)
* fix(JoinCommunity): Add missing state ONLY private permissions and NOT MET

- Modified `becomeMemberModel` in store to provide all member permissions.
- Modified permissions model filter to only discard  permissions that are private and NOT met.
- Updated `storybook/PermissionsModel` with new only private permissions and added new model option in corresponding pages.

Closes #14104

* fix(JoinCommunity): Text position when all channels hidden

Updated text position when `allChannelsAreHiddenBecauseNotPermitted` in community join process
2024-03-28 10:59:40 -04:00
Mykhailo Prakhov 7804d4ca39 fix: set correct permision UI 2024-03-28 10:59:40 -04:00
Khushboo Mehta 5473e3b14e chore(@desktop/wallet): Simplify the wallet networks service
fixes #12717
2024-03-28 11:47:33 +01:00
Sale Djenic d9945b39dc fix(wallet): displaying L1 gas cost in UI
Fixes #13892
2024-03-28 10:36:09 +01:00
Sale Djenic f8bb8e2588 fix(communities): join community button text instead of share all addresses to join text in membership setup dialog
Closes #14172
2024-03-28 08:19:24 +01:00
Sale Djenic 9b8401b641 fix(communities): keycard authentication marked automatically as authenticated
Closes #14174
2024-03-28 07:38:42 +01:00
Sale Djenic 3e76fa6179 fix(communities): when only keycard accounts selected (and 1 keycard), authentication is not triggered
Closes #14175
2024-03-28 07:38:28 +01:00
Sale Djenic cbf0fd3d71 fix(general): when biometric is setup the authentication flow is not correct showing the password one instead
Closes #14173
2024-03-28 07:38:15 +01:00
Noelia 67f0f38cf9 fix(CancelCommunityMembership): Added popup instead of directly cancelling request
- Added dialog instead of calling directly to the cancel method.
- Updated `Cancel` button format according to figma in `CommunityMembershipSetupDialog`.

Closes #14097
2024-03-28 07:33:34 +01:00
Stefan 26542970ee feat(wallet) save/load collectibles user handled state in DB
Add a separation layer for save/load/clear to ManageTokensModel
so that we can save/load from external sources.
The separate layer is composed of JSON as protocol, a set of signals
and slots for interface. The implementation forwards data to current
QSettings for storybook and nim controllers for the app.

Updates #13313, #13312
2024-03-27 20:26:15 +01:00
Khushboo Mehta f45a39bfcf feat(@desktop/wallet): Link out from collectible details view to opensea
fixes #13918
2024-03-27 17:47:06 +01:00
Noelia 3f74ee565a fix(JoinCommunity): Join CTA labelling: Change text and remove existing icon
- Change text and remove existing icon.
- Removed unnecessary property `loginType` on different files.
- Renamed signals to be more accurate with existing requirements.

Closes #14098
2024-03-27 12:16:56 +01:00
Lukáš Tinkl 085b013f80 fix(Shared Addresses): Requirements check pending indicator
- update shared addresses dialog to avoid small jumps when
selecting/unselecting accounts due to requirements check text displayed
- display the pending text and spinner next to the Permissions header

Fixes #14103
2024-03-27 11:16:40 +01:00
Cuteivist fae7e82e0a
fix(@wallet): Copy viewed account details (#14161) 2024-03-26 16:49:12 +01:00
Michał Cieślak 59453e1189 fix(CommunityJoiningAndAddressSharingDialog): Intro text width fixed 2024-03-26 14:03:29 +01:00
Michał Cieślak 0557977aa2 chore(Communities): CommunityIntroDialog renamed to CommunityMembershipSetupDialog
Closes: #14144
2024-03-26 14:03:29 +01:00
Michał Cieślak 0985346342 chore(CommunityIntroDialog): Fix storybook page 2024-03-26 14:03:29 +01:00
Lukáš Tinkl 56b9b9db11 fix: Display name is not validated properly (UI part)
- do not use the `alphanumericalExpanded:
/^$|^[a-zA-Z0-9\-_\.\u0020]+$/` regex which contains the dot (`.`)
character too; be explicit here and do what the error message says
- the space character at start/end is validated above with the
`startsWithSpaceValidator`

CHERRY-PICK-TO: 2.28

Fixes #14127
2024-03-25 19:06:54 +01:00
Stefan 42d3c1b42b fix(wallet) refresh recipients in menu for activity filter
Closes #13663
2024-03-25 18:38:33 +01:00
Stefan b4aff67639 fix(wallet) wrong properties referenced in TransactionDetailView
Updates: #13663
2024-03-25 18:38:33 +01:00
Stefan cd2b211f63 chore(wallet) lazy load TransactionDetailView
I was debugging a crash at login and found out that
TransactionDetailView was being loaded even when it was not being used;
my debugging code in `onComplete` was trying to access transaction data
from nim which was not set.

Updates #13663
2024-03-25 18:38:33 +01:00
Stefan 72b03e69aa fix(wallet) fix namespace clash in wallet RootStore.qml
Updates: #13663
2024-03-25 18:38:33 +01:00
Cuteivist 1deb5e86e5
fix(wallet): Add token data when new token is added (#14061) 2024-03-25 18:31:01 +01:00
Sale Djenic 979423ea62 chore(general): removing unneeded qml file 2024-03-25 14:16:32 +01:00
Sale Djenic 10a8469b9e fix(communities): deltas between designs and build for join token gated community flow
This commit:
- improves selection of addresses to reveal
- keeps the selection state for the popup lifetime
- brings higher granularity in terms of signed requests by keypairs
- meets new requirements from the latest related Figma
- merges edit shared addresses feature and request to join community features
into a single component, cause the flow is logically the same, with the only
difference that when editing revealed addresses we don't show the community
intro screen

Fixes at least points 3 and 4 from #13988
2024-03-25 14:16:32 +01:00
Lukáš Tinkl ec4e2f3fc8 fix: can't use the Tab button in the Mint Token form
- manually setup the TAB focus chain; in the future, this should be done
properly on all new components using FocusScopes and similar

Fixes #13891
2024-03-25 14:11:43 +01:00
Lukáš Tinkl 9ef513b419 fix(TokenManagement): Asset balance threshold value not reflected in main wallet view
- take the balance threshold value into account when presenting the
assets in the main wallet view
- additional fix from Emil for storing the threshold value
- storybook fixes to display the correct `currentCurrencyBalance` values
based on the address/wallet filters and mocking the threshold values
using TransactionStore

Fixes: #14017
2024-03-23 11:37:37 +01:00
Valentina Novgorodtceva 05df5d1bce chore: object names added for wallet right tab buttons and filter button 2024-03-22 14:00:19 +03:00
Khushboo Mehta 4f75956ca3 fix(@desktop/wallet): Fix link out to extherscan from collectibles details view 2024-03-20 19:04:32 +01:00
Jonathan Rainville 19c283be8b
fix: fix warning and inconsistencies with spectating (#14041)
Kinda fixes #13957
2024-03-20 13:58:46 -04:00
Stefan a09defbef7 feat(wallet) skip picking flags in the random emoji picker function
Also add a test to validate the knowledge of the emoji picker function
about flags position

Closes #13715
2024-03-20 11:56:03 +01:00
Stefan 631ae08a8d fix(wallet): pick a random emoji in the wallet new account modal
Updates #13715
2024-03-20 11:56:03 +01:00
Mykhailo Prakhov a586c6d352
feat(desktop/communities): View community member messages functionality (#14002)
* feat(desktop/communities): View member messages functionality
2024-03-20 11:50:10 +01:00
Valentina1133 a48b2532ae
chore: object names for activity center elements added (#14029) 2024-03-20 17:22:57 +07:00
Noelia 1d9c136bf8 feat(ProfileShowcase): Some properties prepared for task #13997 development
Part of #13997
2024-03-20 09:31:34 +01:00
Noelia c93a8d2c6f feat(SettingsDirtyToastMessage): Extended with additional information component in bottom
- Updated layout using `ColumnLayout`.
- Added additional text component on bottom according to new designs.
2024-03-20 09:31:34 +01:00
Noelia d35c0bd3d1 feat(ProfileShowcase): Align UI save flow according to backend response
- Added loading state in dirty toast message.
- Added store connections in `MyProfileView` and save loading logic.
- Added toasts notifications.

Closes #13950

a
2024-03-20 09:31:34 +01:00
Noelia 1d15398ea7 fix(ProfileSectionStore): Only instanciated once
- Removed `ProfileSectionStore` instance from `CurrenciesStore`. Only needed some certain accesses to the `profileSectionModule`.
- Added strict type in `CommunitiesView`.
2024-03-20 09:31:34 +01:00
Dario Gabriel Lipicar 74440c81e5 feat(@desktop/wallet): add support for EUROC 2024-03-19 16:03:31 -03:00
Mykhailo Prakhov f3d2d0a809
feat(@desktop/community): add new CommunityMemberState - CommunityMemberBanWithAllMessagesDelete (#14028) 2024-03-19 16:17:02 +01:00