Commit Graph

5 Commits

Author SHA1 Message Date
Pascal Precht f0939a01fe chore: update i18n 2020-09-18 17:23:35 -04:00
emizzle 7b0d3c496c fix: exception handling in mutli-threaded transactions
Currently, exceptions thrown during transactions or gas estimation that were spawned in another thread are not being propagated, due to a limitation in nim (see https://nim-lang.org/docs/manual_experimental.html#parallel-amp-spawn).

This means any exceptions from status-go were not propagated correctly and would cause the app to crash. This includes entering the wrong password when trying to send a transaction.

The issue was addressed by passing a `success` variable by reference, which is set to false if an exception was thrown by status-go.
2020-09-17 12:21:29 -04:00
Richard Ramos 24e01ffa7c fix: code review 2020-09-16 14:22:29 -04:00
RichΛrd 6a42124489 Apply suggestions from code review
Co-authored-by: Eric Mastro <eric.mastro@gmail.com>
2020-09-16 14:22:29 -04:00
Richard Ramos e46ab433f4 feat: transaction dialog for registering ENS name 2020-09-16 14:22:29 -04:00