It may happen `asyncLoadMoreMessagesForChat` is called many times in a
row. Previously it did not check whether there is any pending fetch for
a given chat, which resulted in many same cursors fetches from status-go.
Furthermore, in this case, `lastUsedMsgCursor` ended up with the same
value as `msgCursor` resulting in wrong state where there are no more
messages to fetch.
- Simplified message loading code by introducing MessageCursor helper
type
- Ensured messages are not loaded twice for the same cursor
fixes: #8602
Fixes#4943
The custom OS notifications we have in place make it possible to click
the notification and go to the right place in the app, but it causes a
big issue in Windows; it breaks the tray icon, it becomes no longer
clickable.
The easy fix I did here is the go back to using the QML sendMessage
function. It works fine to send the notif and the tray icon keeps
working. The only downside is we lose context when clicking on the
notification, so it doesn't navigate to the chat.
IMO, this is a good tradeoff.
- 01: Keycard settings menu labelling - fixed in this commit
- 02: Modal title renaming - not developed yet
- 03: Additional decision diamond and flow - not developed yet
- 04: Modal title renaming - not developed yet
- 05: Modal title renaming - done in issue #7035
- 06: Copy change - fixed in this commit
Fixes: #8458
Fixes#8553
The torrent port was clashing with the release app since both of them have it on by default now. That was causing the messenger to fail on start.
This new PORT_SHIFT env var can be used to shift the port of the torrent service and wakuV2. No more need to use WAKUV2_PORT.
we can also add more ports that need shifting.
This enables opening multiple instances of the app very easily. Just increase PORT_SHIFT by one
Old `state_factory` logic is splitted in two more files. Now it represents only
an interface, but implementation logic is placed in the following two files:
- `state_factory_general_implementation.nim`
- `state_factory_state_implementation.nim`
remove the dialog that asks users if they would like to open a link in
Status Desktop's browser and always open them in the user's external
browser
Fixes#8568
- reduce the file size by about 5%-20% w/o any change in visual quality
- profile_fetching_* images replaced by the resolution we need;
originally it was 1700x1700 and about 4MB each(!)
- when calling `Utils.getColorHashAsJson()` we don't actually need to
issue ID verification requests at all and there might be situations when
we know beforehand that we don't need the ENS verification either
- change these helper functions' syntax and do early returns in that case
- in MessageContextMenuView, the "contact details" were duplicated, so
remove one
- remove dead code, fix some warnings
Patryk Osmaczko
Igor Sirotin
Pascal Precht
Jonathan Rainville
mprakhov
Boris Melnik
Michal Iskierko
Anthony Laibe
Lukáš Tinkl
Khushboo Mehta
Dario Gabriel Lipicar
Richard Ramos
Tanguy
Sale Djenic
Michał Cieślak
MishkaRogachev