Commit Graph

4573 Commits

Author SHA1 Message Date
Alex Jbanca effd676a16 fix(WalletConnect): Fixing fees parsing when provided by the dApp
(cherry picked from commit f73356e2e8)
2024-08-08 10:52:37 +03:00
Lukáš Tinkl 96824dbb91 feat(Wallet): Display the "Buy" button everywhere
- display the "Buy" button in every context in the wallet footer except
when viewing a collectible's details

Fixes #15813
2024-08-08 09:30:49 +02:00
Alex Jbanca 833848188c fix(WalletConnect): Fixing disconnect notifications
The disconnect notifications were operating on `WalletConnectService.currentSessionProposal`. This object stores the current session object on connect, but it's not necessarily the same session the user wants to disconnect.
To fix this I'm getting the active sessions from status-go when the disconnect request is received (from Status or dapp). If the topic matches to any connection topic owned by the users accounts we'll show a notification.

(cherry picked from commit fea4e8ed76)
2024-08-08 09:47:20 +03:00
Dario Gabriel Lipicar c0e5111fe5 feat(@desktop/wallet): handle Paraswap price impact error
Fixes #15542
2024-08-07 23:14:22 -03:00
Alex Jbanca 6a7b0c0289 fix: Remove possibility to add watch accounts on release
(cherry picked from commit 566a954935)
2024-08-07 19:17:16 +03:00
Lukáš Tinkl ed650d32dd chore: Remove the Browser from the app completely for now
- completely removes the `ui/app/AppLayouts/Browser` QML app section
- removes the `app_service/service/bookmarks`,
`app/modules/main/browser_section` and
`src/app_service/service/dapp_permissions` NIM modules
- remove the Browser settings page and associated popups/components
- HTML links now always open in an external browser
- adjust the section indexes in `Constants`
- fixup the e2e tests

Fixes #14614
2024-08-07 16:45:31 +02:00
Godfrain Jacques bef66612c5
feature(connector)_: Add model join to handle connected dApps (#15954)
* feature(connector)_: Add model join to handle connected dApps

* Fix review comments

* chore: bump status-go
2024-08-06 13:20:08 -07:00
Roman Chornii 6aa6746de2
fix(dApps): Improved handling of connected dApps. (#15985)
1. Hiding DApps button on not supported wallet account selection
2. Filtering DApps in connected dApps list based on account selection

closes: #15589
closes: #15647
2024-08-05 16:41:20 +03:00
Lukáš Tinkl 6159f53839 fix: Add additional information to the Beta tags
- display additional beta information as a tooltip
- don't overlap the Beta badge with the unread msg indicator
- some minor cleanups & fixes

Fixes #15795
Fixes #15929
2024-08-05 15:39:51 +02:00
Khushboo Mehta 27aaa97ebd fix(@desktop/wallet): fix for Swap Input parameters reset when balances are reloaded
fixes #15785
2024-08-05 14:39:27 +02:00
Lukáš Tinkl 40f7aff086 fix: inconsistent/incorrect decimal value formatting
- format Big decimal numbers correctly according to the current locale;
some precisions loss is tolerated here for the display purposes
- fixes wrong decimal separators in some places and aligns with the
standard in terms of number of decimals, as everywhere else in the app

Fixes #15612
Fixes #15790
2024-08-01 15:35:52 +02:00
Lukáš Tinkl 24dd67e6dd fix(Wallet): Hiding assets from wallet's main view doesn't work
- partially reuse the already available Global/Popups methods to hide
assets (which also emit proper notifications); those are needed as
anotehr shared modal from Popups uses it too (may come from outside of
Wallet)
- some warnings cleanup in the controller

Fixes #15777
2024-08-01 12:12:48 +02:00
Sale Djenic 0c4b7e92a0 fix: tx fails if the bonder fee is higher than the amount being sent
Closes #15922
2024-07-31 16:59:33 +02:00
Cuteivist 74bc695f10
chore(wallet): Hide Swap if cannot send (#15918) 2024-07-31 16:02:03 +02:00
Jonathan Rainville 4159148ab7
fix(profile): fix canceling modifications in the profile (#15905) (#15906)
Fixes #15904
2024-07-31 10:00:56 -04:00
Khushboo Mehta 2447fa3554 fix(@desktop/wallet): Swap modal - Pay input amount - deleting 1 decimal deletes the entire number
fixes #15818
2024-07-31 15:20:37 +02:00
Stefan 98c18901e0 fix(dapps) Wallet Connect internet connection reestablishing issue
Add a new NetworkChecker QObject to StatusQ to be used in checking
internet connection status. This is used by the WebEngineLoader
to only allow loading of web pages when there is an active internet
to cover for a corner case on MacOS where the internet connection is
not reestablished if the WebEngineView was loaded without an active
internet connection.

Closes: #15598, #15806
2024-07-31 14:08:16 +02:00
Stefan 910af539d6 chore(dapps) remove unused Wallet Connect authentication from the SDK
Also add more debug logs for unhandled events

Updates: #15598
2024-07-31 14:08:16 +02:00
Stefan 992944870b chore(dapps) update Wallet Connect SDK to latest version 1.13.0
Upgrade from `1.11.2` to `1.13.0`

Updates: #15598
2024-07-31 14:08:16 +02:00
Stefan da622348f6 chore(dapps) remove the POC wallet connect
Updates: #15598
2024-07-31 14:08:16 +02:00
Cuteivist 20620e04cf
fix(wallet): Repeat transaction updates (#15571) 2024-07-31 13:58:05 +02:00
belalshehab 5d4afba07f fix(wallet)_: Filter non-bridgeable assets in Bridge Modal
- Implemented a bridgeableGroupedAccountAssetsModel in WalletAssetsStore.qml to dynamically filter assets based on their bridgeability.

closes: #15697
2024-07-31 12:43:24 +03:00
Stefan 222b9c74f5 chore(dapps) disable eth_signTransaction for Wallet Connect
Closes: #15661
2024-07-31 09:22:31 +02:00
Cuteivist dd25572c28
fix(wallet): Constrain token name size to send modal width (#15859) 2024-07-31 06:53:43 +02:00
Lukáš Tinkl 4dbae17bb9 fix(ConnectDAppModal): don't overflow texts
- set the correct widths and elide mode
- fixup the visuals of the NetworkFilter combo box (to disable it w/o
making it look disabled)
- fix passing the connection status down to DAppCard
2024-07-31 00:10:10 +02:00
Jonathan Rainville 298a6c3477
chore(beta): add beta tag to pairing screens (#15873) (#15901)
Fixes #15871

Adds a beta tag to the pairing screens on onboarding and settings
2024-07-30 12:55:03 -04:00
Sale Djenic 822410f6b6 feat: checksum validation added to adding saved addresses
Fixes: #15772
2024-07-30 18:17:53 +02:00
Valentina1133 44281aabd0
test: community ban member steps added (#15845) 2024-07-30 12:44:35 +07:00
richΛrd 1cb05d5814
chore: rename shards.test to status.prod (#15782) 2024-07-29 18:26:31 -04:00
Roman Chornii a310b8b803
fix(dApps): Improved logic for disconnecting of dApps in the app. (#15840)
Closes: #15814
2024-07-29 17:39:56 +03:00
Khushboo Mehta 354f2e4359 fix(@desktop/wallet): Swap "Approve" button becomes enabled before Approve Tx succeeds/fails
fixes #15784
2024-07-29 14:30:16 +02:00
Sale Djenic 207902589d chore: build the error reporting mechanism
Closes #15396
2024-07-29 10:54:53 +02:00
Andrey Bocharnikov ac04e34c21 fix(wakunodes): temporarily hide "add waku nodes" in advanced settings
Fixes #14929

Correct fix should be done as part of https://github.com/status-im/status-go/issues/5597 after dependency tasks are done
2024-07-27 01:11:53 +07:00
belalshehab 1aa2221834 fix(wallet)_: Temporarily disable Max Amount button pending #15709
- This commit temporarily disables the MaxAmount button in the `SwapInputPanel` and `SendModal` components.
     - The MaxAmount button will be reintroduced with the correct behavior in issue #15709 for the 2.31 release.

closes: #15710
2024-07-25 17:53:40 +03:00
Khushboo Mehta 7af8ede0e2 fix(@desktop/wallet): Enabled unit tests previously marked as flaky and skipped 2024-07-25 14:15:31 +02:00
Stefan 7d0e77d86f fix(dapps) emoji in wallet connect uri error
Closes: #15594
2024-07-25 12:55:29 +02:00
Stefan f6ae5ceabe fix(dapps) Wallet Connect url validation
The static url validation state `Pairing.errors.ok` was directly
responsible for the validation action in UX. With current change
the validation is now based on the pairing response. When the
pairing response is received the UX is validated and after half second
UX is moved to the approval process (`ConnectedDAppModal`)

Closes: #15591
2024-07-25 12:55:29 +02:00
Stefan 597d4bac9f fix(dapps) unsupported protocol Wallet Connect corner case
We have no easy way to check the protocol and provide a customized
error message. Therefore we generalizes the error message to network
not supported.

Closes: #15649
2024-07-25 12:55:29 +02:00
Cuteivist 2175311c86
chore: Use correct unique key for collectibles (#15736) 2024-07-24 21:18:33 +02:00
Godfrain Jacques c2a8817a80
fix missing required param to fix sign request popup display (#15760) 2024-07-24 08:45:09 -07:00
Lukáš Tinkl ee01c20b88 fix(SwapModal) disable exchange button when params empty
- when we arrive to a point when all input params are empty, disable the
middle Exchange button
- add QML test for the Exchange button enabled/disabled state

Fixes #15751
2024-07-24 15:05:05 +02:00
Lukáš Tinkl 765b526493 fix(SwapModal): Buy button not resizing with text
- also limit the max width in order for the ErrorTag not to overflow the
modal width

Fixes #15687
2024-07-24 13:52:21 +02:00
Stefan 7fb241b964 fix(dapps): filter out dApps connected on other profiles
Add helper function to filter out dApps with sessions that don't
have any supported account in the available accounts list.
Use helper function to filter out dApps connected on other profiles
when listing dApps in the dApps list.
When disconnecting an app only disconnect sessions for the current
profile.

Closes: #14888, #15707
2024-07-24 13:24:05 +02:00
Stefan 35b7f0583d fix(dapps) don't show Wallet Connect state from other profiles
Ignore session requests events that include accounts in other profiles

Updates: #15707
2024-07-24 13:24:05 +02:00
Stefan dc43a40a76 fix(dapps) minor wallet connect fixes and improvements
Also

- don't report error in case of status-go returning nil instead
of an empty array.
- fix misleading alias to AmountsArithmetic
- minor improvements requested in previous discussions

Updates: #15707
2024-07-24 13:24:05 +02:00
Cuteivist 047f558cd1
feature(wallet): Token preferences in assets model (#15706) 2024-07-23 14:00:49 +02:00
Michal Iskierko 52fe774975 feat(@desktop/metrics): Show metrics popup when starting application
Adding local setting: metrics_popup_seen
Small refactoring: showing popup from main.qml
Showing popup: 1. on welcome screen, 2. in Settings/Privacy page and 3. after login when the popup has not been shown yet

Issue #15628
2024-07-23 10:59:03 +02:00
Michal Iskierko a26657bbca feat(@desktop/metrics): Add metrics management page
Add new settings page for metrics management - Privacy and security
Add popup to enable/disable metrics on Onboarding and Privacy screens
Add MetricsStore in QML

Issue #15490
2024-07-23 10:59:03 +02:00
Dario Gabriel Lipicar 9d441fcff9 feat(@desktop/wallet): add support for approve and swap activity entries
Fixes #14836
2024-07-22 21:12:38 -03:00
Stefan e57f7552d9 feat(dapps) make wallet connect request data human readable
Notify user if he doesn't hold enough funds to make the transaction
Also check fees funds including the amount to be sent

Closes: #15192
2024-07-23 00:24:22 +02:00
Khushboo Mehta b93edff484 fix(@desktop/wallet): Update the link to point to terms and condition of paraswap page. 2024-07-22 21:40:01 +02:00
Godfrain Jacques 347e0df8b0
feat(connector)_: add sign transaction flow (#15662)
fixes #15182

 - Implement the sign transaction popup for Accept or Rejecting
   transactions
2024-07-22 11:02:35 -07:00
Stefan 36e3a7cbb5 feat(dapps) check max fees against balance
Also differentiate between l1 and l2 fees and check them against the
specific chain balance

Also

- Included tests for the new functionality
- Fixed some inconsistencies in handling types

Updates: #15552
2024-07-22 16:20:07 +02:00
Jonathan Rainville 8db0ac94f0
fix(networks): enable network before mint or airdrop (#15601)
Fixes #15507

Makes sure to enable the network where the owner token was minted before minting or airdroping a token.
This makes sure that the account selector shows the right balance and there is no ETH error before doing the transation
2024-07-22 09:52:44 -04:00
Dario Gabriel Lipicar 83db905e28 feat(swap): added more explicit error messages
Closes #14956
2024-07-19 16:40:22 -03:00
Godfrain Jacques 6eeb917cd7
feat(connector)_: create connection between connector service and status-desktop (#15565)
fix #15179 that triggers connection request from client

 - Setup the initial architecture for connecting Status-go and UI
   screens
 - Implement the request Connection popup for Accept or Rejecting
   connection
2024-07-19 12:21:36 -07:00
Jonathan Rainville a357299928
chore(beta): hioe ENS community permission creation (#15664)
Fixes #15663
2024-07-19 14:45:40 -04:00
Alex Jbanca 32aff401d6 fix(SendModal): Various issues fixed
1. Bridge panel not showing
2. Max button value when showing the fiat balance
3. Wallet footer visibility when Swap feature is disabled
2024-07-19 19:53:31 +03:00
Alex Jbanca 417a74d4b1 fix(SendModal): Fixing "Repeat transaction" action in Activity view and Activity details view 2024-07-19 19:53:31 +03:00
Alex Jbanca 6e93935298 fix(Send): Fixing Send button text on wallet footer on owner collectibles details view
Fixing a bug where the community name is not shown in the `Send` button
Get the collectible community name from the community model for community tokens. Otherwise default to community id.

+ Fix WalletFooter layout when the buttons text exceeds the available width

to squash: Fixing send on owner token - name
2024-07-19 19:53:31 +03:00
Alex Jbanca b36e2759af fix(Send): Fine tune the Send action on collectibles
1. Show Send Button on wallet footer when all accounts is selected
2. Hide Send Button in collectibles context menu and collectibles details view when the collectible is not owned by the user
3. Disable the Send Button in collectibles context menu and collectibles details view when the collectible is soulbound

to squash: Fine tune send action on collectibles

to squash: Fine tune send on collectibles

to squash: Fine-tune collectibles
2024-07-19 19:53:31 +03:00
Alex Jbanca 7926d1f748 chore(SendModal): Use accountAddress to preselect the account instead of account model item
Updating the SendModal to receive an accountAddress to preselect the account instead of the account item model

to squash: Fix account selection. by address
2024-07-19 19:53:31 +03:00
Alex Jbanca 1b67063eac fix(AssetsView): Align the selected chains data type in the assets view with the nim property
Nim chain selection is a colon separated string, but the assets adapter expects a chainId array for the selection
2024-07-19 19:07:51 +03:00
Alex Jbanca 5586d0f98a fix(Swap): Remove unnecessary default chain pre-selection 2024-07-19 19:07:51 +03:00
Alex Jbanca 9f40f0fada fix(Swap): Fixing the account balance in the swap modal
The root cause of this issue is the improper computation of the  `accountBalance`  expression role in the accounts model. Its value depends on another model (`filteredBalancesModel`) and by the time the expression role gets computed the proper `balance ` is not ready in the `filteredBalancesModel`.

This is a quick fix, but maybe the real fix should be restructuring the adapter and the model dependencies. I'd look out for any `ModelUtils` usage and replace it with a declarative approach if possible.
2024-07-19 19:07:51 +03:00
Roman Chornii ecec94b1ff
fix: Removed duplicated text in Token Popup by reusing existing supportedTokenSources mapping (#15587)
fixes #14366
2024-07-19 18:41:40 +03:00
Khushboo Mehta 4b30b12fee fix(@desktop/wallet): fix for SwapSignModal has wrong value
fixes #15605
2024-07-19 17:35:42 +02:00
Khushboo Mehta fd3b76115f fix(@desktop/wallet): SwapModal: Fix for can approve Swap with no amount entered
fixes #15553
2024-07-19 17:35:42 +02:00
Michał Cieślak 1e88756c13 SendModal: new AmountToSend initial integration
- new AmountToSend used in SendModal
- MaxSendButton simplified

Closes: #15207
2024-07-19 17:27:08 +02:00
Lungu Cristian 05287c873a
fix(walletconnect)_: tx fees not sent (#15678) 2024-07-19 16:33:22 +03:00
Ivan Belyakov 2f9bf48856 fix(wallet): fix balance chart to display chart for tokens
Replace missing methods calls of chart after it was replaced with a different
component.
Update chart on networks change.
Fix data for all chains requested - both test and real networks.
Fix some unrelated qml errors
2024-07-19 12:34:06 +02:00
Stefan 248ba1c1c8 feat(dapps): Add support for max fees in WalletConnect requests
Compute max fees for transaction related requests and display the
results to user.

Also:

- Add helper to convert from hex (backend) to decimal (frontend) values.
- Add helper to convert from float gwei to hex wei
- Update tests to accommodate for the new dependencies.

Sourcing of account balances is not included therefore the transaction is
allowed to go through even if the account balance is insufficient. An error
will be generated by the backend in this case.

Updates: #15192
2024-07-19 10:02:50 +02:00
Valentina1133 e1611cbc83
chore: keycard tests fixed, improved and other tests fixed accordingly (#15656) 2024-07-19 13:43:44 +07:00
Jonathan Rainville 2501e04ccb
Add Beta tag to the features that are not yet fully ready (#15617)
Fixes #15614

* feat(StatusQ): add StatusExperimentalTag component and page
* chore(beta): add beta tag to ENS
* chore(beta): add beta tag to Activity tab
* chore(beta): add beta tag to wallet settings
* chore(beta): add beta tag to Notification Center
2024-07-18 16:10:24 -04:00
Stefan 4341cfb4d2 feat(dapps) reject request on closing of modal
Closes: #15585
2024-07-18 17:15:24 +02:00
Valentina1133 2b415bdc53
test: block and unblock user test added (#15577) 2024-07-18 17:57:24 +07:00
Khushboo Mehta ec86a30d6e fix(@desktop/wallet): Fix for Swap - Pay and Receive assets get unselected, Pay amount resets to 0
fixes #15525
2024-07-17 17:25:57 +02:00
Khushboo Mehta 1d7ab859be fix(!desktop/wallet): Swap Modal doesn't have cursor visible when launched
fixes #15417
2024-07-17 17:25:57 +02:00
Noelia 480a3ed182 fix(Wallet/BridgeModal): Incorrect preselected recipient value and network model for bridge
- Fixed incorrect preselected recipient object for bridge modal.
- Fixed network model assignment for bridge.

Fixes #15629
2024-07-17 16:54:25 +02:00
Valentina Novgorodtceva b0f373f1dc chore: removed duplicated method, updated test according to changes 2024-07-17 12:32:16 +03:00
Michal Iskierko ecaa9b39c0 feat(@desktop/metrics): Initialize centralized metrics
Issue #15446
2024-07-16 14:58:13 +02:00
Roman Chornii c4d930ef88
fix(dapps) fail to process a transaction if missing usual fields (#15481)
Updates: #15189

Co-authored-by: Stefan <stefand@status.im>
2024-07-15 12:23:35 +03:00
Khushboo Mehta 6ae7e5fea2 fix(@desktop/wallet): Swap:: calculate propsal even if amount entered is more than balance
fixes #15509
2024-07-12 19:02:03 -03:00
Jonathan Rainville 4a097cfef7
fix(airdrop): sending an airdrop using a secondary account (better UX) (#15448)
Fixes #15382
So there is no easy way from the models and data we currently have in the client to know which account minted the owner token. So the easiest way to help the user is just to catch the error and show a better message.
2024-07-12 13:28:25 -04:00
Lukáš Tinkl 38d155f590 feat(SwapModal): Integrate Sign and Approve modals
- remove old popup and related components/adaptors
- simplify the API of the Sign/Approve modals to take pre-formatted
amounts as strings
- correct login/auth icon
- SB: make it possible to open the new secondary modals
- SB: fix the `fetchSuggestedRoutes` response handling, pass around the
`uuid` and inject it to the mocked suggested routes
- adjust SB pages and tests

Fixes #15443
2024-07-12 16:04:21 +02:00
Stefan fae3d14d50 feat(dapps): fetch max fees per gas from blockchain if not provided
Updates: #15192
2024-07-12 15:39:41 +02:00
Stefan 4deea3461f feat(dapps): show estimated time for dApps requests
Implemented using the fees from the transaction data sent
by the dApp.

Also fixed the nim status go wrapper to send proper formatted
string as expected on the other side.

Updates: #15192
2024-07-12 15:39:41 +02:00
Michał Cieślak be1c6ba2ad chore(StatusQ): Backpressure files deduplicated, imports adjusted
Closes: #15558
2024-07-12 14:00:15 +02:00
Anthony Laibe b2592d5d01 fix(@wallet): disable state for refresh
in case not interactive, we should not change the color on hover
2024-07-12 14:35:48 +03:00
Michał Cieślak f6320f69cb Wallet(SendModal): New tokens selector intially integrated
Closes: #15512
2024-07-12 11:10:37 +02:00
Alex Jbanca ca8a0028a8
feat(WalletConnect): Implement sign request modal (#15520)
* feat(WalletConnect): Implement sign request modal

1. Implementing sign request modal based on SignTransactionModalBase
2. Adding storybook page
3. Integrate it in the app
4. Removing DAppRequestModal
5. Update RoundImageWithBadge to preserve aspect ratio between badge and main image

* fix(WalletConnect): Remove unneeded properties from WalletConnectService API

Removing `selectedAccountAddress` and `loginType`. These properties are now passed through DAppsWorkflow API

* fix(WalletConnect): Removing unnecessary changes
2024-07-12 00:00:15 +03:00
richΛrd 2a41622298
chore: rename shards.staging to status.staging (#15510) 2024-07-11 16:09:20 -04:00
Ivan Belyakov 1e146b76e7 fix(wallet): profile network RPC URL editing form closed on "Save and Restart
later".

Fix "Restore defaults" to have confirmation dialog too and not close the
network editing form as well.
2024-07-11 18:33:13 +02:00
Khushboo Mehta 7caba84833 fix(@desktop/wallet): Fixing issue in deleting characters from Input area
fixes #15418
2024-07-11 17:41:04 +02:00
Khushboo Mehta 758bba1ac0 feat(@desktop/wallet): Show total fees instead of approval fees if approve is needed on the swapmodal
fixes #15505
2024-07-11 17:40:49 +02:00
Jonathan Rainville ad612a794c
fix(sharedAddress): hide non fully imported accounts from shared address (#15480)
* fix(sharedAddress): hide non fully imported accounts from shared address

Fixes #15471

We only filtered out watch only accounts, but we also need to make sure it was a fully imported account, ie an account that is usable, hence why using `canSend`. It is the same property they use in the SendTransaction modal
2024-07-11 10:47:51 -04:00
Noelia bc74724672 refactor(Wallet/SendModal): Created `WalletAccountsAdaptor` to be used in `SendModal`
- Created data transformation file called `WalletAccountsAdaptor` for `SendModal`. Now it contains the owned wallet accounts model data transformations.
- Added common formatting method for short chain ids to some utils and partially removed backend dependency.
2024-07-11 14:05:55 +02:00
Noelia 18e230bf91 refactor(Wallet/SendModal): Selected Recipients component review, backend dependencies cleanup
- Component name changed to be more precise with what it represents.
- Removed `RootStore` dependency from `Helpers.qml`.
- Removed unnecessary method `lookupAddressObject` from `RootStore`.
- Updated `SendModal` property bindings related to recipient.
- Some activity controller interaction details moved to transactions store instead of being directly in `SendModal`.
- Type enum living in `RecipientSelectorPanel` is moved to `Helpers`. Since it doesn't depends on the specific component and it's used in other global places.

Part of #15208
2024-07-11 14:05:55 +02:00
Valentina1133 4dc170688e
test: hidden community channel test added (#15485) 2024-07-11 17:51:56 +07:00
Stefan 136194c112 feat(dapp) handle pairing errors or timeout if no response
Found out while testing that in some corner cases there will be no
response of error in case of pairing. This is handled now by showing
a generic error message. The implementation is using a timer to handle
this case.
Extend the logic to report errors in the pairing process.

Closes #14676
2024-07-09 19:21:09 +02:00