fix: remove `onSignal` not overridden warnings

Uninherited `ProfileController` and `OnboardingController` from `SignalSubscriber` as they were not listening for signals from the node.

Added an `onSignal` dummy method in `WalletController` to make the compiler happy. The main app is assuming this is a `SignalSubscriber` but it is unclear if it being used (maybe it's a WIP).
This commit is contained in:
emizzle 2020-05-25 17:53:05 +10:00 committed by Iuri Matias
parent e1d1880aca
commit e5bed448ed
3 changed files with 7 additions and 2 deletions

View File

@ -4,7 +4,7 @@ import ../../signals/types
import eventemitter import eventemitter
import view import view
type OnboardingController* = ref object of SignalSubscriber type OnboardingController* = object
view*: OnboardingView view*: OnboardingView
variant*: QVariant variant*: QVariant
model*: AccountModel model*: AccountModel

View File

@ -9,7 +9,7 @@ import view
import "../../status/types" as status_types import "../../status/types" as status_types
import ../../models/profile import ../../models/profile
type ProfileController* = ref object of SignalSubscriber type ProfileController* = object
view*: ProfileView view*: ProfileView
variant*: QVariant variant*: QVariant
appEvents*: EventEmitter appEvents*: EventEmitter

View File

@ -2,6 +2,7 @@ import NimQml
import eventemitter import eventemitter
import strformat import strformat
import strutils import strutils
import chronicles
import view import view
import ../../status/wallet as status_wallet import ../../status/wallet as status_wallet
@ -34,3 +35,7 @@ proc init*(self: WalletController) =
self.view.addAssetToList(asset) self.view.addAssetToList(asset)
self.view.setDefaultAccount(status_wallet.getAccount()) self.view.setDefaultAccount(status_wallet.getAccount())
method onSignal(self: WalletController, data: Signal) =
debug "New signal received"
discard