From e5bed448ed44c8ee967c8ca753db33c32070f417 Mon Sep 17 00:00:00 2001
From: emizzle <eric.mastro@gmail.com>
Date: Mon, 25 May 2020 17:53:05 +1000
Subject: [PATCH] fix: remove `onSignal` not overridden warnings

Uninherited `ProfileController` and `OnboardingController` from `SignalSubscriber` as they were not listening for signals from the node.

Added an `onSignal` dummy method in `WalletController` to make the compiler happy. The main app is assuming this is a `SignalSubscriber` but it is unclear if it being used (maybe it's a WIP).
---
 src/app/onboarding/core.nim | 2 +-
 src/app/profile/core.nim    | 2 +-
 src/app/wallet/core.nim     | 5 +++++
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/app/onboarding/core.nim b/src/app/onboarding/core.nim
index 9233730c7c..e26ea486ff 100644
--- a/src/app/onboarding/core.nim
+++ b/src/app/onboarding/core.nim
@@ -4,7 +4,7 @@ import ../../signals/types
 import eventemitter
 import view
 
-type OnboardingController* = ref object of SignalSubscriber
+type OnboardingController* = object
   view*: OnboardingView
   variant*: QVariant
   model*: AccountModel
diff --git a/src/app/profile/core.nim b/src/app/profile/core.nim
index 643f10f5d2..1655d08096 100644
--- a/src/app/profile/core.nim
+++ b/src/app/profile/core.nim
@@ -9,7 +9,7 @@ import view
 import "../../status/types" as status_types
 import ../../models/profile
 
-type ProfileController* = ref object of SignalSubscriber
+type ProfileController* = object
   view*: ProfileView
   variant*: QVariant
   appEvents*: EventEmitter
diff --git a/src/app/wallet/core.nim b/src/app/wallet/core.nim
index 6a5ce909b2..36d2cab94b 100644
--- a/src/app/wallet/core.nim
+++ b/src/app/wallet/core.nim
@@ -2,6 +2,7 @@ import NimQml
 import eventemitter
 import strformat
 import strutils
+import chronicles
 
 import view
 import ../../status/wallet as status_wallet
@@ -34,3 +35,7 @@ proc init*(self: WalletController) =
   self.view.addAssetToList(asset)
 
   self.view.setDefaultAccount(status_wallet.getAccount())
+
+method onSignal(self: WalletController, data: Signal) =
+  debug "New signal received"
+  discard