chore(general): pull_request_template.md updated
This commit is contained in:
parent
88c0e87446
commit
824616c32e
|
@ -6,6 +6,15 @@
|
||||||
|
|
||||||
<!-- List the affected areas (e.g wallet, browser, etc..) -->
|
<!-- List the affected areas (e.g wallet, browser, etc..) -->
|
||||||
|
|
||||||
|
### StatusQ checklist
|
||||||
|
|
||||||
|
- [ ] add documentation if necessary (new component, new feature)
|
||||||
|
- [ ] update sandbox app
|
||||||
|
- in case of new component, add new component page
|
||||||
|
- in case of new features, add variation to existing component page
|
||||||
|
- nice to have: add it to the demo application as well
|
||||||
|
- [ ] test changes in both light and dark theme?
|
||||||
|
|
||||||
### Screenshot of functionality (including design for comparison)
|
### Screenshot of functionality (including design for comparison)
|
||||||
|
|
||||||
- [ ] I've checked the design and this PR matches it
|
- [ ] I've checked the design and this PR matches it
|
||||||
|
|
|
@ -1,17 +0,0 @@
|
||||||
### Checklist
|
|
||||||
|
|
||||||
- [ ] follow [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/)
|
|
||||||
- the scope should be the component's name e.g: `feat(StatusListItem): ... `
|
|
||||||
- when adding new components, the scope is the module e.g: `feat(StatusQ.Controls): ...`
|
|
||||||
- [ ] add documentation if necessary (new component, new feature)
|
|
||||||
- [ ] update sandbox app
|
|
||||||
- in case of new component, add new component page
|
|
||||||
- in case of new features, add variation to existing component page
|
|
||||||
- nice to have: add it to the demo application as well
|
|
||||||
- [ ] test changes in both light and dark theme?
|
|
||||||
- [ ] is this a breaking change?
|
|
||||||
- [ ] use the dedicated `BREAKING CHANGE` commit message section
|
|
||||||
- [ ] resolve breaking changes in [status-desktop](https://github.com/status-im/status-desktop)
|
|
||||||
- [ ] (pre-merge) adapt code to breaking changes
|
|
||||||
- [ ] (post-merge) update StatusQ submodule pointer
|
|
||||||
- [ ] test changes in [status-desktop](https://github.com/status-im/status-desktop)
|
|
Loading…
Reference in New Issue