From 824616c32eeaf70330885266239676cd786cbb90 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Cie=C5=9Blak?= Date: Wed, 21 Sep 2022 17:58:43 +0200 Subject: [PATCH] chore(general): pull_request_template.md updated --- .github/pull_request_template.md | 9 +++++++++ ui/StatusQ/.github/pull_request_template.md | 17 ----------------- 2 files changed, 9 insertions(+), 17 deletions(-) delete mode 100644 ui/StatusQ/.github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 27d27148f..b2d26474e 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -6,6 +6,15 @@ +### StatusQ checklist + +- [ ] add documentation if necessary (new component, new feature) +- [ ] update sandbox app + - in case of new component, add new component page + - in case of new features, add variation to existing component page + - nice to have: add it to the demo application as well +- [ ] test changes in both light and dark theme? + ### Screenshot of functionality (including design for comparison) - [ ] I've checked the design and this PR matches it diff --git a/ui/StatusQ/.github/pull_request_template.md b/ui/StatusQ/.github/pull_request_template.md deleted file mode 100644 index 99d4b06fc..000000000 --- a/ui/StatusQ/.github/pull_request_template.md +++ /dev/null @@ -1,17 +0,0 @@ -### Checklist - -- [ ] follow [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) - - the scope should be the component's name e.g: `feat(StatusListItem): ... ` - - when adding new components, the scope is the module e.g: `feat(StatusQ.Controls): ...` -- [ ] add documentation if necessary (new component, new feature) -- [ ] update sandbox app - - in case of new component, add new component page - - in case of new features, add variation to existing component page - - nice to have: add it to the demo application as well -- [ ] test changes in both light and dark theme? -- [ ] is this a breaking change? - - [ ] use the dedicated `BREAKING CHANGE` commit message section - - [ ] resolve breaking changes in [status-desktop](https://github.com/status-im/status-desktop) - - [ ] (pre-merge) adapt code to breaking changes - - [ ] (post-merge) update StatusQ submodule pointer -- [ ] test changes in [status-desktop](https://github.com/status-im/status-desktop)