status-im/status-desktop
2
0
Fork 0
mirror of https://github.com/status-im/status-desktop.git synced 2025-02-20 02:28:56 +00:00
Code Issues Projects Releases Wiki Activity

Revert "chore: add dummy ListView to ChatMessages to avoid app crash"

Browse Source 
This reverts commit 7b07a31fa6d06c730cf563475d319f0217a211ca.
This commit is contained in:
Iuri Matias 2021-03-01 16:06:06 -05:00
parent 3615a16b70
commit 27eab84f94
1 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
ui/app/AppLayouts/Chat/ChatColumn/ChatMessages.qml
View File

@ -29,28 +29,6 @@ ScrollView {
ScrollBar.vertical.policy: chatLogView.contentHeight > chatLogView.height ? ScrollBar.AlwaysOn : ScrollBar.AlwaysOff ScrollBar.vertical.policy: chatLogView.contentHeight > chatLogView.height ? ScrollBar.AlwaysOn : ScrollBar.AlwaysOff
ScrollBar.horizontal.policy: ScrollBar.AlwaysOff ScrollBar.horizontal.policy: ScrollBar.AlwaysOff
/**
* This ListView is prevents a crash of the application during
* login *DO NOT REMOVE IT*.
*
* For an unknown reason, when the `chatLogView` ListView uses
* a `verticalLayoutDirection: BottomToTop`, it prevents the application
* from successfully rendering during login and crashes.
*
* From debugging this, we know that this only happens when the above
* condition applies *and* when a `DelegateModel` is used.
* The delegate doesn't even need proper data, it application would still
* crash.
*
* We found out that the crash can be avoided when another `ListView` exists
* in this component (however it's unclear why).
*
* TODO(pascal): remove this once we know what's exactly going on here.
*/
ListView {
id: dummy
}
ListView { ListView {
property string currentNotificationChatId property string currentNotificationChatId