From 27eab84f943304626c2cb0e6fd43da8c19d1fb99 Mon Sep 17 00:00:00 2001 From: Iuri Matias Date: Mon, 1 Mar 2021 16:06:06 -0500 Subject: [PATCH] Revert "chore: add dummy ListView to ChatMessages to avoid app crash" This reverts commit 7b07a31fa6d06c730cf563475d319f0217a211ca. --- .../Chat/ChatColumn/ChatMessages.qml | 22 ------------------- 1 file changed, 22 deletions(-) diff --git a/ui/app/AppLayouts/Chat/ChatColumn/ChatMessages.qml b/ui/app/AppLayouts/Chat/ChatColumn/ChatMessages.qml index 87fce88d1c..acb4d116d7 100644 --- a/ui/app/AppLayouts/Chat/ChatColumn/ChatMessages.qml +++ b/ui/app/AppLayouts/Chat/ChatColumn/ChatMessages.qml @@ -29,28 +29,6 @@ ScrollView { ScrollBar.vertical.policy: chatLogView.contentHeight > chatLogView.height ? ScrollBar.AlwaysOn : ScrollBar.AlwaysOff ScrollBar.horizontal.policy: ScrollBar.AlwaysOff - /** - * This ListView is prevents a crash of the application during - * login *DO NOT REMOVE IT*. - * - * For an unknown reason, when the `chatLogView` ListView uses - * a `verticalLayoutDirection: BottomToTop`, it prevents the application - * from successfully rendering during login and crashes. - * - * From debugging this, we know that this only happens when the above - * condition applies *and* when a `DelegateModel` is used. - * The delegate doesn't even need proper data, it application would still - * crash. - * - * We found out that the crash can be avoided when another `ListView` exists - * in this component (however it's unclear why). - * - * TODO(pascal): remove this once we know what's exactly going on here. - */ - ListView { - id: dummy - } - ListView { property string currentNotificationChatId