status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(build) fix python package error on make run on MacOS 

Update packages all the time ensuring that a change in package.json will
be reflected without manual intervention.

The `fileicon` v0.3.0 tool we used on MacOS to embed icons in our binary
is failing. Upgrading to latest v0.3.3 fixes this. It will require
a `make update` though to fix local builds.
This commit is contained in:
Stefan 2024-05-06 14:55:08 +02:00 committed by Stefan Dunca
parent 3fd96986da
commit 195cb55e8d
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Makefile
View File

@ -557,10 +557,8 @@ ifeq ($(detected_OS),Darwin)
libkeycard.dylib \ libkeycard.dylib \
@rpath/libkeycard.dylib \ @rpath/libkeycard.dylib \
bin/nim_status_client bin/nim_status_client
ifeq ("$(wildcard ./node_modules/.bin/fileicon)","") # Install or update package.json files
echo -e "\033[92mInstalling:\033[39m fileicon" yarn install --check-files
yarn install
endif
endif endif
nim_status_client: force-rebuild-status-go $(NIM_STATUS_CLIENT) nim_status_client: force-rebuild-status-go $(NIM_STATUS_CLIENT)

2
package.json
View File

@ -5,7 +5,7 @@
"files": [], "files": [],
"devDependencies": { "devDependencies": {
"create-dmg": "status-im/create-dmg#678fbd4", "create-dmg": "status-im/create-dmg#678fbd4",
"fileicon": "0.3.0" "fileicon": "0.3.3"
}, },
"engines": { "engines": {
"node": ">=10", "node": ">=10",