From 195cb55e8d9d44b71dbc16a4b1811f1e03d5df60 Mon Sep 17 00:00:00 2001 From: Stefan Date: Mon, 6 May 2024 14:55:08 +0200 Subject: [PATCH] fix(build) fix python package error on make run on MacOS Update packages all the time ensuring that a change in package.json will be reflected without manual intervention. The `fileicon` v0.3.0 tool we used on MacOS to embed icons in our binary is failing. Upgrading to latest v0.3.3 fixes this. It will require a `make update` though to fix local builds. --- Makefile | 6 ++---- package.json | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index b63451fb93..14aedf7c3a 100644 --- a/Makefile +++ b/Makefile @@ -557,10 +557,8 @@ ifeq ($(detected_OS),Darwin) libkeycard.dylib \ @rpath/libkeycard.dylib \ bin/nim_status_client -ifeq ("$(wildcard ./node_modules/.bin/fileicon)","") - echo -e "\033[92mInstalling:\033[39m fileicon" - yarn install -endif + # Install or update package.json files + yarn install --check-files endif nim_status_client: force-rebuild-status-go $(NIM_STATUS_CLIENT) diff --git a/package.json b/package.json index 1ea0afb3f8..b83421d60f 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,7 @@ "files": [], "devDependencies": { "create-dmg": "status-im/create-dmg#678fbd4", - "fileicon": "0.3.0" + "fileicon": "0.3.3" }, "engines": { "node": ">=10",