Commit Graph

985 Commits

Author SHA1 Message Date
Jon Herron 879371255f Adding python env size 2023-02-22 10:55:09 -05:00
Jon Herron 1c6439ab59 Add cumulative task data size to script 2023-02-22 10:39:35 -05:00
burnettk 9a45183267
remove start and end events from simple logs view 2023-02-21 22:43:23 -05:00
burnettk 7ae03bec27
copy env so we are doing additive stuff rather than completely rewriting it 2023-02-21 22:00:02 -05:00
jasquat e506c37265
fix git bash script unbound error w/ burnettk 2023-02-21 17:08:09 -05:00
jasquat d059665431
more git config updates w/ burnettk 2023-02-21 16:43:52 -05:00
jasquat df3b713ce4
disable strict host checking for git commands w/ burnettk 2023-02-21 16:42:11 -05:00
jasquat b8b4734aea
fixed tests w/ burnettk 2023-02-21 15:28:54 -05:00
jasquat 2e0be30cbe
give access to download process data files if a user has access to start a process model w/ burnettk 2023-02-21 15:08:19 -05:00
Jakub Sokołowski b0a9f440cb
backend: create SSH key file when contents provided
Signed-off-by: Jakub Sokołowski <jakub@status.im>
2023-02-21 20:02:16 +01:00
Jakub Sokołowski e54965f8ec
backend: use sensible lock filename for git
Signed-off-by: Jakub Sokołowski <jakub@status.im>
2023-02-21 19:58:39 +01:00
Jakub Sokołowski 72a29aa327
backend: specify --rebase when using git pull
Otherwise it fails with:
```
Pulling without specifying how to reconcile divergent branches is discouraged.
```

Signed-off-by: Jakub Sokołowski <jakub@status.im>
2023-02-21 19:58:38 +01:00
Jakub Sokołowski 2f88ba3013
backend: fix use of SSH private key for git ops
Primarily this is supposed to fix the `git pull` aciton triggered by
webhooks from GitHub. But in addition to that the point is to simplify
that committing wrapper which has far too much in it.

Instead of passing everything as CLI arguments one should make use of
already supported environment variables and the `env` argument to
`subprocess` functions like `run()`. Writing extra logic in the wrapper
only makes it unnecessarily complicated.

By passing both user, email, and the SSH options in `run_shell_command`
we avoid the need to repeat the same boilerplate to provide Git config
and SSH credentials.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
2023-02-21 19:58:36 +01:00
jbirddog c6131d1a3f
Look in task data/script engine environment for data, not just workflow data. (#143) 2023-02-20 18:12:50 -05:00
Dan 7b16625cff run_pyl 2023-02-20 12:34:42 -05:00
Dan 5171e53240 * SpiffWorkflow event_definitions wanted to return a message event's correlation properties mested within correlation keys. But messages are directly related to properties, not to keys - and it forced a number of conversions that made for tricky code. So Messages now contain a dictionary of correlation properties only.
* SpiffWorkflow did not serialize correlations - so they were lost between save and retrieve.

* When comparing Correlation Property values - we are storing these values as strings in the database and can't convert them back to integers later, so I'm changing everying everywhere to compare after conversion to a string.  Don't feel great about this one.
* By using an SQL Alchemy join table, there is a lot of db queries we don't need to write.
* A few handy fucntions on db models to make it easier to work with correlations.
* Updated tests because I changed some of the BPMN models we were testing against.
* Database migration to use the new constraint names with the alternate form of the join table between correlation mesages to instance messages.
2023-02-20 11:50:35 -05:00
burnettk 5704c96356
delint 2023-02-20 10:58:04 -05:00
Jakub Sokołowski d4a90e208b
backend/git_service: accept webhook test requests
https://docs.github.com/en/webhooks-and-events/webhooks/testing-webhooks

Signed-off-by: Jakub Sokołowski <jakub@status.im>
2023-02-20 13:11:21 +01:00
Jakub Sokołowski a79d25f7e7
backend/git_service: check repo URLs from webhook
Since we are cloning a private repo we are using `ssh_url` in our case.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
2023-02-20 13:02:54 +01:00
Dan 6e7f36e55f Allow people to run commands like "flask db upgrade" without setting specific environment variables like FLASK_SESSION_SECRET_KEY everytime - they just need to add in their own /instance/config.py with their local configuration. 2023-02-19 10:37:00 -05:00
Dan 28ac9ef872 * Re-work message tests so I could wrap my simple head around what was happening - just needed an example that made sense to me.
* Clear out complex get_message_instance_receive how that many-to-many works.
* Create decent error messages when correlations fail
* Move correlation checks into the MessageInstance class
* The APIError could bomb out ugly if it hit a workflow exception with not Task Spec.
2023-02-18 13:09:58 -05:00
Dan 2cf38abedc bump spiffworkflow hash 2023-02-17 13:08:45 -05:00
Dan 4958dbf895 failing test. 2023-02-17 12:10:32 -05:00
Dan 50d3ee544b Merge branch 'main' into feature/message_fixes 2023-02-17 12:01:38 -05:00
Dan 948deb97bc work in progress -
* Link between message instance and correlations is now a link table and many-to-many relationships as recommended by SQLAlchemy
* Use the correlation keys, not the process id when accepting api messages.
2023-02-17 10:45:01 -05:00
jasquat bf6052d2cb
put the env vars in the env section of the github action configs w/ burnettk 2023-02-16 15:19:01 -05:00
jasquat 311a5b060d
added test for quickstart guide w/ burnettk 2023-02-16 15:05:55 -05:00
jasquat 012396b01e
pyl 2023-02-16 14:38:19 -05:00
jasquat c48bb712e8
Merge remote-tracking branch 'origin/main' into feature/support_local_openid_in_cypress_tests 2023-02-16 14:25:51 -05:00
burnettk 6f0c977f7e
use _GIT_SOURCE_BRANCH instead of _GIT_BRANCH 2023-02-16 14:10:31 -05:00
burnettk af45ca4301
fix unprefixed config 2023-02-16 13:56:48 -05:00
burnettk 93da627b24
update configs for publish feature 2023-02-16 13:47:26 -05:00
jasquat 5342b50bac
added some support for using the backend openid server for cypress tests w/ burnettk 2023-02-16 12:09:44 -05:00
burnettk 9a88dc2d81
add new uses and delete ppg.ba.sme1 2023-02-16 11:53:08 -05:00
jasquat f004db1562
the equal sign is not apart of the env var w/ burnettk 2023-02-16 11:18:50 -05:00
jasquat 1fd086f055
updated terraform deployed env config name w/ burnettk 2023-02-16 10:51:05 -05:00
jasquat 59a166ddf6
more config updates w/ burnettk 2023-02-16 10:21:02 -05:00
jasquat e1b71d5267
cleaned up the default config file a bit 2023-02-16 09:05:40 -05:00
jasquat bb0ac42fe5
pyl 2023-02-16 08:33:39 -05:00
jasquat fb5d902ce4
fixed some env vars for ci 2023-02-16 07:59:51 -05:00
jasquat 1f2a5e2ddf
pyl 2023-02-16 07:39:40 -05:00
jasquat 47807a6a0c
Merge remote-tracking branch 'origin/main' into feature/update_configs_with_prefix 2023-02-16 07:17:39 -05:00
burnettk 78fee35028
remove unused import 2023-02-16 06:34:03 -05:00
burnettk 84c77395d4
all tests pass w/ spiff lib upgrade, thanks for the help elizabeth 2023-02-15 22:56:12 -05:00
burnettk 608efeb565
format 2023-02-15 22:35:55 -05:00
jasquat 3abd4c92c6
updated remaining configs manually w/ burnettk 2023-02-15 17:21:37 -05:00
jasquat 78360de25f
updated secret config names as well w/ burnettk 2023-02-15 17:17:47 -05:00
jasquat 497389ceb9
updated configs to use the prefix using the script w/ burnettk 2023-02-15 17:07:12 -05:00
jasquat f9a7e40488
updated default user group var name for better prefix w/ burnettk 2023-02-15 16:43:40 -05:00
jasquat a6a1f06941
save task data to spiff step details when copmleting a user task as well w/ burnettk jbirddog 2023-02-15 15:34:51 -05:00
jasquat 3a00f09baa append OPEN_ID to TENANT_SPECIFIC_FIELDS for clarification on what it is from w/ burnettk 2023-02-15 11:12:30 -05:00
jasquat c8801094a5 do not remove the default user group when refreshing permissions w/ burnettk 2023-02-15 11:09:04 -05:00
Dan 66eba786af Merge branch 'main' of github.com:sartography/spiff-arena into main 2023-02-14 19:39:46 -05:00
Dan c1c5d02547 The aud in a json web token can be a string or an array -- so also deal with the case that it is an array 2023-02-14 19:39:35 -05:00
jasquat 4f7b2bdc8a updates to user import scripts w/ burnettk 2023-02-14 17:39:42 -05:00
jasquat 18a1b83e60 commit user if it has changed any attributes w/ burnettk 2023-02-14 15:08:25 -05:00
jasquat f7f7b60eb6 fix for mypy on python 3.9 w/ burnettk 2023-02-14 11:34:45 -05:00
jasquat 386f1c926d give some leeway to iat when validating auth w/ burnettk 2023-02-14 10:51:11 -05:00
jasquat 6e49fcc975 add in debug logging when failing to login to help debug auth failures 2023-02-14 09:59:29 -05:00
jbirddog 2eab56525a
Don't try to complete a ready task to move the process instance diagram to the next yellow. (#136) 2023-02-13 18:52:06 -05:00
Dan Funk 4e27d5c6e7
Merge pull request #137 from sartography/failing_test
Check the End Event to fix the failing test
2023-02-13 17:04:32 -05:00
jasquat c3713e6d94 allow overriding keycloak url in add user script w/ burnettk 2023-02-13 16:16:43 -05:00
jasquat 047605a282 updated add test users script to use realm admin w/ burnettk 2023-02-13 16:04:57 -05:00
Jon Herron 1c95d2f234 The End Event has a spiff step 2023-02-13 14:13:34 -05:00
jasquat b06929ec08 added script to import users w/ burnettk 2023-02-13 12:15:00 -05:00
jasquat a39ae63bde added api endpoint to allow logging in for the first time with an openid access_token w/ burnettk 2023-02-13 11:57:31 -05:00
Dan Funk 69f85aad6b
Merge pull request #135 from sartography/bug/len
This should fix the len issue - though there may be better ways to fix
2023-02-13 10:38:32 -05:00
Dan 03f8b62599 run_pyl 2023-02-13 10:38:21 -05:00
burnettk 525536ab6e delete 15 users that are no longer needed 2023-02-13 10:36:03 -05:00
Dan 9a0880f281 Merge remote-tracking branch 'origin/main' into bug/len 2023-02-13 10:35:20 -05:00
burnettk c7a13762c8 commit before removing users 2023-02-13 10:30:07 -05:00
Dan 674380001f This should fix the len issue - though there may be better ways to fix
this.
This reverts commit d1e2d29211.
2023-02-13 10:13:51 -05:00
Dan d1e2d29211 Revert "more finally for better len"
This reverts commit 44e2e91078.
2023-02-13 10:12:31 -05:00
Dan 44e2e91078 more finally for better len
added a fixme for raising errors
fixed up an error message
2023-02-13 10:10:23 -05:00
burnettk 1ccb3b218f fix employee id 2023-02-12 23:43:56 -05:00
Dan 138cd1f940 Update Spiffworkflow so we have the better error messages on service tasks. 2023-02-12 16:19:40 -05:00
Dan 44df269eac don't default to a broken environment. 2023-02-12 15:00:17 -05:00
burnettk 388fcfb42a add five test users, rename peopleops users, delete two 2023-02-12 13:35:09 -05:00
Dan 29dd65b5ad Remove version from docker-compose, as this is causing issues for people still using docker-compose v2. 2023-02-12 12:24:25 -05:00
burnettk be44af5ddf turn off profiling for now to see if that is what is causing segfaults 2023-02-10 09:52:23 -05:00
jbirddog ddcecb21c4
Save logs in finally (#134) 2023-02-10 09:18:04 -05:00
jasquat fd8134706d link to the spiff step from a task on the frontend and use the correct db in ci 2023-02-09 17:07:36 -05:00
jasquat ac9813790c pyl w/ burnettk 2023-02-09 16:03:26 -05:00
jasquat b8870601d1 call activities are also working w/ burnettk 2023-02-09 15:52:00 -05:00
jasquat d99598f5c0 tasks and subprocesses can are setting the task states properly now when getting task data w/ burnettk jbirddog 2023-02-09 15:29:45 -05:00
jasquat e9ee885efb pyl w/ burnettk 2023-02-09 10:28:36 -05:00
Jon Herron bec263d24d Merge branch 'save_step_data' of github.com:sartography/spiff-arena into save_step_data 2023-02-09 09:45:50 -05:00
Jon Herron ffb468d6bb Fix bug where deletes from the environment were not removed from the task data as well 2023-02-09 09:45:31 -05:00
jasquat 8796e42d5e Merge remote-tracking branch 'origin/main' into save_step_data 2023-02-09 09:37:03 -05:00
Dan Funk 81da8c30a6
Merge pull request #132 from sartography/feature/no_more_current_user
Feature/no more current user
2023-02-08 18:23:25 -05:00
jasquat 03d163b1e0 updated controller to use spiff step details to find correct task data to show w/ burnettk 2023-02-08 17:31:20 -05:00
Dan 9eb2eb28df run_pyl 2023-02-08 17:10:57 -05:00
Dan 23403acd29 remove the "current_user" from being added to the task_data. 2023-02-08 15:53:14 -05:00
jasquat ba570d0eff Merge remote-tracking branch 'origin/main' into save_step_data 2023-02-08 14:08:27 -05:00
jasquat 677a5924e9 Merge remote-tracking branch 'origin/main' into save_step_data 2023-02-08 14:02:24 -05:00
burnettk 29f96ff68d pyl 2023-02-08 14:02:17 -05:00
Dan Funk 2814550872
Merge pull request #131 from sartography/feature/improved_service_task_errors
Feature/improved service task errors
2023-02-08 13:38:51 -05:00
Dan 7c7e2d6915 If you have an instance/config.py to override local development it would also override testing. 2023-02-08 13:37:56 -05:00
Dan f9372effd9 Use a mock when making external calls in tests. 2023-02-08 13:14:42 -05:00
Dan 84c74e010a Merge remote-tracking branch 'origin/main' into feature/improved_service_task_errors 2023-02-08 13:11:53 -05:00
burnettk 3539581f1f Merge branch 'main' of github.com:sartography/spiff-arena 2023-02-08 12:51:52 -05:00
burnettk 558c593607 catch up with environment change 2023-02-08 12:51:48 -05:00
jasquat 22dad8ac8a added additional columns to spiff_step_details w/ burnettk jbirddog 2023-02-08 12:43:30 -05:00
Dan 4c7dfaffa6 fixing some missing types 2023-02-08 12:27:55 -05:00
Dan f387ab6c6c run_pyl 2023-02-08 12:00:27 -05:00
Dan d97fcfd238 Assure that when something goes wrong calling a service task that we get as much good information about the problem as possible. 2023-02-08 11:53:20 -05:00
jasquat dc4dfdb788 Merge remote-tracking branch 'origin/main' into save_step_data 2023-02-08 11:47:11 -05:00
jasquat 16b2c96171 enable faulthandler to hopefully see seg faults in the logs w/ burnettk jbirddog 2023-02-08 11:42:11 -05:00
Jon Herron fb1e2abb0d Merge branch 'main' into save_step_data 2023-02-08 10:14:07 -05:00
burnettk 5b22f46ed1 remove dup 2023-02-08 09:52:40 -05:00
burnettk 11b69fee1b add users 2023-02-08 08:04:30 -05:00
jasquat b0ca9e60f3
Merge pull request #114 from sartography/frontend/use-api-subpath
frontend: use /api subpath instead of subdomain
2023-02-07 17:20:45 -05:00
jasquat 1428c1c39f allow setting configs for the frontend through env vars w/ burnettk 2023-02-07 17:17:45 -05:00
jasquat fbe2bbfb34 allow configuring gunicorn configs in boot_server_in_docker w/ burnettk 2023-02-07 15:38:29 -05:00
burnettk 998ca43808 sentences need spaces between them 2023-02-07 15:09:49 -05:00
jasquat 03b265a522 renamed development env to local_development and testing to unit_testing w/ burnettk 2023-02-07 15:02:47 -05:00
jasquat 5fb26ae97d set up qa2 to only do path based routing w/ burnettk 2023-02-07 14:30:13 -05:00
jasquat 5ae13a8d51 added backend url to qa2 configs 2023-02-07 13:46:54 -05:00
jasquat 27075c7440 added qa2 configs to use keycloak on qa1 to test different domains w/ burnettk 2023-02-07 11:30:18 -05:00
Dan Funk be34d6990f
Merge pull request #128 from sartography/feature/bug_fixes
Feature/bug fixes
2023-02-07 08:20:16 -05:00
Kevin Burnett 814e3bd527
Update tasks_controller.py 2023-02-06 16:21:55 -08:00
burnettk 9faea2c1f7 update get_token 2023-02-06 17:55:07 -05:00
jasquat 3f484c4e3c pass tenant attributes when creating a user w/ burnettk 2023-02-06 17:34:55 -05:00
jasquat 0705bf5d58 pyl w/ burnettk 2023-02-06 16:26:42 -05:00
jasquat f03d8312f4 Merge remote-tracking branch 'origin/main' into feature/tenant-specific-fields-from-openid 2023-02-06 16:24:59 -05:00
jasquat 8c94adc143 added bambooid to status users w/ burnettk 2023-02-06 16:24:48 -05:00
Jon Herron a40b023593 POC for saving some data about each step 2023-02-06 15:59:26 -05:00
jasquat c1f7735918 allow added custom attributes to users when adding to keycloak w/ burnettk 2023-02-06 15:34:55 -05:00
jbirddog c00338e951
Backend do_engine_steps performance improvements (#129)
Co-authored-by: Dan <daniel.h.funk@gmail.com>
2023-02-06 15:25:49 -05:00
jasquat cea7f746f6 use our json encoder to dump the user for get_current_user script w/ burnettk 2023-02-06 14:11:15 -05:00
Dan 54be9535f6 Use the same markdown library for displaying as for editing - could enable a security run_pyl 2023-02-06 12:20:29 -05:00
Dan 0e3ba4664f When catching non-jinja errors from Jinja, raise a good error message, and make a best effort at tracking down the line number and error line if possible. 2023-02-06 12:06:37 -05:00
burnettk 8ce5855b78 move towards returning dict in get_current_user 2023-02-06 10:30:38 -05:00
burnettk 142288537a Merge remote-tracking branch 'origin/main' into feature/tenant-specific-fields-from-openid 2023-02-06 10:20:40 -05:00
burnettk ab9614c6b4 add test users 2023-02-06 10:03:51 -05:00
Dan c7438253c7 run_pyl 2023-02-06 08:05:33 -05:00
Dan 0b3f67abae When searching for human tasks to determine if the current user can complete it, filter on the "completed" flag.
Front-end -- enable the form if you receive an onUnathorized error because the thing you are unauthorized to do might have nothing to do with whether you can submit the form.
2023-02-06 08:01:37 -05:00
Jon Herron 3b5763e8d0 Back to inserting every log 2023-02-04 12:55:48 -05:00
burnettk 84008cb6c1 hoping to fix tests on windows 2023-02-04 00:36:17 -05:00
burnettk 32007c3cbb grab bamboo_id from keycloak 2023-02-04 00:12:01 -05:00
burnettk 60ab826e1b lint 2023-02-04 00:09:43 -05:00
burnettk a9f00ce1a7 if there are tenant specific fields in the config, transfer them from openid token to db 2023-02-04 00:03:32 -05:00
Dan 1e399e05bd Merge branch 'main' of github.com:sartography/spiff-arena into main 2023-02-03 17:01:13 -05:00
Dan d010c2bce6 Fix that dreadful unknown "KeyError" exception that was cropping up.
Adding a bit of detail to the spiffworkflow exceptions when a duplicate process model is found.
Disable the submit button on tasks after you click submit (avoid the double click and give users a better experience)
2023-02-03 17:01:03 -05:00
Kevin Burnett d4f314dadf
Merge pull request #125 from sartography/feature/dynamically-hide-fields-w-task-data
Feature/dynamically hide fields w/ task data
2023-02-03 13:20:19 -08:00
burnettk 53d99c49d1 refactor some stuff in task_show to separate functions 2023-02-03 16:17:36 -05:00
burnettk 408759d122 show that hiding nested fields works as well 2023-02-03 15:47:35 -05:00
burnettk c3cb288875 make form schema and form ui schema both dicts, add support for hiding fields based on task data 2023-02-03 15:40:14 -05:00
Dan 0b9c82c68d run_pyl 2023-02-03 13:58:38 -05:00
Dan Funk dd692cf671
Merge branch 'main' into feature/more_better_errors 2023-02-03 13:21:48 -05:00