status-im/sourcecred
2
0
Fork 0
mirror of https://github.com/status-im/sourcecred.git synced 2025-02-20 16:28:26 +00:00
Code Issues Projects Releases Wiki Activity

Cleanup some minor mistakes (#822)

Browse Source 
- the capitalization of the GitObject types was incorrect
- removed an outdated TODO

Test plan: `yarn test` passes.
This commit is contained in:
Dandelion Mané 2018-09-13 12:52:58 -07:00 committed by GitHub
parent 2a39bd075d
commit 5c46636611
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/github/graphql.js
View File

@ -116,10 +116,10 @@ export type RepositoryJSON = {|
export type RefJSON = {|+target: GitObjectJSON|}; export type RefJSON = {|+target: GitObjectJSON|};
export type GitObjectJSON = export type GitObjectJSON =
| {|+__typename: "COMMIT", +history: ConnectionJSON<CommitJSON>|} | {|+__typename: "Commit", +history: ConnectionJSON<CommitJSON>|}
| {|+__typename: "TREE"|} | {|+__typename: "Tree"|}
| {|+__typename: "BLOB"|} | {|+__typename: "Blob"|}
| {|+__typename: "TAG"|}; | {|+__typename: "Tag"|};
/** /**
* The top-level GitHub query to request data about a repository. * The top-level GitHub query to request data about a repository.

2
src/plugins/github/relationalView.js
View File

@ -327,8 +327,6 @@ export class RelationalView {
number: String(json.number), number: String(json.number),
repo, repo,
}; };
// TODO(@decentralion): Rewrite so that pulls actually have
// the commit attached (not just oid)
const mergedAs = const mergedAs =
json.mergeCommit == null ? null : this._addCommit(json.mergeCommit); json.mergeCommit == null ? null : this._addCommit(json.mergeCommit);