From 5c46636611d00321695fb0637a20143ea487352d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dandelion=20Man=C3=A9?= Date: Thu, 13 Sep 2018 12:52:58 -0700 Subject: [PATCH] Cleanup some minor mistakes (#822) - the capitalization of the GitObject types was incorrect - removed an outdated TODO Test plan: `yarn test` passes. --- src/plugins/github/graphql.js | 8 ++++---- src/plugins/github/relationalView.js | 2 -- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/plugins/github/graphql.js b/src/plugins/github/graphql.js index eaa87d0..2082b20 100644 --- a/src/plugins/github/graphql.js +++ b/src/plugins/github/graphql.js @@ -116,10 +116,10 @@ export type RepositoryJSON = {| export type RefJSON = {|+target: GitObjectJSON|}; export type GitObjectJSON = - | {|+__typename: "COMMIT", +history: ConnectionJSON|} - | {|+__typename: "TREE"|} - | {|+__typename: "BLOB"|} - | {|+__typename: "TAG"|}; + | {|+__typename: "Commit", +history: ConnectionJSON|} + | {|+__typename: "Tree"|} + | {|+__typename: "Blob"|} + | {|+__typename: "Tag"|}; /** * The top-level GitHub query to request data about a repository. diff --git a/src/plugins/github/relationalView.js b/src/plugins/github/relationalView.js index b5f657d..04a0aa8 100644 --- a/src/plugins/github/relationalView.js +++ b/src/plugins/github/relationalView.js @@ -327,8 +327,6 @@ export class RelationalView { number: String(json.number), repo, }; - // TODO(@decentralion): Rewrite so that pulls actually have - // the commit attached (not just oid) const mergedAs = json.mergeCommit == null ? null : this._addCommit(json.mergeCommit);