status-im
/
samyoul-notes
mirror of https://github.com/status-im/samyoul-notes.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
samyoul-notes/README.md

4.9 KiB
Raw Blame History

2020-12-23

Pulls

Schedule

2020-12-22

AdHoc

  • Quirk that prevented tests from running
    • xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools), missing xcrun at: /Library/Developer/CommandLineTools/usr/bin/xcrun
    • Solution

Pulls

  • #2100 - Expand Local Notifications - debugging
    • Resolved the weird bug where adding MarshalJSON() to the Notification struct would result in a fail
      • Initially I thought that the problem was because the signal.send() was handling the json.Marshalling in a strange way
      • The real bug was in signal.send() and caused by the new Body.Type field not being set.
      • This wasn't immediately obvious because signal.send() uses a logger to record errors and the logger wasn't printing to the terminal, therefore a failed marshal resulted in an error not about the thing that had actually gone wrong, adding lots of spew.Dumps() helped
      • A minor note the signal package has some weird structure, for example setting and getting a package var as a kind of global, therefore maintaining an implicit "package state".

2020-12-21

Pulls

Review

2020-12-18

Ad Hoc

  • Resolve weird issue on my machine where make vendor has started throwing modvendor: command not found
  • Compile list of known technical debt in status-go
    • Document Here
    • Based on the //TODO items in the code
    • Gone through all directories up to protocol, need to finish protocol, all protocol sub directories and all remaining directories

Review

  • #2046 - Communities - feedback
    • Initial review require a deeper review of the core functionality

Schedule

2020-12-17

Pulls

2020-12-16

Pulls

Issues

Schedule