status-im
/
samyoul-notes
mirror of https://github.com/status-im/samyoul-notes.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Updated 2020-12-22

This commit is contained in:
Samuel Hawksby-Robinson 2020-12-23 13:35:21 +00:00
parent de4b401473
commit 77bbac0594
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
README.md
View File

@ -1,5 +1,23 @@
# 2020-12-22
## Pulls
- [x] [#2100 - Expand Local Notifications](https://github.com/status-im/status-go/pull/2100) - `debugging`
- Resolved the weird bug where adding `MarshalJSON()` to the `Notification` struct would result in a fail
- Initially I thought that the problem was because the `signal.send()` was handling the `json.Marshalling` in a strange way
- The real bug was in `signal.send()` and caused by the new `Body.Type` field not being set.
- This wasn't immediately obvious because `signal.send()` uses a logger to record errors and the logger wasn't printing to the terminal, therefore a failed marshal resulted in an error not about the thing that had actually gone wrong, adding lots of `spew.Dumps()` helped
- A minor note the `signal` package has some weird structure, for example setting and getting a package var as a kind of global, therefore maintaining an implicit "package state".
---
# 2020-12-21
## Pulls
- [x] [#2100 - Expand Local Notifications](https://github.com/status-im/status-go/pull/2100) - `debugging`
- Working on a weird bug where adding `MarshalJSON()` to the `Notification` struct would result in a fail.
## Review
- [x] [#2046 - Communities](https://github.com/status-im/status-go/pull/2046) - `approved`

3
tags/README.md
View File

@ -8,7 +8,8 @@
| `commits` | Related to add git commits to github PRs |
| `completed` | Denotes that an item has been completed |
| `created` | Denotes that an item was created |
| `discussed` | Denotes that an item was discussed with a team member |
| `debugging` | Denotes that an item was debugged |
| `discussed` | Denotes that an item was discussed with a team member |
| `draft` | Denotes a git branch was converted into a PR draft |
| `feedback` | Denotes that an item was given feedback by myself |
| `merged` | Denotes that a PR was merged with the related repo's main branch |