From 77bbac059470c20d790c7b6c51856c06821c8ed1 Mon Sep 17 00:00:00 2001 From: Samuel Hawksby-Robinson Date: Wed, 23 Dec 2020 13:35:21 +0000 Subject: [PATCH] Updated 2020-12-22 --- README.md | 18 ++++++++++++++++++ tags/README.md | 3 ++- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index f4abdf4..cac5eeb 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,23 @@ +# 2020-12-22 + +## Pulls + +- [x] [#2100 - Expand Local Notifications](https://github.com/status-im/status-go/pull/2100) - `debugging` + - Resolved the weird bug where adding `MarshalJSON()` to the `Notification` struct would result in a fail + - Initially I thought that the problem was because the `signal.send()` was handling the `json.Marshalling` in a strange way + - The real bug was in `signal.send()` and caused by the new `Body.Type` field not being set. + - This wasn't immediately obvious because `signal.send()` uses a logger to record errors and the logger wasn't printing to the terminal, therefore a failed marshal resulted in an error not about the thing that had actually gone wrong, adding lots of `spew.Dumps()` helped + - A minor note the `signal` package has some weird structure, for example setting and getting a package var as a kind of global, therefore maintaining an implicit "package state". + +--- + # 2020-12-21 +## Pulls + +- [x] [#2100 - Expand Local Notifications](https://github.com/status-im/status-go/pull/2100) - `debugging` + - Working on a weird bug where adding `MarshalJSON()` to the `Notification` struct would result in a fail. + ## Review - [x] [#2046 - Communities](https://github.com/status-im/status-go/pull/2046) - `approved` diff --git a/tags/README.md b/tags/README.md index a017b68..3f9ab87 100644 --- a/tags/README.md +++ b/tags/README.md @@ -8,7 +8,8 @@ | `commits` | Related to add git commits to github PRs | | `completed` | Denotes that an item has been completed | | `created` | Denotes that an item was created | -| `discussed` | Denotes that an item was discussed with a team member | +| `debugging` | Denotes that an item was debugged | +| `discussed` | Denotes that an item was discussed with a team member | | `draft` | Denotes a git branch was converted into a PR draft | | `feedback` | Denotes that an item was given feedback by myself | | `merged` | Denotes that a PR was merged with the related repo's main branch |