Commit Graph

1985 Commits

Author SHA1 Message Date
Mati Dastugue a3541d8a33 Add support for collectibles 2020-06-10 11:32:30 -03:00
Fernando 41ec0786b7
(Refactor) Update `dataDecoded` structure (#995) 2020-06-09 16:15:31 -03:00
nicolas 509aefe286
fix config (#1002) 2020-06-09 13:19:17 -03:00
nicolas ea1662bc6f
Safe apps url config (#1001)
* safe-react-apps  url from config and add request app

* Adding types

* safe-react-components bump

* extracting types

* add return type

Co-authored-by: lukasschor <lukas.schor@gnosis.pm>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-06-09 11:34:43 -03:00
Mikhail Mikheev 8f9cd58d4e
Merge pull request #985 from gnosis/fix/#983-support-ens-for-contract-interaction
(Fix) [Contract Interaction] Support ENS for contract address
2020-06-09 18:11:28 +04:00
Mikhail Mikheev 6d56286c02 Merge branch 'development' of github.com:gnosis/safe-react into 982-fiatbalances-dont-show 2020-06-09 14:04:28 +04:00
Mikhail Mikheev cdbdf69829
Merge pull request #996 from gnosis/fix/#994-contractInteraction-no_data-for-abi-field
(Fix) Properly identify methods to interact with
2020-06-09 12:49:24 +04:00
fernandomg 9db0d76fa1 Allow pure functions to be called 2020-06-08 15:54:09 -03:00
Mati Dastugue f7faf3e29c Merge with dev 2020-06-08 13:24:48 -03:00
fernandomg 7d83843b96 properly identify methods to interact with 2020-06-06 17:34:26 -03:00
Fernando cefb33b593
(Fix) [Contract Interaction] Parameter validation (#974) 2020-06-06 10:32:25 -03:00
fernandomg d488436054 avoid populating abi field with invalid data if it's not required 2020-06-05 11:22:35 -03:00
fernandomg 78682a90af add decorator to extract eth address from ENS for contract address 2020-06-05 11:22:35 -03:00
fernandomg 3ac845106b move `isValidEnsName` to utils 2020-06-05 11:22:35 -03:00
fernandomg 45a3719bb0 Merge branch 'development' into fix/#950-parameter-validation-contractInteraction 2020-06-05 11:21:47 -03:00
Agustin Pane ed56191e56 Fix types 2020-06-05 11:08:29 -03:00
Agustin Pane 3deb37da26 Fix types 2020-06-05 09:33:37 -03:00
Agustin Pane 6c857ee02a Merge branch 'development' of https://github.com/gnosis/safe-react into 957-null-balances
# Conflicts:
#	package.json
2020-06-05 09:05:01 -03:00
Mikhail Mikheev 5a7ced92ad
Merge pull request #897 from gnosis/536-notifications-status-labels-sync
Feature: Hide transactions with no confirmations, labels/notifications sync
2020-06-05 14:20:04 +04:00
Agustin Pane e5c6d8040d
(Fix) Null balances (#971)
* Fixs balances will null value

* Fixs collectibles not loading

* Uses useLocation hooks

* Add types

* fix types for useLocation

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-06-04 17:54:39 -03:00
fernandomg 4d41e813ed Merge branch 'development' into fix/#950-parameter-validation-contractInteraction
# Conflicts:
#	package.json
#	src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/RenderInputParams/index.tsx
#	src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/Review/index.tsx
#	src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/Review/style.ts
#	src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/index.tsx
#	src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/utils/index.ts
#	yarn.lock
2020-06-04 11:17:49 -03:00
Agustin Pane 63193d2429
(Fix) [Contract Interaction] boolean fields (#976)
* Replaces checkbox component with safe apps components

* Refactor input params to use checkbox component for boolean types

* Remove "anys"
Fix boolean values display on review tx

* Remove any

* Fix ts issues

* Exports boolean fn to util function

* Extract input component rendering to another component

* Fixs imports
Add types

* Remove old checkbox component

* Add types

* Add types

* fix `data` string not being updated after modifying a reviewed tx

* fixes required for typescript 3.9.3 upgrade

* bump typescript version

* add travis_wait for build command

* add cache for yarn

* travis wait fix

* remove travis_wait

* Revert "fix `data` string not being updated after modifying a reviewed tx"

This reverts commit 49356054cd93726b058073d3cd2e7a0244fd5914.

* Revert "Revert "fix `data` string not being updated after modifying a reviewed tx""

This reverts commit f2572e68dc59c01d8e4b1eccf975faf4006cd7a7.

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-06-04 10:56:55 -03:00
Agustin Pane 1a901126df Adds fallback to USD as currency rate selected in case that the data stored is not defined 2020-06-04 10:49:12 -03:00
Agustin Pane 6858a8d6d6 Refactors AVAILABLE_CURRENCIES as enum
Add types for currency values
2020-06-04 10:12:06 -03:00
fernandomg 0cf786e8d1 fix `data` string not being updated after modifying a reviewed tx 2020-06-03 14:04:58 -03:00
fernandomg e3a9945675 add types and fix `useField` usage 2020-06-03 14:04:15 -03:00
fernandomg c946cd98e0 Merge branch 'development' into 536-notifications-status-labels-sync
# Conflicts:
#	yarn.lock
2020-06-03 10:35:26 -03:00
fernandomg 02bb5211a7 fix errors when creating tx in safe v1.0.0
- Code was expecting `ExecutionSuccess` event. That's not part of v1.0.0
- `transactionHash` is part of the tx receipt, so no need to extract it from the event
- `safeTxHash` is calculated client-side, so no longer needed to get it from tx receipt
2020-06-03 10:34:31 -03:00
fernandomg cd77fba5b7 fix useField abi config object param 2020-06-02 13:32:11 -03:00
fernandomg 95a753cbe5 fix 'non-empty-pattern' ts warning 2020-06-02 10:50:32 -03:00
fernandomg 7dfa7af41d add general types to ContractInteraction components 2020-06-02 10:45:55 -03:00
fernandomg 2c0bcfefe6 convert ABIService from class to module and add typings 2020-06-02 10:22:49 -03:00
fernandomg f049f8598d fix styles typing 2020-06-02 10:17:02 -03:00
fernandomg b07f0e90d9 use method `.call` only for the read methods
- review screen then will attempt to evaluate the validity of the write method
2020-06-02 09:04:29 -03:00
fernandomg d4ef317cce Merge branch 'development' into fix/#950-parameter-validation-contractInteraction
# Conflicts:
#	yarn.lock
2020-06-01 23:39:52 -03:00
fernandomg ed995df5b7 simplify call/review buttons
- unify handleSubmit
- use `.call` to identify a failing tx
2020-06-01 23:38:27 -03:00
fernandomg a28c598af1 add title to call-result values 2020-06-01 23:36:39 -03:00
fernandomg 1442f33d5a fix error message format, prevent text overflow 2020-06-01 23:35:35 -03:00
Mati Dastugue 3bcdb80f26
Merge pull request #967 from gnosis/fix/ledger
Fix Ledger issues on Desktop App
2020-06-01 16:54:28 -03:00
fernandomg d5cf8c94ab change `signature` key name to `methodSignature`
There is something down there that mutates the `tx` object in the Review screen and was overwriting the `signature` key with the method's hash
2020-06-01 14:54:42 -03:00
fernandomg 420b9cb58e properly update method selected 2020-06-01 14:51:45 -03:00
Agustin Pane 76eeb17dd2
(Fix) Balances tabs fixs (#973)
* Fix cannot change safe from sidebar

* Removes collectibles header for 1.0.0 safes

* Removes exact path in balances route
2020-06-01 13:50:45 -03:00
fernandomg 45bbbc9967 properly handle submit errors 2020-05-29 21:45:22 -03:00
fernandomg df0562911e hide EthValue if the method set does not require it 2020-05-29 21:44:40 -03:00
fernandomg 394a98b424 create form error component 2020-05-29 21:43:56 -03:00
fernandomg 4de3308069 extend TextField to support submit errors 2020-05-29 21:43:37 -03:00
fernandomg 8e75e999ef fix: transaction details 2020-05-29 14:25:24 -03:00
Mati Dastugue 7b0eb4cf7d Merge branch 'development' of github.com:gnosis/safe-react into fix/ledger 2020-05-29 12:22:41 -03:00
Agustín Longoni 4ddffaab76
Merge pull request #968 from gnosis/issue-964
(Fix) Flags css import
2020-05-29 08:32:10 -03:00
Agustin Pane 971b2ee6d3
(Fix) - Fixs tab selection (#960)
* Fixs tab selection

* Refactor balances tab to use react router
2020-05-29 08:07:32 -03:00
Mikhail Mikheev 710f6a5ab6
Merge pull request #966 from gnosis/fix-awaitingTransactions
Fix app crashing when safeTransactions is undefined
2020-05-29 14:50:17 +04:00
Mikhail Mikheev fda93a53c8 fix generateSafeTxHash typing 2020-05-29 14:00:20 +04:00
Agustín Longoni c0dbfa0dbb fix flags css import 2020-05-28 16:22:51 -03:00
fernandomg 498f9a4d1b Merge branch 'development' into 536-notifications-status-labels-sync
# Conflicts:
#	package.json
#	src/logic/contracts/generateBatchRequests.ts
#	src/logic/tokens/utils/tokenHelpers.ts
2020-05-28 13:51:19 -03:00
nicolas 4065d5a007
Allow to load Safe Apps with ENS names (#911)
* Remove ethereum-ens in favour of web3.eth.ens

* Allow load Apps from ENS names

* remove comment

* review changes

* replace REACT_APP_IPFS_NODE by REACT_APP_IPFS_GATEWAY

* review fixes

* TS Errors

* fix paths

* Fix validtor

* Apps: Move App form to a separate file

* re-build

* review changes

* fix iframeEl type

* remove validation

* fix type

* update web3 version

* remove type in getContentFromENS

Co-authored-by: lukasschor <lukas.schor@gnosis.pm>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-05-28 12:50:08 -03:00
Mati Dastugue 7a20aaac42
Merge pull request #935 from gnosis/fix/trezor-support
Add Trezor support
2020-05-28 12:23:13 -03:00
Agustin Pane 7a79579238 Revert initial fix
Add default transaction value for safes without outgoing transactions
2020-05-28 12:03:21 -03:00
Agustin Pane cf38e97907
(Feature) #416 - Add releases link (#936)
* - Add releases link

* - Adds border bottom

* Merge branch 'development' into 623-show-more

# Conflicts:
#	src/routes/safe/components/Transactions/TxsTable/ExpandedTx/TxDescription/index.tsx

* fix hooks import casing

* Improves css link

* Fix hooks import

* Fix hooks import

* Link styling

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-05-28 11:28:57 -03:00
Agustin Pane 2eeb9fc094
Fix icons on send and receive buttons (#962) 2020-05-28 07:33:37 -03:00
fernandomg 4e6741e1b9 fix: set proper transaction statuses 2020-05-28 01:07:05 -03:00
fernandomg 1453de1162 fix: avoid accessing `txHash` if it's not defined
This scenario can be reproduced by rejecting a tx in the owner's wallet
2020-05-28 01:03:08 -03:00
fernandomg aefe721e8f fix: owners column buttons statuses 2020-05-28 01:02:19 -03:00
Mati Dastugue bc2b6da5e4 Fix ledger issue 2020-05-27 21:11:52 -03:00
Mati Dastugue bf5a24d762 Fix merge 2020-05-27 21:08:20 -03:00
fernandomg a68a2d32d0 feature: calculate `safeTxHash` on client-side 2020-05-27 17:55:41 -03:00
fernandomg a5a99167f4 fix: set default values for decimals and symbol to ETH 2020-05-27 14:34:25 -03:00
fernandomg 62f1a82793 chore: fixes after merge 2020-05-27 13:37:51 -03:00
nicosampler afa1f92d3d Fix app crashing when safeTransactions is undefined 2020-05-27 13:17:11 -03:00
fernandomg 43acdfb95c Merge branch 'development' into 536-notifications-status-labels-sync
# Conflicts:
#	src/routes/safe/components/Balances/index.tsx
#	src/routes/safe/components/Transactions/TxsTable/index.tsx
#	src/routes/safe/container/hooks/useLoadSafe.tsx
#	src/routes/safe/container/index.tsx
#	src/routes/safe/store/actions/fetchTransactions.ts
#	src/routes/safe/store/actions/transactions/addOrUpdateTransactions.ts
#	src/routes/safe/store/middleware/notificationsMiddleware.ts
#	src/routes/safe/store/models/transaction.ts
#	src/routes/safe/store/reducer/transactions.ts
2020-05-27 13:12:09 -03:00
fernandomg 85b132de6b refactor: FetchTransactions.ts from class to module 2020-05-27 13:04:10 -03:00
fernandomg e08083743d refactor: fetch safe and tokens simultaneously 2020-05-27 10:13:28 -03:00
fernandomg 823fc40f7d refactor: simplify safe's fields selectors 2020-05-27 10:10:13 -03:00
fernandomg d0d19b0b3e refactor: use default values for immutable getters 2020-05-27 10:09:28 -03:00
fernandomg 7c2f27cf2d chore: clean file 2020-05-27 08:56:47 -03:00
fernandomg 3b94bc906c refactor: wrap `generateBatchRequest` into a more meaningful/descriptive funciton 2020-05-27 08:55:32 -03:00
fernandomg 6fb71d1ec4 chore: add types
Not sure right now how to properly deal with `d.ts` files. So, I decided to let those types that depend on others inside a module.
2020-05-27 08:55:30 -03:00
Agustin Pane de4d564955
(Feature) #554 - Safe creation tx details (#894)
* ChecksumAddresses when add new addressBook entry
ChecksumAddresses when add new owner
ChecksumAddresses when replaces owner

* Refactor expandedTx to show creation safe data

* Export CreationTx, IncomingTx and OutgoingTx render to components
Rename components

* Renames addMockSafeCreationTx to getCreationTx

* Avoid unnecessary fetch of creation tx after the first fetch

* - Loads creationTx once the safe loads
- Adds addOrUpdateTransactions.js
- Adds fetchSafeCreationTx.js
- Removes creationTx logic from fetchTransactions.js
- Updates notificationsMiddleware.js

* Fixs getAwaitingTransactions

* Remove creationTx selector

* Merge branch 'development' of https://github.com/gnosis/safe-react into 416-contract-version-improvements

# Conflicts:
#	src/routes/safe/components/Balances/index.tsx
#	src/routes/safe/container/index.tsx

* Merge branch 'development' of https://github.com/gnosis/safe-react into 416-contract-version-improvements

# Conflicts:
#	src/routes/safe/components/Balances/index.tsx
#	src/routes/safe/container/index.tsx

* Fix date column in safe creation

* Add copy and etherscanlinks to creation safe details

* Fix hooks import
2020-05-26 15:00:26 -03:00
fernandomg 1947f1c470 refactor: import web3ReadOnly as web3 2020-05-26 08:19:09 -03:00
fernandomg bce4cf60e0 fix: use selector for `cancellationTxs`.
This will prevent errors when there's no `cancellationTx` existent for the current safe as the selector defaults to an empty Map.
2020-05-26 08:17:20 -03:00
Mikhail Mikheev 5803ca0ea4 fix hooks import casing 2020-05-25 16:07:40 +04:00
Mikhail Mikheev 9e39b81f9c Merge branch 'development' of github.com:gnosis/safe-react into empty-space-validator 2020-05-25 16:01:12 +04:00
Mikhail Mikheev c8e9ef9a3a fix hooks import casing 2020-05-25 15:43:00 +04:00
fernandomg 9b257d901a fix: properly update txs status on safe's startup 2020-05-23 15:51:23 -03:00
fernandomg e9153c54d4 fix: wallet connection 2020-05-23 11:24:21 -03:00
Mikhail Mikheev fc89af57aa
Merge pull request #952 from gnosis/stepper-transparent-bg
Bug: Stepper component non-transparent bg
2020-05-23 12:10:24 +04:00
fernandomg 1742f84b86 fix: `Hooks` import 2020-05-23 03:08:58 -03:00
fernandomg bbf6d4a28d Merge branch 'development' into 536-notifications-status-labels-sync
# Conflicts:
#	src/routes/safe/container/index.tsx
2020-05-23 02:58:32 -03:00
fernandomg 00b1c7c3b0 chore: change hooks imports to relative paths 2020-05-23 02:53:14 -03:00
fernandomg 66b02b401d fix: update mocked tx status based on the tx receipt 2020-05-23 02:38:25 -03:00
fernandomg 46c9ac3e03 refactor: update tx status when provider changes 2020-05-23 02:09:21 -03:00
fernandomg 2c41105474 feature: set tx's owners pending status 2020-05-23 01:54:37 -03:00
fernandomg 165d0ff0d6 feature: add owner's _pending_ bullet icon 2020-05-22 23:49:22 -03:00
fernandomg 92ad62800e fix: typos and types 2020-05-22 23:48:24 -03:00
fernandomg 5a02cbfc9a fix: remove old `index.jsx` file 2020-05-22 17:19:35 -03:00
fernandomg 209d373516 fix: leave blank the default token for Send Funds modal 2020-05-22 17:05:27 -03:00
fernandomg 926795eef1 refactor: transactions table info and details 2020-05-22 16:50:24 -03:00
fernandomg 6c1bc100b6 refactor: allow adding mocked transactions 2020-05-22 16:50:17 -03:00
fernandomg 376af39f3c refactor: notifications middleware 2020-05-22 16:50:10 -03:00
fernandomg c9a01f6892 refactor: modify how transactions returned by server are processed 2020-05-22 16:49:59 -03:00
fernandomg 89261d0ed3 refactor: (cancellation)transactions reducers and actions 2020-05-22 16:49:48 -03:00