Commit Graph

2717 Commits

Author SHA1 Message Date
Mati Dastugue 4130902548
Merge pull request #1187 from gnosis/feature/cla-assistant
CLA assistant
2020-08-04 12:30:42 -03:00
Mikhail Mikheev 59cb58b14a allowlist adjustments 2020-08-04 15:34:18 +04:00
Mikhail Mikheev dcba16830c use gnosis version of github_action for debugging 2020-08-04 14:58:44 +04:00
Mikhail Mikheev 94156166d2 add comment about github token 2020-08-04 14:25:49 +04:00
Mikhail Mikheev b5d8784e83 adjust allowlist 2020-08-04 14:19:19 +04:00
Mikhail Mikheev 6e2e436041
Merge branch 'development' into feature/cla-assistant 2020-08-04 13:40:37 +04:00
Daniel Sanchez f374315a5a
Avoid constant creation of new web3 object (#1171)
* Avoid constant creation of new web3 object

* rollback web3 version, small type fixes in ConnectButton

* Use web3 instance in getProviderInfo

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-08-03 11:29:17 +02:00
Mati Dastugue 088b1e1d2a
Merge branch 'development' into feature/cla-assistant 2020-07-31 20:04:09 -03:00
Mikhail Mikheev 86cbd94b0c
Tech debt: Add types for contracts (#1118)
* typechain wip

* add types for multisend

* type definitions improvements

* type safe contract in estimateTxGasCosts

* contract type definitions wip

* SafeInstance truffle -> web3 migration

* fix calls for version

* transactions/send enhancements

* fix safe recor owner type

* Stepper type definitions wip

* dep bump

* stepper types wip

* refactoring stepper component to fix bug in load safe form

* stepper types wip, addressbook reducer types wip

* finally make it work

* Fix ownerlist component hook in load safe

* dep bump

* dep bump

* rollback types/history

* add types for gas calc

* debugging...

* fix using RO web3 for sending txs

* update package.json generate-types command

* add ts-ignore for stepperpage

* db

* dep bump

* as unknown as AbiItem -> as AbiItem[]

* use optional chaining for isExecution in gas esimations

* abiITem -> AbiItem[]

* fix safeVersion utils tests

* fix imports, put upgradeSafe test close to the actual code

* add comment about ts-ignore usage

* downgrade web3 version
2020-08-01 02:26:10 +04:00
Mikhail Mikheev 24dffd53da
Set inclusive false for minValue validator in sendfunds form (#1193) 2020-08-01 01:15:56 +04:00
Mati Dastugue 231a412fb8
Update branch 2020-07-31 13:38:18 -03:00
Mati Dastugue 1b71d5275e
Typo in username 2020-07-31 11:13:34 -03:00
Mati Dastugue 7fd1a813f4
Merge branch 'development' into feature/cla-assistant 2020-07-31 10:58:56 -03:00
nicolas 81c14133ac
Update MultiSend contract address. (#1186)
* Update Multisend Address

* Update Apps loaders not centered

* remove empty spaces

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-31 14:27:22 +04:00
Mikhail Mikheev cd7bbabd46
Merge branch 'development' into feature/cla-assistant 2020-07-31 13:21:25 +04:00
Mati Dastugue ab9de7dbda Add Gnosis CLA (#1188) 2020-07-31 13:20:57 +04:00
Mati Dastugue 86bee9587d
Delete GNOSISCLA.md 2020-07-30 21:45:01 -03:00
Mati Dastugue 6f1781af9f Merge branch 'development' of github.com:gnosis/safe-react into feature/cla-assistant 2020-07-30 19:56:11 -03:00
Mati Dastugue 9b7e279033 Add CLA assistant 2020-07-30 19:56:03 -03:00
nicolas 251da319a5
Fix: debounce fetch apps (#1021)
* Fix: debounce fetch apps

* refactor: fix AddAppForm name and add missing types

* add `use-lodash-debounce` hook to test debounce functionality

I'm planning to remove this dependency, as it requires to also install `lodash.debounce`. I prefer to implement it ad-hoc.

* refactor AddAppForm to use the observable pattern

* memoize `getAppInfoFromUrl` to prevent requesting the same information over and over

* prevent requesting data if url is not valid

* remove logging

* prevent validating form before visiting the fields

* refactor AddAppForm

reorganize code

* fix: change `any` to `unknown`

* fix: `uitls.ts` types and imports

* refactor: rename `isSubmitDisabled` to `onSubmitButtonStatusChange` prop

* refactor: rename `agreement` to `agreementAccepted`

also, moved `initialValues` to a constant `INITIAL_VALUES` outside the component

* refactor: reimplement `useDebounce` hook in-app

* refactor: extract app manifest verification to a helper function

also fixed types

* fix: prevent accessing `contentWindow` if `iframe` is `null`

* fix: `getAppInfoFromOrigin` return type

also, removed the expected type for the `getAppInfoFromOrigin` calls as it is inferred

Co-authored-by: fernandomg <fernando.greco@gmail.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-30 18:28:30 +04:00
Mikhail Mikheev e80b4574bf
Merge pull request #1172 from gnosis/dev-master-backmerge
Dev <- master v2.8.1 Backmerge
2020-07-29 18:23:29 +04:00
Mikhail 1f0117ae6e Merge branch 'master' of github.com:gnosis/safe-react into dev-master-backmerge 2020-07-29 18:02:27 +04:00
Daniel Sanchez 89c17180de
Trim spaces from AddressInput (#1142)
* Remove spaces

* Change naming convention to make clear that only edge whitespaces are removed

Fix function documentation in string util

* Add trim spaces from address input in AddToken and AddAsset

* Use validator type

* Trim spaces on Safe App links

Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-29 17:28:43 +04:00
Agustin Pane bbfa7d8166
(Feature) Balances enhancements (#1122)
* Fix ts error
Add type return on fetchCurrencyValues

* Add skeleton for loading balance value

* Fix texts in uppercase

* Adds ETH Icon in currencyValues dropdown

* Adds getExchangeRatesUrlFallback
Adds support for ETH as currency

* Alphabetically sort currencies

* Add types

* Type formatAmount

* Adds formatAmountInUsFormat util function

* Add types
Uses formatAmountInUsFormat for BALANCE_TABLE_BALANCE_ID

* Updates max and min fraction digits on formatAmountInUsFormat
Add tests

* Updates max and min fraction digits on formatAmountInUsFormat
Add tests

* Add types

* Fix currencyValues types

* Adds safeFiatBalancesTotalSelector

* Adds total balance to safe header

* Fix types

* Adds currentCurrency on header

* Adds types to getTokenPriceInCurrency

* Fix balance currency rate conversion

* Add guards for modules

* Add guards for modules

* Uses console error for api

* Remove anys

* Redefine CurrencyRateValue types into CurrencyRateValueRecord

* Redefine test texts

* Use absolute imports

* Add types to dispatch

* Add guard for no balance value

* Fix ESLINT warning

* Add types

* Fix no balance case

* Use optional chaining

* Absolute paths

* Adds return types
Uses BigNumber in safeFiatBalancesTotalSelector

* Remove number as type for formatAmountInUsFormat

* Uses createStyles to remove any types

* Improve total balances display

* Fix balances value column

* formatAmountInUsFormat feedback

* Force boolean evaluation

* Fix totalBalance heading styles

* Add types

* Add types to fetchTokenCurrenciesBalances endpoint

* Replaces coinbase dependency by backend for ETH price in USD

* Absolute paths

* Replaces RecordOf<TokenProps> with Token

* Feedback

* Trigger buid

* Types

* Fix tests order

* Renames numberFormat to usNumberFormatter

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-28 19:29:26 +04:00
Mikhail Mikheev 2672028b41
Merge pull request #1168 from gnosis/desktop-ci-fix
bring back network concurrency param
2020-07-28 19:27:01 +04:00
Mikhail bfcbdd4b93 bring back network concurrency param 2020-07-28 19:11:32 +04:00
Mikhail Mikheev 4977345a4d
Merge pull request #1166 from gnosis/hotfix/v2.8.1
Hotfix/v2.8.1
2020-07-28 19:04:50 +04:00
Mikhail Mikheev 769cbf321b
Merge pull request #1167 from gnosis/bugfix/fix-ci
Hotfix/CI
2020-07-28 18:46:05 +04:00
Mati Dastugue c494a26b82
Update release.yml 2020-07-28 11:44:19 -03:00
Mati Dastugue f915a0cc1f Add env variable for safe apps 2020-07-28 11:39:15 -03:00
Mikhail 0f5d942779 v2.8.1 2020-07-28 18:36:44 +04:00
Mikhail 08552fbe23 downgrade web3 version 2020-07-28 18:36:33 +04:00
Mikhail Mikheev 10b10e6abb
Merge pull request #1165 from gnosis/release/v2.8.0
Release: v2.8.0
2020-07-28 16:59:54 +04:00
Mikhail cd81e2ce35 2.8.0 2020-07-28 16:40:43 +04:00
Fernando 787e6ff711 (Fix) Prevent accessing `contentWindow` if `iframe` is `null` (#1161) 2020-07-28 16:40:13 +04:00
Germán Martínez cfefe69a59 Safe apps can request the Safe info (#1138)
* Request Safe info from Safe apps

* Update dependencies

* Update yarn.lock file

* remove usecallback

* Rename initialization messageId from safe-apps-sdk

* Fix openOnFocus on AddressBookInput

* Fix yarn.lock file

* Rollback @material-ui/lab to avoid type errors

* dep bump

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-28 16:40:05 +04:00
Mati Dastugue fedbac9e66 Fix CI on github action desktop build (#1159)
* Prevent failed CI if there is any warning

* Update regex

* Eslint error

Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
2020-07-28 16:39:55 +04:00
Mati Dastugue 8a6b219781
Fix - Owners list error (#1127)
* Add validation for addressBooj

* Fix types

* Update default value

* Update src/logic/addressBook/utils/index.ts

Co-authored-by: Fernando <fernando.greco@gmail.com>

Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
Co-authored-by: Fernando <fernando.greco@gmail.com>
2020-07-28 15:25:26 +04:00
Mati Dastugue 91a85ae9ea
Fix Wrong Wallet Network Label (#1163)
* Fix network label

* rename component

* use interfaceNetwork as a default parameter

Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Mikhail <mmvsha73@gmail.com>
2020-07-28 11:54:19 +04:00
Mati Dastugue 8091a9dc77
Fix CI on github action desktop build (#1159)
* Prevent failed CI if there is any warning

* Update regex

* Eslint error

Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
2020-07-28 02:04:52 +04:00
Mikhail Mikheev f62bbffdd3
Tech Debt: Validator Type definitions (#1108)
* type validators

* safeSelector types

* history 5.0.0 breaking changes adaptation

* replace simpleMemoize with memoize from lodash because of typing issues

* add type definitions for history and react-router-dom

* type fixes

* yarn lock update

* fix router state

* more type improvements

* validator tests wip

* add tests for validators, remove duplicated validators

* add error messages to tests

* fix minValue error message for inclusive param

* Replace jsx.element with react.reactelement

* Fix uniqueAddress validator argument type

* remove comment in AddCustomToken validator

* use absolute import for saferecord in safe paage container
2020-07-27 14:31:13 +04:00
Agustín Longoni 93448b550a
fix modal position at top (#1160)
Co-authored-by: Fernando <fernando.greco@gmail.com>
2020-07-27 13:55:53 +04:00
Fernando fc20ce5775
(Fix) Prevent accessing `contentWindow` if `iframe` is `null` (#1161) 2020-07-24 17:46:11 -03:00
nicolas 0b25094b95
Set timeout to Safe-Apps fetch (#1158)
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-24 18:36:41 +04:00
Germán Martínez 253639d009
Safe apps can request the Safe info (#1138)
* Request Safe info from Safe apps

* Update dependencies

* Update yarn.lock file

* remove usecallback

* Rename initialization messageId from safe-apps-sdk

* Fix openOnFocus on AddressBookInput

* Fix yarn.lock file

* Rollback @material-ui/lab to avoid type errors

* dep bump

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>
2020-07-24 17:56:24 +04:00
Daniel Sanchez 90a8b3f630
Merge pull request #1156 from gnosis/development
v2.7.2 development -> master
2020-07-24 12:01:37 +02:00
Mikhail Mikheev 1ed5d3ace9 Merge branch 'master' of github.com:gnosis/safe-react into development 2020-07-24 13:36:08 +04:00
Daniel Sanchez e539f6c277
Merge pull request #1155 from gnosis/set-version-2.7.2
Set v2.7.2
2020-07-24 10:40:27 +02:00
Daniel Sanchez c73c6394ce
Merge branch 'development' into set-version-2.7.2 2020-07-24 10:27:53 +02:00
Daniel Sanchez 51912b956e 2.7.2 2020-07-24 10:21:31 +02:00