pr feedback, changelog

This commit is contained in:
Ari Lazier 2016-04-12 08:13:29 -07:00
parent c874c15e75
commit 3e34d2355f
1 changed files with 1 additions and 1 deletions

View File

@ -462,6 +462,7 @@ void do_add_null_comparison_to_query<Link>(Query &query, Predicate::Operator op,
precondition(expr.indexes.empty(), "KeyPath queries not supported for object comparisons."); precondition(expr.indexes.empty(), "KeyPath queries not supported for object comparisons.");
switch (op) { switch (op) {
case Predicate::Operator::NotEqual: case Predicate::Operator::NotEqual:
// for not equal we negate the query and then fallthrough
query.Not(); query.Not();
case Predicate::Operator::Equal: case Predicate::Operator::Equal:
query.and_query(query.get_table()->column<Link>(expr.prop->table_column).is_null()); query.and_query(query.get_table()->column<Link>(expr.prop->table_column).is_null());
@ -471,7 +472,6 @@ void do_add_null_comparison_to_query<Link>(Query &query, Predicate::Operator op,
} }
} }
void do_add_null_comparison_to_query(Query &query, const Schema &schema, const ObjectSchema &object_schema, Predicate::Comparison cmp, void do_add_null_comparison_to_query(Query &query, const Schema &schema, const ObjectSchema &object_schema, Predicate::Comparison cmp,
const PropertyExpression &expr, Arguments &args) const PropertyExpression &expr, Arguments &args)
{ {