mirror of
https://github.com/status-im/react-native.git
synced 2025-01-09 09:12:02 +00:00
97cfacb5ba
Summary: This moves the Template files to the .github folder. This helps clear up the extra files in the root of the directory. This is my first PR 😄 and I plan to contribute more to this awesome project. Closes https://github.com/facebook/react-native/pull/7854 Differential Revision: D3424679 fbshipit-source-id: 2baca0bb4182eb6d803836e10a5434d980e7d0c3
19 lines
1.8 KiB
Markdown
19 lines
1.8 KiB
Markdown
## Tips on reviewing pull requests
|
|
|
|
Does the PR miss info required in the [Pull request template](https://github.com/facebook/react-native/blob/master/.github/PULL_REQUEST_TEMPLATE.md)? Example: [#6395](https://github.com/facebook/react-native/pull/6395). Add labels 'Needs revision' and 'Needs response from author'. Add a response like:
|
|
|
|
> Hey @author, thanks for sending the pull request.
|
|
> Can you please add all the info specified in the [template](https://github.com/facebook/react-native/blob/master/.github/PULL_REQUEST_TEMPLATE.md)? This is necessary for people to be able to understand and review your pull request.
|
|
|
|
Does the code style match the [Style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide), especially consistency (formatting, naming) with the rest of the codebase? If not, link to the style guide and add the label 'Needs revision'.
|
|
|
|
Does the pull request add a completely new feature we don't want to add to the core and maintain? Ask the author to release it a separate npm module and close the PR. Example: [#2648](https://github.com/facebook/react-native/pull/2648).
|
|
|
|
Does the pull request do several unrelated things at the same time? Ask the author to split it.
|
|
|
|
Is the PR old and need rebasing? Ask the author "Can you rebase please?" and add the label "Needs response from author".
|
|
|
|
Is a PR waiting for a response from author (usually has label "Needs response from author") and there's no reply in last 30 days? Close it with the [bookmarklet](https://github.com/facebook/react-native/blob/master/bots/pr-inactivity-bookmarklet.js). Examples: [#3066](https://github.com/facebook/react-native/pull/3066), [#1099](https://github.com/facebook/react-native/pull/1099).
|
|
|
|
Is the PR old and waiting for review? Review it or cc someone who might be able to review.
|