mirror of
https://github.com/status-im/react-native.git
synced 2025-01-17 04:50:59 +00:00
c47759a9ae
Summary: Fixes potential retain cycles detected by an internal fb tool. ``` First: __NSDictionaryM -> RCTPropsAnimatedNode -> _parentNodes -> __NSDictionaryM -> RCTStyleAnimatedNode -> _childNodes -> __NSDictionaryM Second: RCTScrollView -> _eventDispatcher -> RCTEventDispatcher -> _observers -> __NSArrayM -> RCTNativeAnimatedModule -> _nodesManager -> RCTNativeAnimatedNodesManager -> _uiManager -> RCTUIManager -> _viewRegistry -> __NSDictionaryM -> RCTScrollView ``` First fix: Use weak map for parent and child nodes, strong refs are managed by RCTNativeAnimatedNodesManager Second fix: Make RCTEventDispatcher observers a weak array and make sure we don't keep strong refs to UIManager in RCTNativeAnimatedNodesManager and RCTPropsAnimatedNode. Tested that native animations still work in UIExplorer [IOS] [BUGFIX] [NativeAnimated] - Fix potential retain cycles in Animated iOS Closes https://github.com/facebook/react-native/pull/16506 Differential Revision: D6126400 Pulled By: shergin fbshipit-source-id: 1ac5083f8ab79a806305edc23ae4796ed428f78b
49 lines
1.5 KiB
Objective-C
49 lines
1.5 KiB
Objective-C
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#import <Foundation/Foundation.h>
|
|
|
|
@interface RCTAnimatedNode : NSObject
|
|
|
|
- (instancetype)initWithTag:(NSNumber *)tag
|
|
config:(NSDictionary<NSString *, id> *)config NS_DESIGNATED_INITIALIZER;
|
|
|
|
@property (nonatomic, readonly) NSNumber *nodeTag;
|
|
@property (nonatomic, copy, readonly) NSDictionary<NSString *, id> *config;
|
|
|
|
@property (nonatomic, copy, readonly) NSMapTable<NSNumber *, RCTAnimatedNode *> *childNodes;
|
|
@property (nonatomic, copy, readonly) NSMapTable<NSNumber *, RCTAnimatedNode *> *parentNodes;
|
|
|
|
@property (nonatomic, readonly) BOOL needsUpdate;
|
|
|
|
/**
|
|
* Marks a node and its children as needing update.
|
|
*/
|
|
- (void)setNeedsUpdate NS_REQUIRES_SUPER;
|
|
|
|
/**
|
|
* The node will update its value if necesarry and only after its parents have updated.
|
|
*/
|
|
- (void)updateNodeIfNecessary NS_REQUIRES_SUPER;
|
|
|
|
/**
|
|
* Where the actual update code lives. Called internally from updateNodeIfNecessary
|
|
*/
|
|
- (void)performUpdate NS_REQUIRES_SUPER;
|
|
|
|
- (void)addChild:(RCTAnimatedNode *)child NS_REQUIRES_SUPER;
|
|
- (void)removeChild:(RCTAnimatedNode *)child NS_REQUIRES_SUPER;
|
|
|
|
- (void)onAttachedToNode:(RCTAnimatedNode *)parent NS_REQUIRES_SUPER;
|
|
- (void)onDetachedFromNode:(RCTAnimatedNode *)parent NS_REQUIRES_SUPER;
|
|
|
|
- (void)detachNode NS_REQUIRES_SUPER;
|
|
|
|
@end
|