Janic Duplessis c47759a9ae Fix potential retain cycles in Animated iOS ...

Summary:
Fixes potential retain cycles detected by an internal fb tool.

```
First:

__NSDictionaryM
-> RCTPropsAnimatedNode
-> _parentNodes -> __NSDictionaryM
-> RCTStyleAnimatedNode
-> _childNodes -> __NSDictionaryM

Second:

RCTScrollView
-> _eventDispatcher -> RCTEventDispatcher
-> _observers -> __NSArrayM
-> RCTNativeAnimatedModule
-> _nodesManager -> RCTNativeAnimatedNodesManager
-> _uiManager -> RCTUIManager
-> _viewRegistry -> __NSDictionaryM
-> RCTScrollView
```

First fix:
Use weak map for parent and child nodes, strong refs are managed by RCTNativeAnimatedNodesManager

Second fix:
Make RCTEventDispatcher observers a weak array and make sure we don't keep strong refs to UIManager in RCTNativeAnimatedNodesManager and RCTPropsAnimatedNode.

Tested that native animations still work in UIExplorer

[IOS] [BUGFIX] [NativeAnimated] - Fix potential retain cycles in Animated iOS
Closes https://github.com/facebook/react-native/pull/16506

Differential Revision: D6126400

Pulled By: shergin

fbshipit-source-id: 1ac5083f8ab79a806305edc23ae4796ed428f78b

2017-10-23 13:20:59 -07:00

..

ActionSheetIOS

Add minimal example to actionsheet

2017-10-10 03:32:08 -07:00

Alert

support null titles in AlertIOS

2017-09-11 16:08:03 -07:00

Animated

Update Animated docs to mention potential issues with VirtualizedList

2017-10-13 17:50:17 -07:00

AppState

Avoid race condition for AppState.currentState

2017-08-18 13:14:59 -07:00

ART

Fix format warnings for clang 5.0

2017-09-25 10:30:53 -07:00

BatchedBridge

Improve flow typing and linting for MessageQueue

2017-10-10 16:32:28 -07:00

Blob

@allow-large-files Flow v0.54.0

2017-09-06 03:33:43 -07:00

BugReporting

Patch up for future React Sync

2017-02-08 14:50:43 -08:00

CameraRoll

Fix crash when trying to load photo library assets with nil image url

2017-09-14 12:02:27 -07:00

Components

Fix Flow errors at declaration of most major library components

2017-10-20 03:50:25 -07:00

Core

Fix test suite when running on a feature branch

2017-10-19 13:53:27 -07:00

EventEmitter

RN: Improve NativeEventEmitter Flow Types

2017-10-13 08:04:17 -07:00

Experimental

Add SwipeableFlatList

2017-09-28 22:16:08 -07:00

fishhook

Merge fishhook.xcodeproj in RCTWebSocket

2017-08-09 07:48:09 -07:00

Geolocation

@allow-large-files Flow v0.54.0

2017-09-06 03:33:43 -07:00

Image

Fix Flow errors at declaration of most major library components

2017-10-20 03:50:25 -07:00

Inspector

@allow-large-files Flow v0.54.0

2017-09-06 03:33:43 -07:00

Interaction

Improve flow typing and linting for MessageQueue

2017-10-10 16:32:28 -07:00

JSInspector

Add Network agent

2016-11-02 12:29:15 -07:00

LayoutAnimation

@allow-large-files Flow v0.54.0

2017-09-06 03:33:43 -07:00

Linking

fix flow warning and typo

2017-09-08 14:46:14 -07:00

LinkingIOS

Standardize project indentation settings on 2 spaces

2017-07-31 05:20:03 -07:00

Lists

VirtualizedList: fix bug where onViewableItemsChanged wouldn't trigger

2017-10-16 04:35:05 -07:00

Modal

Add onDismiss to Modal.js

2017-09-21 15:01:52 -07:00

NativeAnimation

Fix potential retain cycles in Animated iOS

2017-10-23 13:20:59 -07:00

Network

Update the NetInfo.isConnected example code so that it uses the new connectionChange event

2017-10-13 18:02:06 -07:00

Performance

Gate more code with if (__DEV__) { }

2017-08-14 07:19:00 -07:00

PermissionsAndroid

Update documentation for PermissionsAndroid

2017-08-16 15:01:51 -07:00

polyfills

Use proper script way to clone Emoji files from www

2017-08-21 16:29:39 -07:00

PushNotificationIOS

Fix flowtype errors for PushNotificationIOS

2017-08-14 12:03:18 -07:00

RCTTest

Improve DX for FBReactKitIntegrationTests

2017-09-21 18:30:38 -07:00

react-native

Add SwipeableFlatList

2017-09-28 22:16:08 -07:00

ReactNative

Implement gating support for direction-aware API changes

2017-10-18 19:33:31 -07:00

Renderer

React sync for revisions b5ac963...5f93ee6f6

2017-10-04 10:16:15 -07:00

Sample

Standardize project indentation settings on 2 spaces

2017-07-31 05:20:03 -07:00

Settings

Fix infinite recursion in RCTSettingsManager init

2017-08-09 09:39:40 -07:00

Share

"subject" field for Share

2017-10-23 11:32:44 -07:00

Storage

correctly order ASyncStorage

2017-02-21 15:18:40 -08:00

StyleSheet

Fix Flow errors at declaration of most major library components

2017-10-20 03:50:25 -07:00

Text

Fix Flow errors at declaration of most major library components

2017-10-20 03:50:25 -07:00

Utilities

Remove usage of the ... operator in BackHandler

2017-10-20 18:02:14 -07:00

vendor

@allow-large-files Flow v0.54.0

2017-09-06 03:33:43 -07:00

Vibration

Run eslint --fix

2017-10-09 17:46:44 -07:00

WebSocket

remove RCTWebSocketObserver

2017-10-04 19:17:07 -07:00

Wrapper

Opensourcing RCTWrapper

2017-10-09 17:22:35 -07:00

.eslintrc

Disallow trailing commas in react-native-github

2017-08-17 16:20:04 -07:00

Promise.js

@allow-large-files Flow v0.54.0

2017-09-06 03:33:43 -07:00

promiseRejectionIsError.js

@allow-large-files Flow v0.54.0

2017-09-06 03:33:43 -07:00