react-native/Libraries/Text
Martín Bigio bbc6139baf Reverted commit D3348218
Summary:
The TextInput when configured with `multiline=true` has a minor issue due to which if the initial text doesn't fit in one line, the input won't span multiple lines. The root cause of the problem is that the `onChange` event is not fired for the initial render. This issue has been reported on open-source: 481f560f64

This is an attempt to fix this problem by moving the logic to fire the event to the method that updates the content size. This way we can guarantee that anytime the content size changes we'll trigger the JS event.

The downside of this approach is that it's possible that multiple events get fired for a single character change. As per the comment that was removed, this was already happening when adding a character that when rendered, would increase the content size. By moving the code to the new place, this can happen more often (twice per character tapped). Let me know if you think this is an issue.

I don't know this code much, so please be careful reviewing. I'm happy to add more test cases I may have missed to the test plan :).

Reviewed By: nicklockwood

Differential Revision: D3348218

fbshipit-source-id: 6b457624c9126e771c326eac61cd1cdd6496671d
2016-06-01 13:38:33 -07:00
..
RCTText.xcodeproj Text highlighting on iOS 2015-07-24 08:41:58 -08:00
RCTRawTextManager.h [ReactNative] Expanded license on obj-c files 2015-03-23 13:18:29 -08:00
RCTRawTextManager.m Convert alloc/init to new to please linter 2015-08-17 08:46:00 -07:00
RCTShadowRawText.h [ReactNative] Expanded license on obj-c files 2015-03-23 13:18:29 -08:00
RCTShadowRawText.m Fix Groups text input 2015-11-04 04:09:27 -08:00
RCTShadowText.h backout (and remove) props.lineBreakMode from Text 2016-03-17 11:48:24 -07:00
RCTShadowText.m iOS: Enable views to be nested within <Text> 2016-05-31 10:28:25 -07:00
RCTText.h Fixed crash in RCTText due to NSTextContainer/NSLayoutManager being accessed concurrently from main and shadow queues 2015-05-26 18:52:46 -08:00
RCTText.m iOS: Enable views to be nested within <Text> 2016-05-31 10:28:25 -07:00
RCTTextField.h Open sourced the onSelectionChange event 2015-11-14 09:44:30 -08:00
RCTTextField.m Maintain cursor position when TextInput value is changed programmatically 2015-12-17 10:23:26 -08:00
RCTTextFieldManager.h Migrated RCTText into FBReactKit 2015-07-08 07:13:00 -08:00
RCTTextFieldManager.m Add support for selectionColor on Android TextInput 2016-02-03 05:49:32 -08:00
RCTTextManager.h Add support for multiline TextInput via UITextView 2015-04-29 01:33:58 -08:00
RCTTextManager.m iOS: Enable views to be nested within <Text> 2016-05-31 10:28:25 -07:00
RCTTextView.h Updated AppState module to use new emitter system 2016-05-23 09:13:37 -07:00
RCTTextView.m Reverted commit D3348218 2016-06-01 13:38:33 -07:00
RCTTextViewManager.h Add support for multiline TextInput via UITextView 2015-04-29 01:33:58 -08:00
RCTTextViewManager.m Fixed multiline textinput onChange event 2016-05-25 06:13:25 -07:00
Text.js explicit type args in react-native-github 2016-05-24 18:28:26 -07:00
TextStylePropTypes.js Fallback for textAlign: justify 2016-04-24 11:29:23 -07:00
TextUpdateTest.js Fix up this pattern var React = require('react-native'); 2016-04-08 20:37:22 -07:00