react-native/Libraries
Martín Bigio bbc6139baf Reverted commit D3348218
Summary:
The TextInput when configured with `multiline=true` has a minor issue due to which if the initial text doesn't fit in one line, the input won't span multiple lines. The root cause of the problem is that the `onChange` event is not fired for the initial render. This issue has been reported on open-source: 481f560f64

This is an attempt to fix this problem by moving the logic to fire the event to the method that updates the content size. This way we can guarantee that anytime the content size changes we'll trigger the JS event.

The downside of this approach is that it's possible that multiple events get fired for a single character change. As per the comment that was removed, this was already happening when adding a character that when rendered, would increase the content size. By moving the code to the new place, this can happen more often (twice per character tapped). Let me know if you think this is an issue.

I don't know this code much, so please be careful reviewing. I'm happy to add more test cases I may have missed to the test plan :).

Reviewed By: nicklockwood

Differential Revision: D3348218

fbshipit-source-id: 6b457624c9126e771c326eac61cd1cdd6496671d
2016-06-01 13:38:33 -07:00
..
ART Check if either array is null before diffing 2016-04-25 13:28:31 -07:00
ActionSheetIOS ActionSheetIOS - support share sheet on modals 2016-05-20 17:13:21 -07:00
AdSupport Text highlighting on iOS 2015-07-24 08:41:58 -08:00
Animated Round alpha channel when interpolating colors to the nearest thousandth. 2016-05-17 10:13:29 -07:00
AppRegistry Refactor BugReporing to avoid multiple registers 2016-05-18 14:28:26 -07:00
AppState Updated AppState module to use new emitter system 2016-05-23 09:13:37 -07:00
BatchedBridge Memoize lazy module configs 2016-05-16 03:58:23 -07:00
BugReporting Make BugReporting not pull in native module on require 2016-05-19 12:58:21 -07:00
CameraRoll iOS: Support HTTP headers for source prop on <Image> components 2016-06-01 10:43:28 -07:00
Components Native propTypes RCTDatePickerIOS !== propTypes DatePickerIOS 2016-06-01 08:58:22 -07:00
CustomComponents Deploy v0.26.0 2016-05-27 17:58:32 -07:00
DebugComponentHierarchy Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
Devtools Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
EventEmitter Add a removeListener method to DeviceEventEmitter for Framework consi… 2016-05-24 11:45:51 -07:00
Experimental Disable right-swipe from closed position 2016-05-31 16:28:22 -07:00
Fetch Reject promise if network request failed 2016-03-08 16:37:24 -08:00
Geolocation Update RCTNetworking, RCTNetInfo and RCTLocationManager to use new events system 2016-05-25 04:28:36 -07:00
Image iOS: Support HTTP headers for source prop on <Image> components 2016-06-01 10:43:28 -07:00
Inspector Improve how inspector handles native components 2016-05-26 10:58:30 -07:00
Interaction explicit type args in react-native-github 2016-05-24 18:28:26 -07:00
JavaScriptAppEngine Set up Systrace during initialization 2016-05-24 12:13:24 -07:00
LayoutAnimation Add support for delete animation in LayoutAnimation on iOS 2016-04-25 00:19:25 -07:00
Linking Documentation typo – missing word 2016-06-01 00:58:29 -07:00
LinkingIOS Updated Linking and PushNotificationIOS modules to use NativeEventEmitter 2016-05-27 10:28:23 -07:00
Modal explicit type args in react-native-github 2016-05-24 18:28:26 -07:00
NavigationExperimental Clean up examples. 2016-05-31 11:43:29 -07:00
Network Fixed "Sending `didSendNetworkData` with no listeners registered" warning 2016-06-01 06:28:22 -07:00
PushNotificationIOS Updated Linking and PushNotificationIOS modules to use NativeEventEmitter 2016-05-27 10:28:23 -07:00
QuickPerformanceLogger added QPL for main interactions 2015-09-29 22:25:23 -07:00
RCTTest Updated AppState module to use new emitter system 2016-05-23 09:13:37 -07:00
RKBackendNode Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
ReactIOS Native propTypes RCTDatePickerIOS !== propTypes DatePickerIOS 2016-06-01 08:58:22 -07:00
ReactNative Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
Sample Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
Settings Updated AppState module to use new emitter system 2016-05-23 09:13:37 -07:00
Storage change undeclared variable to intended value 2016-05-26 01:43:30 -07:00
StyleSheet Deprecate transformMatrix and decomposedMatrix 2016-04-29 14:19:25 -07:00
Text Reverted commit D3348218 2016-06-01 13:38:33 -07:00
Utilities Optimize and flowify mapWithSeparator 2016-05-26 12:28:55 -07:00
Vibration Add support for vibration patterns 2016-03-29 21:45:20 -07:00
WebSocket Updated Websocket to use new event system 2016-05-12 08:30:24 -07:00
react-native Cross platform ActivityIndicator 2016-05-26 13:58:17 -07:00
vendor Fixed NativeEventListener deregistration 2016-05-16 04:13:56 -07:00
Promise.js Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
promiseRejectionIsError.js Add possibility to `console.error`/redbox on promise rejections 2016-03-15 05:22:22 -07:00