Reviewed By: mkonicek Differential Revision:D3074972 Ninja: oss only fb-gh-sync-id: 0f244c80851d14fddd0a37e5357b5a00224aa97d shipit-source-id: 0f244c80851d14fddd0a37e5357b5a00224aa97d
874 B
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:
(You can skip this if you're fixing a typo or adding an app to the Showcase.)
Explain the motivation for making this change. What existing problem does the pull request solve?
Prefer small pull requests. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Make sure tests pass on both Travis and Circle CI.
Code formatting
Look around. Match the style of the rest of the codebase. See also the simple style guide.