mirror of
https://github.com/status-im/react-native.git
synced 2025-02-06 22:54:27 +00:00
52b4ae179c
Summary: Make it more obvious that pull requests should generally target the `master` branch. Provide visible clarity in both the `CONTRIBUTING.md` and the actual pull request template. Closes https://github.com/facebook/react-native/pull/8748 Differential Revision: D3566827 fbshipit-source-id: 6326f18b93594e928b1c4e0d09a739a8ccedaa62
22 lines
1.2 KiB
Markdown
22 lines
1.2 KiB
Markdown
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:
|
|
|
|
> **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.**
|
|
|
|
(You can skip this if you're fixing a typo or adding an app to the Showcase.)
|
|
|
|
Explain the **motivation** for making this change. What existing problem does the pull request solve?
|
|
|
|
Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
|
|
|
|
**Test plan (required)**
|
|
|
|
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
|
|
|
|
Make sure tests pass on both Travis and Circle CI.
|
|
|
|
**Code formatting**
|
|
|
|
Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide).
|
|
|
|
For more info, see the ["Pull Requests" section of our "Contributing" guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests).
|