status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries/Text
History
Nick Lockwood 362738a776 Fixed some issues with zero fontSizeMultiplier causing RCTSHadowText measure function to return an infinite height 
Summary:The default value for fontSizeMultiplier was zero. Although this was usually overriden with the correct value (typically 1.0), it sometimes wasn't resulting in a divide-by-zero in the text height calculation.

This diff corrects that bug by setting 1.0 as the default, and guarding against zero values being set.

I also fixed some suspicious logic that seemed to assume the result of BOOL && CGFloat would be 0 or the CGFloat value, which is true in JS but not in C (it would always be 0 or 1).

Reviewed By: javache

Differential Revision: D3179196

fb-gh-sync-id: cc09b104c9087fc1a2f45d8d3f70af221c2ad823
fbshipit-source-id: cc09b104c9087fc1a2f45d8d3f70af221c2ad823
 		2016-04-21 03:57:18 -07:00
..
RCTText.xcodeproj Text highlighting on iOS 2015-07-24 08:41:58 -08:00
RCTRawTextManager.h [ReactNative] Expanded license on obj-c files 2015-03-23 13:18:29 -08:00
RCTRawTextManager.m Convert alloc/init to new to please linter 2015-08-17 08:46:00 -07:00
RCTShadowRawText.h [ReactNative] Expanded license on obj-c files 2015-03-23 13:18:29 -08:00
RCTShadowRawText.m Fix Groups text input 2015-11-04 04:09:27 -08:00
RCTShadowText.h backout (and remove) props.lineBreakMode from Text 2016-03-17 11:48:24 -07:00
RCTShadowText.m Fixed some issues with zero fontSizeMultiplier causing RCTSHadowText measure function to return an infinite height 2016-04-21 03:57:18 -07:00
RCTText.h Fixed crash in RCTText due to NSTextContainer/NSLayoutManager being accessed concurrently from main and shadow queues 2015-05-26 18:52:46 -08:00
RCTText.m TextStorage in RCTText is now only set when it differs from old value. 2016-03-10 07:46:52 -08:00
RCTTextField.h Open sourced the onSelectionChange event 2015-11-14 09:44:30 -08:00
RCTTextField.m Maintain cursor position when TextInput value is changed programmatically 2015-12-17 10:23:26 -08:00
RCTTextFieldManager.h Migrated RCTText into FBReactKit 2015-07-08 07:13:00 -08:00
RCTTextFieldManager.m Add support for selectionColor on Android TextInput 2016-02-03 05:49:32 -08:00
RCTTextManager.h Add support for multiline TextInput via UITextView 2015-04-29 01:33:58 -08:00
RCTTextManager.m Fixed some issues with zero fontSizeMultiplier causing RCTSHadowText measure function to return an infinite height 2016-04-21 03:57:18 -07:00
RCTTextView.h Added blurOnSubmit support to multine TextInput (aka RCTTextView) 2015-12-02 08:16:27 -08:00
RCTTextView.m CHORE - Remove Trailing Spaces 2016-04-06 09:21:53 -07:00
RCTTextViewManager.h Add support for multiline TextInput via UITextView 2015-04-29 01:33:58 -08:00
RCTTextViewManager.m Add support for `textAlign` on iOS multiline text input 2016-02-07 12:38:36 -08:00
Text.js Improve touchable debugging 2016-04-14 14:28:31 -07:00
TextStylePropTypes.js Added support for textDecorationLine style prop on Android 2016-04-12 03:37:34 -07:00
TextUpdateTest.js Fix up this pattern var React = require('react-native'); 2016-04-08 20:37:22 -07:00