status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries
History
Nick Lockwood 362738a776 Fixed some issues with zero fontSizeMultiplier causing RCTSHadowText measure function to return an infinite height 
Summary:The default value for fontSizeMultiplier was zero. Although this was usually overriden with the correct value (typically 1.0), it sometimes wasn't resulting in a divide-by-zero in the text height calculation.

This diff corrects that bug by setting 1.0 as the default, and guarding against zero values being set.

I also fixed some suspicious logic that seemed to assume the result of BOOL && CGFloat would be 0 or the CGFloat value, which is true in JS but not in C (it would always be 0 or 1).

Reviewed By: javache

Differential Revision: D3179196

fb-gh-sync-id: cc09b104c9087fc1a2f45d8d3f70af221c2ad823
fbshipit-source-id: cc09b104c9087fc1a2f45d8d3f70af221c2ad823
 		2016-04-21 03:57:18 -07:00
..
ART Update the Spectrum downstream and add the new cloneWithProps dependency 2016-04-13 17:11:38 -07:00
ActionSheetIOS CHORE - Remove Trailing Spaces 2016-04-06 09:21:53 -07:00
AdSupport Text highlighting on iOS 2015-07-24 08:41:58 -08:00
Animated Support for Animated.multiply node 2016-04-19 13:20:20 -07:00
AppRegistry Fix some warnings. 2016-04-20 20:45:22 -07:00
AppState Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
AppStateIOS Updating AppState to support the inactive state. 2016-03-10 08:30:24 -08:00
BatchedBridge Make object properties in NativeModules configurable. 2016-04-11 07:57:28 -07:00
BugReporting cleanup and open source JS BugReporting module 2016-04-20 08:09:07 -07:00
CameraRoll fix warning about async CameraRoll.getPhotos 2016-03-18 10:21:23 -07:00
Components Fix some warnings. 2016-04-20 20:45:22 -07:00
CustomComponents Fix initial scenes rendering. 2016-04-19 15:57:20 -07:00
DebugComponentHierarchy Decouple Module System from Native Calls 2015-12-08 16:03:37 -08:00
Device Decouple Module System from Native Calls 2015-12-08 16:03:37 -08:00
Devtools Increase RN devtools retry timeout 2016-04-01 07:02:25 -07:00
Experimental Fix potential "Should never unset includeInLayout" invariant 2016-04-19 13:55:26 -07:00
Fetch Reject promise if network request failed 2016-03-08 16:37:24 -08:00
Geolocation Copy comment from LocationModule.java to Geolocation.js 2016-04-13 07:53:23 -07:00
Image Added support for Image corner radii in Android 2016-04-13 07:42:20 -07:00
Inspector Hook up touchable debugging to Inspector button 2016-04-16 11:57:22 -07:00
Interaction Better Incremental/TaskQueue error reporting 2016-04-05 02:35:22 -07:00
JavaScriptAppEngine Setup RCTNativeAppEventEmitter on init 2016-03-15 03:45:33 -07:00
LayoutAnimation Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
Linking Mention native code in `Linking` docs 2016-04-20 19:23:19 -07:00
LinkingIOS Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
Modal Fix Popover.android to bubble events correctly 2016-04-20 00:59:27 -07:00
NativeApp Decouple Module System from Native Calls 2015-12-08 16:03:37 -08:00
NavigationExperimental Fix NavigationView. 2016-04-19 19:56:21 -07:00
Network Add support for ontimeout and onerror handler when using XMLHttpRequest for Android and iOS 2016-04-15 05:17:21 -07:00
Picker Add position to Picker onValueChange's call 2016-02-19 06:50:33 -08:00
PullToRefresh Fix red screen due to ref being undefined in PullRefreshViewAndroid 2016-04-19 06:58:22 -07:00
PushNotificationIOS Updated documentation of local notifications for PushNotificationIOS addEventListener() 2016-04-01 09:56:24 -07:00
QuickPerformanceLogger added QPL for main interactions 2015-09-29 22:25:23 -07:00
RCTTest CHORE - Remove Trailing Spaces 2016-04-06 09:21:53 -07:00
RKBackendNode Wrapped UIManager native module for better abstraction 2015-11-27 07:00:32 -08:00
ReactIOS Remove RKModal and Portal 2016-04-19 07:42:29 -07:00
ReactNative Prefix warning module with fbjs/lib/ 2016-04-09 13:24:28 -07:00
Sample Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
Settings Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
Storage Update AsyncStorage.js 2016-04-10 18:02:20 -07:00
StyleSheet Add a missing parenthese 2016-03-30 10:04:54 -07:00
Text Fixed some issues with zero fontSizeMultiplier causing RCTSHadowText measure function to return an infinite height 2016-04-21 03:57:18 -07:00
Utilities Add support for missing XHR response types 2016-04-11 05:54:28 -07:00
Vibration Add support for vibration patterns 2016-03-29 21:45:20 -07:00
WebSocket Add support for sending binary data in websockets 2016-04-20 08:53:25 -07:00
react-native Add deprecation warnings to ReactNative.addons 2016-04-11 18:20:28 -07:00
vendor Fix breakages caused by switch to fbjs 2016-03-02 08:26:33 -08:00
Promise.js Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
promiseRejectionIsError.js Add possibility to `console.error`/redbox on promise rejections 2016-03-15 05:22:22 -07:00