status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
A framework for building native apps with React. http://facebook.github.io/react-native/
200 Commits 61 Branches 315 Tags 184 MiB
JavaScript 47.5%
Java 26.5%
Objective-C 13.7%
C++ 7.2%
C 1.5%
Other 3.5%
Go to file
James Ide 62766e6077 [Text] Account for font leading so descenders are not clipped 
Summary:
Prior to this diff, descenders (the hanging tail on letters like g and j) were clipped on the last line because the text measurer did not account for the font leading. With `NSStringDrawingUsesFontLeading` it honors the fonts line spacing.

To test: open the Text demo of the UIExplorer and see that the bottom of the letter g is no longer clipped off.

## Before

![Screenshot Before](https://cloud.githubusercontent.com/assets/379606/6364746/1c5527a0-bc60-11e4-8aeb-2147a6eb6596.png)

## After

![Screenshot After](https://cloud.githubusercontent.com/assets/379606/6364747/1e9abe58-bc60-11e4-8c34-9f20ad8572ff.png)
Closes https://github.com/facebook/react-native/pull/96
Github Author: James Ide <ide@jameside.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
 		2015-03-23 11:40:24 -08:00
Examples more UIExplorer flow 2015-03-23 11:21:08 -08:00
IntegrationTests [ReactNative] Add AsyncStorageTest 2015-03-18 13:15:40 -08:00
Libraries [Text] Account for font leading so descenders are not clipped 2015-03-23 11:40:24 -08:00
ReactKit Added a graph view and a ReactNative metric that displays current queue and execution time for the JS thread. 2015-03-23 10:52:19 -08:00
jestSupport [react-packager] Better transform errors 2015-02-28 17:13:23 -08:00
lint [catalyst] set up directory specific rql transform 2015-03-12 17:12:31 -08:00
packager [ReactNative] Expanded license on js packager files 2015-03-23 11:28:51 -08:00
.eslintignore [react-packager][streamline oss] Move open sourced JS source to react-native-github 2015-02-19 21:25:11 -08:00
.eslintrc [react-packager] Fix lint errors 2015-02-25 20:29:42 -08:00
.flowconfig clean flow errors in react-native-github 2015-03-18 11:44:13 -08:00
linter.js [ReactNative] Bring back support for FB-specific transforms for lint 2015-03-02 12:23:34 -08:00
package.json [ReactNative] Remove react-native/package.json 2015-03-22 20:17:01 -08:00