mirror of
https://github.com/status-im/react-native.git
synced 2025-01-09 17:15:54 +00:00
23a34d4c65
Summary: Am writing an OAuth flow using `WebView`, when the OAuth provider redirects back to the [redirect_uri](https://developers.facebook.com/docs/facebook-login/manually-build-a-login-flow#logindialog) I intercept the request using `onShouldStartLoadWithRequest`, get the access token from the url and close the `WebView`. The problem I see is that when the OAuth provider redirects to the `redirect_uri` and I intercept it by returning false from `onShouldStartLoadWithRequest`, I get a WebKitErrorDomain error code 102 ("Frame load interrupted"). Looking at some other iOS libraries that implement OAuth with a WebView - it seems that the error can be ignored. eg. https://github.com/facebook/facebook-ios-sdk/blob/master/FBSDKCoreKit/FBSDKCoreKit/Internal/WebDialog/FBSDKWebDialogView.m#L146 https://github.com/evernote/evernote-sdk-ios/blob/master/evernote-sdk-ios/internal/ENOAuthViewController.m#L147 You can recreate the error using a url that automatically redirects, eg http://www.facebook.com -> https://www.facebook.com ```js <WebView source={{ uri: 'http://www.facebook.com' }} onShouldStartLoadWithRequest={(event) => { if (event.url.startsWith('https://www.facebook.com')) { return false; } return true; }} /> ``` Closes https://github.com/facebook/react-native/pull/12482 Differential Revision: D5154115 Pulled By: shergin fbshipit-source-id: 25151d00a1f97e17760617ee5aac6a0140c733c8