status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Explicitly cast to (bool) where needed on objc with folly::dynamic 

Reviewed By: yfeldblum

Differential Revision: D4711054

fbshipit-source-id: 00897ca703f0f3a8cddaf170fef53f9851b631af
This commit is contained in:
Marc Horowitz 2017-04-18 15:21:33 -07:00 committed by Facebook Github Bot
parent a5dea8d612
commit e7fe3b165b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
React/CxxUtils/RCTFollyConvert.mm
View File

@ -57,14 +57,14 @@ folly::dynamic convertIdToFollyDynamic(id json)
switch (objCType[0]) {
// This is a c++ bool or C99 _Bool. On some platforms, BOOL is a bool.
case _C_BOOL:
return [json boolValue];
return (bool) [json boolValue];
case _C_CHR:
// On some platforms, objc BOOL is a signed char, but it
// might also be a small number. Use the same hack JSC uses
// to distinguish them:
// https://phabricator.intern.facebook.com/diffusion/FBS/browse/master/fbobjc/xplat/third-party/jsc/safari-600-1-4-17/JavaScriptCore/API/JSValue.mm;b8ee03916489f8b12143cd5c0bca546da5014fc9$901
if ([json isKindOfClass:[@YES class]]) {
return [json boolValue];
return (bool) [json boolValue];
} else {
return [json longLongValue];
}