status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/docs
History
linh-le 7c89cf37c6 Change attribute mentioned in alignItem 
Summary:
Since alignItem works on the secondary axis, in the example, the value heigth: 50 should be deleted so that alignItem: 'stretch' can work. Not width: 50. In fact, width needs to be there, or else no component will be shown at all.

<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html

Happy contributing!

-->

(Write your motivation here.)

I'm going through the docs, that's why I found this. It's already tested!

Apologize if I'm contributing the wrong way. I read the instructions, but this is my first time ever, and will try to do it again correctly if needed.
Closes https://github.com/facebook/react-native/pull/16109

Differential Revision: D6017969

Pulled By: shergin

fbshipit-source-id: af37b831f1bb6206dabdaff36d4cb9e88fb1a496
 		2017-10-09 22:02:09 -07:00
..
Accessibility.md New guide: Improving User Experience 2017-08-24 14:01:53 -07:00
AndroidBuildingFromSource.md Document Android native communication 2017-09-19 14:16:41 -07:00
AndroidUIPerformance.md Merge Android UI Performance into Performance doc, reorder sidebar 2017-03-06 10:10:04 -08:00
Animations.md missing parentheses in example code 2017-09-27 21:30:17 -07:00
BuildingForAppleTV.md Apple TV: RCTTabBar selection controlled by native after render (fix #15081) 2017-08-10 05:36:06 -07:00
Colors.md New Handling Touches Tutorial 2017-06-07 11:51:21 -07:00
CommunicationAndroid.md Modernize docs: remove 'use strict' from docs -- es6 has 'use strict' by default 2017-10-03 17:17:12 -07:00
CommunicationIOS.md Modernize docs: remove 'use strict' from docs -- es6 has 'use strict' by default 2017-10-03 17:17:12 -07:00
ComponentsAndAPIs.md Fix navigation links in documentation. 2017-10-06 13:08:57 -07:00
Contributing.md Modernize docs: remove 'use strict' from docs -- es6 has 'use strict' by default 2017-10-03 17:17:12 -07:00
CustomWebViewAndroid.md Add props for overriding native component 2017-09-19 16:01:02 -07:00
CustomWebViewIOS.md Modernize docs: remove 'use strict' from docs -- es6 has 'use strict' by default 2017-10-03 17:17:12 -07:00
Debugging.md Document adb shell input keyevent 82 2017-10-09 22:02:09 -07:00
DirectManipulation.md Replace React.createClass with create-react-class 2017-07-07 14:36:01 -07:00
GestureResponderSystem.md New Handling Touches Tutorial 2017-06-07 11:51:21 -07:00
GettingStarted.md Move tabbing logic back to individual docs 2017-09-01 18:06:24 -07:00
HandlingTextInput.md Retry for #14830 - Fix "Handling Text Input" tutorial's "next" within text 2017-07-24 10:15:47 -07:00
HandlingTouches.md New Handling Touches Tutorial 2017-06-07 11:51:21 -07:00
HeadlessJSAndroid.md Update HeadlessJSAndroid.md explaining parameters 2017-09-21 08:51:00 -07:00
HeightAndWidth.md Update examples in docs and address version lag of CRNA 2017-05-16 23:51:28 -07:00
Images.md Correct logo URL 2017-10-04 14:38:02 -07:00
ImprovingUserExperience.md New guide: Improving User Experience 2017-08-24 14:01:53 -07:00
IntegrationWithExistingApps.md Modernize docs: remove 'use strict' from docs -- es6 has 'use strict' by default 2017-10-03 17:17:12 -07:00
JavaScriptEnvironment.md New Handling Touches Tutorial 2017-06-07 11:51:21 -07:00
LayoutWithFlexbox.md Change attribute mentioned in alignItem 2017-10-09 22:02:09 -07:00
LinkingLibraries.md Add props for overriding native component 2017-09-19 16:01:02 -07:00
Maintainers.md Flag large pull requests, add large-pr command 2017-08-16 21:00:44 -07:00
MoreResources.md Fix navigation links in documentation. 2017-10-06 13:08:57 -07:00
MoviesExample.json Fix typo and add comments to the example app 2015-03-27 20:44:20 +00:00
NativeComponentsAndroid.md Add props for overriding native component 2017-09-19 16:01:02 -07:00
NativeComponentsIOS.md Add props for overriding native component 2017-09-19 16:01:02 -07:00
NativeMethodsMixin.md Flat ReactNative renderer bundle [WIP] 2017-05-26 11:03:06 -07:00
NativeModulesAndroid.md Modernize docs: remove 'use strict' from docs -- es6 has 'use strict' by default 2017-10-03 17:17:12 -07:00
NativeModulesIOS.md Updated swift section to match current code base 2017-10-09 21:01:31 -07:00
Navigation.md Update Navigation.md 2017-07-24 11:31:01 -07:00
Networking.md New Handling Touches Tutorial 2017-06-07 11:51:21 -07:00
Performance.md Add pertinent info for fresh flatlisters 2017-08-07 17:58:42 -07:00
PlatformSpecificInformation.md Fix navigation links in documentation. 2017-10-06 13:08:57 -07:00
Props.md Standardize on using AwesomeProject for AppRegistry calls. 2017-05-30 14:20:42 -07:00
RunningOnDevice.md Move tabbing logic back to individual docs 2017-09-01 18:06:24 -07:00
RunningOnDeviceAndroid.md Consolidate Running on Device (Android|iOS) Guides into one 2016-11-06 21:13:32 -08:00
RunningOnDeviceIOS.md Consolidate Running on Device (Android|iOS) Guides into one 2016-11-06 21:13:32 -08:00
RunningOnSimulatorIOS.md Merge Android UI Performance into Performance doc, reorder sidebar 2017-03-06 10:10:04 -08:00
SignedAPKAndroid.md Documentation about ABI split in Android Release 2017-10-04 14:17:03 -07:00
State.md Standardize on using AwesomeProject for AppRegistry calls. 2017-05-30 14:20:42 -07:00
Style.md Standardize on using AwesomeProject for AppRegistry calls. 2017-05-30 14:20:42 -07:00
StyleGuide.md What to Expect from Maintainers 2017-07-28 08:18:53 -07:00
Testing.md Cleanup stray markdown files, update contributing guidelines 2017-08-04 16:18:01 -07:00
Timers.md New guide: Improving User Experience 2017-08-24 14:01:53 -07:00
TodayWidget.md Added documentation for iOS app extensions 2017-07-28 12:36:14 -07:00
Troubleshooting.md Add Troubleshooting Guide to Sidebar. 2017-08-25 15:30:43 -07:00
Tutorial.md Revert faulty change to HelloWorld demo in docs 2017-09-19 15:46:14 -07:00
UnderstandingCLI.md What to Expect from Maintainers 2017-07-28 08:18:53 -07:00
Upgrading.md Add Troubleshooting Guide to Sidebar. 2017-08-25 15:30:43 -07:00
UsingAListView.md Fix warning on SectionList's tutorial 2017-10-07 16:40:43 -07:00
UsingAScrollView.md New Handling Touches Tutorial 2017-06-07 11:51:21 -07:00