status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Correct logo URL 

Summary:
Update logo URL
https://facebook.github.io/react/img/logo_og.png (old) to https://facebook.github.io/react/logo-og.png (new)

Check that the old URL shows a "Page Not Found" and the new URL the correct image.
Closes https://github.com/facebook/react-native/pull/16204

Differential Revision: D5978967

Pulled By: TheSavior

fbshipit-source-id: f6af03dfd25d68c96e01054c256d8b6ba9fedba2
This commit is contained in:
Gustavo Gard 2017-10-04 14:33:20 -07:00 committed by Facebook Github Bot
parent 9c29ee1504
commit 2d2dfa26bc
6 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/Image/Image.android.js
View File

@ -55,7 +55,7 @@ function generateRequestId() {
* />
* <Image
* style={styles.logo}
* source={{uri: 'http://facebook.github.io/react/img/logo_og.png'}}
* source={{uri: 'https://facebook.github.io/react/logo-og.png'}}
* />
* </View>
* );

2
Libraries/Image/Image.ios.js
View File

@ -53,7 +53,7 @@ const ImageViewManager = NativeModules.ImageViewManager;
* />
* <Image
* style={{width: 50, height: 50}}
* source={{uri: 'https://facebook.github.io/react/img/logo_og.png'}}
* source={{uri: 'https://facebook.github.io/react/logo-og.png'}}
* />
* <Image
* style={{width: 66, height: 58}}

2
Libraries/Image/ImageBackground.js
View File

@ -33,7 +33,7 @@ import type {NativeMethodsMixinType} from 'ReactNativeTypes';
* return (
* <ImageBackground
* style={{width: 50, height: 50}}
* source={{uri: 'https://facebook.github.io/react/img/logo_og.png'}}
* source={{uri: 'https://facebook.github.io/react/logo-og.png'}}
* >
* <Text>React</Text>
* </ImageBackground>

4
RNTester/RNTesterUnitTests/RCTImageLoaderTests.m
View File

@ -54,7 +54,7 @@ RCTDefineImageDecoder(RCTImageLoaderTestsDecoder2)
NS_VALID_UNTIL_END_OF_SCOPE RCTBridge *bridge = [[RCTBridge alloc] initWithBundleURL:_bundleURL moduleProvider:^{ return @[loader]; } launchOptions:nil];
NSURLRequest *urlRequest = [NSURLRequest requestWithURL:[NSURL URLWithString:@"https://facebook.github.io/react/img/logo_og.png"]];
NSURLRequest *urlRequest = [NSURLRequest requestWithURL:[NSURL URLWithString:@"https://facebook.github.io/react/logo-og.png"]];
[bridge.imageLoader loadImageWithURLRequest:urlRequest size:CGSizeMake(100, 100) scale:1.0 clipped:YES resizeMode:RCTResizeModeContain progressBlock:^(int64_t progress, int64_t total) {
XCTAssertEqual(progress, 1);
XCTAssertEqual(total, 1);
@ -85,7 +85,7 @@ RCTDefineImageDecoder(RCTImageLoaderTestsDecoder2)
NS_VALID_UNTIL_END_OF_SCOPE RCTBridge *bridge = [[RCTBridge alloc] initWithBundleURL:_bundleURL moduleProvider:^{ return @[loader1, loader2]; } launchOptions:nil];
NSURLRequest *urlRequest = [NSURLRequest requestWithURL:[NSURL URLWithString:@"https://facebook.github.io/react/img/logo_og.png"]];
NSURLRequest *urlRequest = [NSURLRequest requestWithURL:[NSURL URLWithString:@"https://facebook.github.io/react/logo-og.png"]];
[bridge.imageLoader loadImageWithURLRequest:urlRequest size:CGSizeMake(100, 100) scale:1.0 clipped:YES resizeMode:RCTResizeModeContain progressBlock:^(int64_t progress, int64_t total) {
XCTAssertEqual(progress, 1);
XCTAssertEqual(total, 1);

8
RNTester/js/ImageExample.js
View File

@ -197,7 +197,7 @@ var MultipleSourcesExample = createReactClass({
source={[
{uri: 'https://facebook.github.io/react/img/logo_small.png', width: 38, height: 38},
{uri: 'https://facebook.github.io/react/img/logo_small_2x.png', width: 76, height: 76},
{uri: 'https://facebook.github.io/react/img/logo_og.png', width: 400, height: 400}
{uri: 'https://facebook.github.io/react/logo-og.png', width: 400, height: 400}
]}
/>
</View>
@ -237,7 +237,7 @@ exports.examples = [
render: function() {
return (
<Image
source={{uri: 'https://facebook.github.io/react/img/logo_og.png'}}
source={{uri: 'https://facebook.github.io/react/logo-og.png'}}
style={styles.base}
/>
);
@ -271,7 +271,7 @@ exports.examples = [
title: 'Error Handler',
render: function() {
return (
<NetworkImageExample source={{uri: 'https://TYPO_ERROR_facebook.github.io/react/img/logo_og.png'}} />
<NetworkImageExample source={{uri: 'https://TYPO_ERROR_facebook.github.io/react/logo-og.png'}} />
);
},
platform: 'ios',
@ -727,7 +727,7 @@ exports.examples = [
},
];
var fullImage = {uri: 'https://facebook.github.io/react/img/logo_og.png'};
var fullImage = {uri: 'https://facebook.github.io/react/logo-og.png'};
var smallImage = {uri: 'https://facebook.github.io/react/img/logo_small_2x.png'};
var styles = StyleSheet.create({

8
docs/Images.md
View File

@ -97,11 +97,11 @@ Many of the images you will display in your app will not be available at compile
```javascript
// GOOD
<Image source={{uri: 'https://facebook.github.io/react/img/logo_og.png'}}
<Image source={{uri: 'https://facebook.github.io/react/logo-og.png'}}
style={{width: 400, height: 400}} />
// BAD
<Image source={{uri: 'https://facebook.github.io/react/img/logo_og.png'}} />
<Image source={{uri: 'https://facebook.github.io/react/logo-og.png'}} />
```
### Network Requests for Images
@ -110,7 +110,7 @@ Many of the images you will display in your app will not be available at compile
```javascript
<Image source={{
uri: 'https://facebook.github.io/react/img/logo_og.png',
uri: 'https://facebook.github.io/react/logo-og.png',
method: 'POST',
headers: {
Pragma: 'no-cache'
@ -147,7 +147,7 @@ to a URL load request, no attempt is made to load the data from the originating
and the load is considered to have failed.
```javascript
<Image source={{uri: 'https://facebook.github.io/react/img/logo_og.png', cache: 'only-if-cached'}}
<Image source={{uri: 'https://facebook.github.io/react/logo-og.png', cache: 'only-if-cached'}}
style={{width: 400, height: 400}} />
```