0a35529d53
Reviewed By: mkonicek Differential Revision:D3054232 Ninja: oss only fb-gh-sync-id: 6cb9b361f62c1bc009a412049b47be99c423d6e9 shipit-source-id: 6cb9b361f62c1bc009a412049b47be99c423d6e9
1.2 KiB
Tips on reviewing pull requests
Does the PR miss info required in the Pull request template? Example: #6395. Add labels 'Needs revision' and 'Needs response from author'. Add a response like:
Hey @author, thanks for sending the pull request. Can you please add all the info specified in the template? This is necessary for people to be able to understand and review your pull request.
Does the code style match the Style guide, especially consistency (formatting, naming) with the rest of the codebase? If not, link to the style guide and add the label 'Needs revision'.
Does the pull request add a completely new feature we don't want to add to the core and maintain? Ask the author to release it a separate npm module and close the PR. Example: #2648.
Does the pull request do several unrelated things at the same time? Ask the author to split it.