mirror of
https://github.com/status-im/react-native.git
synced 2025-01-15 20:15:11 +00:00
01cb1e4ef6
Summary: We've been getting a lot of documentation PRs opened against `0.29-stable`, `0.30-stable`, and so on, instead of `master`. This is because our doc site is also based on RN release cuts, so clicking on the "Edit on GitHub" links on a document will take you to the markdown source for that release branch instead of the latest doc on `master`. See #9095 for an example of such a PR. In this PR we edit the link to say View on GitHub. Though it may not prevent PRs from being opened against a release branch, removing the "Edit" CTA may help in this regard. Closes https://github.com/facebook/react-native/pull/9149 Differential Revision: D3664368 Pulled By: vjeux fbshipit-source-id: 395c0813f736bfbe1be4b4fb1182f9060169365d
20 lines
1.1 KiB
Markdown
20 lines
1.1 KiB
Markdown
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:
|
|
|
|
> **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.**
|
|
|
|
Explain the **motivation** for making this change. What existing problem does the pull request solve?
|
|
|
|
Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
|
|
|
|
**Test plan (required)**
|
|
|
|
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
|
|
|
|
Make sure tests pass on both Travis and Circle CI.
|
|
|
|
**Code formatting**
|
|
|
|
Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide).
|
|
|
|
For more info, see the ["Pull Requests" section of our "Contributing" guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests).
|