Summary:
@vjeux and I were discussing this in irc an discovered that network gif images did not respond how they should to width, height or flex properties. Along the way I also noticed that the scale was not changing depending on the device. This PR fixes that, so now you can do `flex: 1` on a gif image to have it stretch to the whole screen. [Minimum reproducible example here](https://gist.github.com/brentvatne/f745377b0789162a28df) - try this without and then with the changes of this PR to see.
Closes https://github.com/facebook/react-native/pull/353
Github Author: Brent Vatne <brent.vatne@madriska.com>
Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary:
I think this line is a legacy code from `NativeModulesDeprecated`.
Closes https://github.com/facebook/react-native/pull/340
Github Author: Edward Kim <onward.edkim@gmail.com>
Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary:
`File not found` occurs in AppCode.
`sourceTree` of `RCTActionSheet.xcodeproj` is `<absolute>`. Because path is `../../Libraries/ActionSheetIOS/RCTActionSheet.xcodeproj`, that sourceTree is wrong.
Closes#338
Closes https://github.com/facebook/react-native/pull/344
Github Author: Leonardo YongUk Kim <dalinaum@gmail.com>
Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary:
This is a fix for #322
When setting a new image via the imageURL property, the new image
doesn't always replace the previous one when it is finished downloading
because the image view has a previously instated layer animation
on its contents. This cancels any animation prior to setting the new
contents to fix the issue.
Closes https://github.com/facebook/react-native/pull/337
Github Author: Julius Parishy <julius>
Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary:
Running "react-native start" from /Users/kevin/Dropbox (Personal)/Projects/AwesomeProject/ produces the following error
Error: Cannot find module '/Users/kevin/Dropbox'
at Function.Module._resolveFilename (module.js:322:15)
at Function.Module._load (module.js:264:25)
at Function.Module.runMain (module.js:487:10)
at startup (node.js:111:16)
at node.js:809:3
Closes https://github.com/facebook/react-native/pull/214
Github Author: Kevin Kwok <antimatter15@gmail.com>
Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary:
The CLI parse was accepting a string but assetRoots should be an array, so split on commas. Tested by specifying a root directory that was at least two folders up (../../stuff).
Closes https://github.com/facebook/react-native/pull/189
Github Author: James Ide <ide@jameside.com>
Test Plan:
* export to open source
* started server passing --assetRoots array
Martin Konicek
Brent Vatne
Ben Alpert
Andrei Coman
Alex Kotliarskyi
Edward Kim
Nick Lockwood
Amjad Masad
Leonardo YongUk Kim
Julius Parishy
Tadeu Zagallo
Kevin Kwok
Jakub Zika
Krzysztof Magiera
Alex Akers
Philipp von Weitershausen
Basil Hosmer
Eric Vicenti
James Ide
Christopher Chedeau
Marshall Roch